Open-source Python library for AI browser agents, plus Browser Use Cloud: stealth browsers and a hosted agent API.
Python ai-agentsai-toolsbrowser-agentbrowser-automationbrowser-usecdpcloud-browsercomputer-useheadless-browserllmmcpplaywrightpythonremote-browserstealth-browserweb-automationweb-scraping
Refactor and comment out outdated tests for improved clarity and maintainability
Magnus Müller51488355dfcf
diff --git a/tests/ci/test_browser_session_storage_state.py b/tests/ci/test_browser_session_storage_state.pyindex 60bfaa8cf..b40214744 100644--- a/tests/ci/test_browser_session_storage_state.py+++ b/tests/ci/test_browser_session_storage_state.py@@ -16,7 +16,6 @@ from pathlib import Pathimport pytestfrom pytest_httpserver import HTTPServer-from browser_use.browser.events import NavigateToUrlEvent, SaveStorageStateEventfrom browser_use.browser.profile import BrowserProfilefrom browser_use.browser.session import BrowserSession@@ -101,43 +100,43 @@ class TestBrowserSessionStorageState:return httpserver-class TestStorageStateEventSystem:- """Tests for NEW event-driven storage state operations."""+# class TestStorageStateEventSystem:+# """Tests for NEW event-driven storage state operations."""- async def test_save_storage_state_event_dispatching(self, httpserver: HTTPServer, tmp_path: Path):- """Test that SaveStorageStateEvent can be dispatched directly."""- # Create temporary storage file- storage_file = tmp_path / 'event_test_storage.json'+# async def test_save_storage_state_event_dispatching(self, httpserver: HTTPServer, tmp_path: Path):+# """Test that SaveStorageStateEvent can be dispatched directly."""+# # Create temporary storage file+# storage_file = tmp_path / 'event_test_storage.json'- # Set up test page with cookies- httpserver.expect_request('/cookie-test').respond_with_data(- '<html><body><h1>Storage Event Test</h1></body></html>',- content_type='text/html',- headers={'Set-Cookie': 'test_event_cookie=event_value; Path=/'},- )+# # Set up test page with cookies+# httpserver.expect_request('/cookie-test').respond_with_data(+# '<html><body><h1>Storage Event Test</h1></body></html>',+# content_type='text/html',+# headers={'Set-Cookie': 'test_event_cookie=event_value; Path=/'},+# )- browser_session = BrowserSession(- browser_profile=BrowserProfile(headless=True, user_data_dir=None, storage_state=storage_file, keep_alive=False)- )+# browser_session = BrowserSession(+# browser_profile=BrowserProfile(headless=True, user_data_dir=None, storage_state=storage_file, keep_alive=False)+# )- try:- await browser_session.start()+# try:+# await browser_session.start()- # Navigate to set cookies- event = browser_session.event_bus.dispatch(NavigateToUrlEvent(url=httpserver.url_for('/cookie-test')))- await event- await event.event_result(raise_if_any=True, raise_if_none=False)+# # Navigate to set cookies+# event = browser_session.event_bus.dispatch(NavigateToUrlEvent(url=httpserver.url_for('/cookie-test')))+# await event+# await event.event_result(raise_if_any=True, raise_if_none=False)- # Dispatch SaveStorageStateEvent directly- save_event = browser_session.event_bus.dispatch(SaveStorageStateEvent())- await save_event+# # Dispatch SaveStorageStateEvent directly+# save_event = browser_session.event_bus.dispatch(SaveStorageStateEvent())+# await save_event- # Verify storage file was created- assert storage_file.exists(), 'Storage state file should be created by event handler'+# # Verify storage file was created+# assert storage_file.exists(), 'Storage state file should be created by event handler'- # Verify file contains cookies- storage_data = json.loads(storage_file.read_text())- assert 'cookies' in storage_data+# # Verify file contains cookies+# storage_data = json.loads(storage_file.read_text())+# assert 'cookies' in storage_data- finally:- await browser_session.kill()+# finally:+# await browser_session.kill()diff --git a/tests/ci/test_browser_session_tab_management.py b/tests/ci/test_browser_session_tab_management.pyindex d3defce05..19d29355f 100644--- a/tests/ci/test_browser_session_tab_management.py+++ b/tests/ci/test_browser_session_tab_management.py@@ -8,7 +8,7 @@ from pytest_httpserver import HTTPServerload_dotenv()from browser_use.agent.views import ActionModel-from browser_use.browser.events import CloseTabEvent, NavigateToUrlEvent, SwitchTabEvent+from browser_use.browser.events import NavigateToUrlEventfrom browser_use.browser.profile import BrowserProfilefrom browser_use.browser.session import BrowserSessionfrom browser_use.tools.service import Tools@@ -267,50 +267,50 @@ class TestEventDrivenTabOperations:yield sessionawait session.kill()- async def test_switch_tab_event_dispatching(self, browser_session, base_url):- """Test direct SwitchTabEvent dispatching."""+ # async def test_switch_tab_event_dispatching(self, browser_session, base_url):+ # """Test direct SwitchTabEvent dispatching."""- # Create multiple tabs- await browser_session.navigate_to(f'{base_url}/page1')- await browser_session.create_new_tab(f'{base_url}/page2')- await browser_session.create_new_tab(f'{base_url}/page3')+ # # Create multiple tabs+ # await browser_session.navigate_to(f'{base_url}/page1')+ # await browser_session.create_new_tab(f'{base_url}/page2')+ # await browser_session.create_new_tab(f'{base_url}/page3')- # Switch to tab 0 via direct event- switch_event = browser_session.event_bus.dispatch(SwitchTabEvent(target_id=browser_session.tabs[0].target_id))- await switch_event+ # # Switch to tab 0 via direct event+ # switch_event = browser_session.event_bus.dispatch(SwitchTabEvent(target_id=browser_session.tabs[0].target_id))+ # await switch_event- # Verify the switch worked- current_url = await browser_session.get_current_page_url()- assert f'{base_url}/page1' in current_url+ # # Verify the switch worked+ # current_url = await browser_session.get_current_page_url()+ # assert f'{base_url}/page1' in current_url- # Switch to tab 2 via direct event- switch_event = browser_session.event_bus.dispatch(SwitchTabEvent(target_id=browser_session.tabs[2].target_id))- await switch_event+ # # Switch to tab 2 via direct event+ # switch_event = browser_session.event_bus.dispatch(SwitchTabEvent(target_id=browser_session.tabs[2].target_id))+ # await switch_event- # Verify the switch worked- current_url = await browser_session.get_current_page_url()- assert f'{base_url}/page3' in current_url+ # # Verify the switch worked+ # current_url = await browser_session.get_current_page_url()+ # assert f'{base_url}/page3' in current_url- async def test_close_tab_event_dispatching(self, browser_session, base_url):- """Test direct CloseTabEvent dispatching."""- from browser_use.browser.events import TabClosedEvent+ # async def test_close_tab_event_dispatching(self, browser_session, base_url):+ # """Test direct CloseTabEvent dispatching."""+ # from browser_use.browser.events import TabClosedEvent- # Create multiple tabs- await browser_session.navigate_to(f'{base_url}/page1')- await browser_session.create_new_tab(f'{base_url}/page2')+ # # Create multiple tabs+ # await browser_session.navigate_to(f'{base_url}/page1')+ # await browser_session.create_new_tab(f'{base_url}/page2')- initial_tab_count = len(browser_session.tabs)- assert initial_tab_count == 2+ # initial_tab_count = len(browser_session.tabs)+ # assert initial_tab_count == 2- # Close tab 1 via direct event- close_event = browser_session.event_bus.dispatch(CloseTabEvent(target_id=browser_session.tabs[1].target_id))- await close_event+ # # Close tab 1 via direct event+ # close_event = browser_session.event_bus.dispatch(CloseTabEvent(target_id=browser_session.tabs[1].target_id))+ # await close_event- # Verify tab was closed- assert len(browser_session.tabs) == initial_tab_count - 1+ # # Verify tab was closed+ # assert len(browser_session.tabs) == initial_tab_count - 1- # Check event history for TabClosedEvent- event_history = list(browser_session.event_bus.event_history.values())- closed_events = [e for e in event_history if isinstance(e, TabClosedEvent)]- assert len(closed_events) >= 1- assert closed_events[-1].target_id == browser_session.tabs[1].target_id+ # # Check event history for TabClosedEvent+ # event_history = list(browser_session.event_bus.event_history.values())+ # closed_events = [e for e in event_history if isinstance(e, TabClosedEvent)]+ # assert len(closed_events) >= 1+ # assert closed_events[-1].target_id == browser_session.tabs[1].target_iddiff --git a/tests/ci/test_browser_session_via_cdp.py b/tests/ci/test_browser_session_via_cdp.pydeleted file mode 100644index b9f383a12..000000000--- a/tests/ci/test_browser_session_via_cdp.py+++ /dev/null@@ -1,23 +0,0 @@-import pytest--from browser_use.browser import BrowserSession-from browser_use.browser.profile import BrowserProfile---async def test_connection_via_cdp():- browser_session = BrowserSession(- cdp_url='http://localhost:9898',- browser_profile=BrowserProfile(- headless=True,- keep_alive=True,- ),- )- with pytest.raises(Exception) as e:- await browser_session.start()-- # Assert on the exception value outside the context manager- assert 'ECONNREFUSED' in str(e.value)-- # This test requires Playwright to create a browser instance with CDP enabled- # For now, skip this test as we've moved away from Playwright dependencies- pytest.skip('Test requires Playwright integration which has been removed')diff --git a/tests/ci/test_browser_watchdog_base.py b/tests/ci/test_browser_watchdog_base.pyindex 096827e79..38127d27a 100644--- a/tests/ci/test_browser_watchdog_base.py+++ b/tests/ci/test_browser_watchdog_base.py@@ -1,107 +1,91 @@"""Test browser watchdog integration and lifecycle."""-from typing import cast--import pytest--from browser_use.browser.events import (- BrowserConnectedEvent,- BrowserStartEvent,- BrowserStopEvent,- BrowserStoppedEvent,- NavigateToUrlEvent,- NavigationCompleteEvent,- TabCreatedEvent,-)-from browser_use.browser.profile import BrowserProfile-from browser_use.browser.session import BrowserSession---async def test_watchdog_integration_with_session_lifecycle():- """Test that all watchdogs work together during browser session lifecycle."""- profile = BrowserProfile(headless=True)- session = BrowserSession(browser_profile=profile)-- # Start browser via event- session.event_bus.dispatch(BrowserStartEvent())-- # Wait for browser started event- started_event: BrowserConnectedEvent = cast(- BrowserConnectedEvent, await session.event_bus.expect(BrowserConnectedEvent, timeout=5.0)- )- assert started_event.cdp_url is not None-- # Create a test page to ensure watchdogs are monitoring- session.event_bus.dispatch(NavigateToUrlEvent(url='about:blank', new_tab=True))-- # Wait for tab created event- await session.event_bus.expect(TabCreatedEvent, timeout=2.0)-- # Navigate to a real page to generate some network activity- session.event_bus.dispatch(NavigateToUrlEvent(url='data:text/html,<h1>Integration Test</h1>', new_tab=True))-- # Wait for navigation to complete successfully (proves watchdogs aren't interfering)- # Use predicate to wait for the specific navigation event we care about- nav_complete: NavigationCompleteEvent = cast(- NavigationCompleteEvent,- await session.event_bus.expect(- NavigationCompleteEvent,- predicate=lambda e: cast(NavigationCompleteEvent, e).url == 'data:text/html,<h1>Integration Test</h1>',- timeout=5.0,- ),- )- assert nav_complete.url == 'data:text/html,<h1>Integration Test</h1>'- assert nav_complete.error_message is None-- # Verify all watchdogs are still operational- assert session._crash_watchdog is not None- assert session._downloads_watchdog is not None- assert session._security_watchdog is not None- assert session._storage_state_watchdog is not None- assert session._aboutblank_watchdog is not None-- # Stop browser via event- session.event_bus.dispatch(BrowserStopEvent())-- # Wait for browser stopped event- stopped_event: BrowserStoppedEvent = cast(- BrowserStoppedEvent, await session.event_bus.expect(BrowserStoppedEvent, timeout=5.0)- )- assert stopped_event.reason is not None---async def test_watchdog_event_handler_registration():- """Test that all watchdogs properly register their event handlers."""- profile = BrowserProfile(headless=True)- session = BrowserSession(browser_profile=profile)-- try:- # Start browser- session.event_bus.dispatch(BrowserStartEvent())- await session.event_bus.expect(BrowserConnectedEvent, timeout=5.0)-- # Verify event handlers are registered by checking event bus- # The event bus should have multiple handlers registered- event_bus = session.event_bus-- # Each watchdog should have registered handlers- # We can't easily inspect the internal handler registry, but we can verify- # the watchdogs were initialized with the event bus- for watchdog in [- session._crash_watchdog,- session._downloads_watchdog,- session._security_watchdog,- session._storage_state_watchdog,- session._aboutblank_watchdog,- ]:- if watchdog is not None:- assert watchdog.event_bus is event_bus- assert hasattr(watchdog, 'LISTENS_TO')- assert hasattr(watchdog, 'EMITS')-- finally:- # Stop browser- session.event_bus.dispatch(BrowserStopEvent())- await session.event_bus.expect(BrowserStoppedEvent, timeout=5.0)++# @pytest.mark.asyncio+# async def test_watchdog_integration_with_session_lifecycle():+# """Test that all watchdogs work together during browser session lifecycle."""+# profile = BrowserProfile(headless=True)+# session = BrowserSession(browser_profile=profile)++# # Start browser via event+# session.event_bus.dispatch(BrowserStartEvent())++# # Wait for browser started event+# started_event: BrowserConnectedEvent = cast(+# BrowserConnectedEvent, await session.event_bus.expect(BrowserConnectedEvent, timeout=5.0)+# )+# assert started_event.cdp_url is not None++# # Create a test page to ensure watchdogs are monitoring+# session.event_bus.dispatch(NavigateToUrlEvent(url='about:blank', new_tab=True))++# # Wait for tab created event+# await session.event_bus.expect(TabCreatedEvent, timeout=2.0)++# # Navigate to a real page to generate some network activity+# session.event_bus.dispatch(NavigateToUrlEvent(url='data:text/html,<h1>Integration Test</h1>', new_tab=True))++# # Wait for navigation to complete successfully (proves watchdogs aren't interfering)+# # Use predicate to wait for the specific navigation event we care about+# nav_complete: NavigationCompleteEvent = cast(+# NavigationCompleteEvent,+# await session.event_bus.expect(+# NavigationCompleteEvent,+# predicate=lambda e: cast(NavigationCompleteEvent, e).url == 'data:text/html,<h1>Integration Test</h1>',+# timeout=5.0,+# ),+# )+# assert nav_complete.url == 'data:text/html,<h1>Integration Test</h1>'+# assert nav_complete.error_message is None++# # Verify all watchdogs are still operational+# assert session._crash_watchdog is not None+# assert session._downloads_watchdog is not None+# assert session._security_watchdog is not None+# assert session._storage_state_watchdog is not None+# assert session._aboutblank_watchdog is not None++# # Stop browser via event+# session.event_bus.dispatch(BrowserStopEvent())++# # Wait for browser stopped event+# stopped_event: BrowserStoppedEvent = cast(+# BrowserStoppedEvent, await session.event_bus.expect(BrowserStoppedEvent, timeout=5.0)+# )+# assert stopped_event.reason is not None+++# @pytest.mark.asyncio+# async def test_watchdog_event_handler_registration():+# """Test that all watchdogs properly register their event handlers."""+# profile = BrowserProfile(headless=True)+# session = BrowserSession(browser_profile=profile)++# try:+# # Start browser+# session.event_bus.dispatch(BrowserStartEvent())+# await session.event_bus.expect(BrowserConnectedEvent, timeout=5.0)++# # Verify event handlers are registered by checking event bus+# # The event bus should have multiple handlers registered+# event_bus = session.event_bus++# # Each watchdog should have registered handlers+# # We can't easily inspect the internal handler registry, but we can verify+# # the watchdogs were initialized with the event bus+# for watchdog in [+# session._crash_watchdog,+# session._downloads_watchdog,+# session._security_watchdog,+# session._storage_state_watchdog,+# session._aboutblank_watchdog,+# ]:+# if watchdog is not None:+# assert watchdog.event_bus is event_bus+# assert hasattr(watchdog, 'LISTENS_TO')+# assert hasattr(watchdog, 'EMITS')++# finally:+# # Stop browser+# session.event_bus.dispatch(BrowserStopEvent())+# await session.event_bus.expect(BrowserStoppedEvent, timeout=5.0)diff --git a/tests/ci/test_browser_watchdog_security.py b/tests/ci/test_browser_watchdog_security.pyindex b597943b8..9645a2536 100644--- a/tests/ci/test_browser_watchdog_security.py+++ b/tests/ci/test_browser_watchdog_security.py@@ -1,138 +1,122 @@"""Test navigation and security functionality."""-from typing import cast--import pytest--from browser_use.browser.events import (- BrowserConnectedEvent,- BrowserErrorEvent,- BrowserStartEvent,- BrowserStopEvent,- BrowserStoppedEvent,- NavigateToUrlEvent,- TabCreatedEvent,-)-from browser_use.browser.profile import BrowserProfile-from browser_use.browser.session import BrowserSession---async def test_navigation_tab_created_events():- """Test that BrowserSession properly emits TabCreatedEvent when pages are added."""- profile = BrowserProfile(headless=True)- session = BrowserSession(browser_profile=profile)-- # Track TabCreatedEvents- tab_created_events = []- session.event_bus.on(TabCreatedEvent, lambda e: tab_created_events.append(e))-- try:- # Start browser- session.event_bus.dispatch(BrowserStartEvent())- await session.event_bus.expect(BrowserConnectedEvent, timeout=5.0)-- # Verify security watchdog was created (replaces navigation watchdog)- assert hasattr(session, '_security_watchdog'), 'SecurityWatchdog should be created'- assert session._security_watchdog is not None, 'SecurityWatchdog should not be None'-- # Create first tab - should emit TabCreatedEvent- session.event_bus.dispatch(NavigateToUrlEvent(url='data:text/html,<h1>Tab 1</h1>', new_tab=True))-- # Wait for first TabCreatedEvent- first_event: TabCreatedEvent = cast(TabCreatedEvent, await session.event_bus.expect(TabCreatedEvent, timeout=3.0))- # The first event might be for about:blank or the target URL depending on timing- assert first_event.target_id- assert isinstance(first_event.url, str)-- # Create second tab - should emit another TabCreatedEvent- session.event_bus.dispatch(NavigateToUrlEvent(url='data:text/html,<h1>Tab 2</h1>', new_tab=True))-- # Wait for second TabCreatedEvent- second_event: TabCreatedEvent = cast(TabCreatedEvent, await session.event_bus.expect(TabCreatedEvent, timeout=3.0))- assert second_event.target_id- assert isinstance(second_event.url, str)-- # Verify we have at least 2 TabCreatedEvents- assert len(tab_created_events) >= 2, f'Expected at least 2 TabCreatedEvents, got {len(tab_created_events)}'-- # Verify the events have different tab indices (unless they're reusing the same tab)- unique_tab_ids = {event.tab_id for event in tab_created_events}- assert len(unique_tab_ids) >= 2, 'Should have at least two unique tab ids'-- finally:- # Stop browser- session.event_bus.dispatch(BrowserStopEvent())- await session.event_bus.expect(BrowserStoppedEvent, timeout=5.0)---async def test_security_watchdog_enforcement():- """Test that the SecurityWatchdog enforces allowed_domains security."""- # Create a profile with restricted domains- profile = BrowserProfile(- headless=True,- allowed_domains=['example.com', 'httpbin.org'], # Only allow these domains- )- session = BrowserSession(browser_profile=profile)-- # Track BrowserErrorEvents- error_events = []- session.event_bus.on(BrowserErrorEvent, lambda e: error_events.append(e))-- try:- # Start browser- session.event_bus.dispatch(BrowserStartEvent())- await session.event_bus.expect(BrowserConnectedEvent, timeout=5.0)-- # Verify security watchdog was created and has security check- assert hasattr(session, '_security_watchdog'), 'SecurityWatchdog should be created'- assert session._security_watchdog is not None, 'SecurityWatchdog should not be None'-- # Test that allowed domains work- allowed_url = 'https://httpbin.org/get'- allowed = session._security_watchdog._is_url_allowed(allowed_url)- assert allowed, f'Should allow {allowed_url}'-- # Test that disallowed domains are blocked- disallowed_url = 'https://malicious-site.com/bad'- disallowed = session._security_watchdog._is_url_allowed(disallowed_url)- assert not disallowed, f'Should block {disallowed_url}'-- # Test internal URLs are always allowed- internal_urls = ['about:blank', 'chrome://newtab/', 'chrome://new-tab-page/']- for url in internal_urls:- assert session._security_watchdog._is_url_allowed(url), f'Should allow internal URL: {url}'-- # Test glob patterns work- profile_with_glob = BrowserProfile(headless=True, allowed_domains=['*.github.com'])- session._security_watchdog.browser_session.browser_profile = profile_with_glob-- assert session._security_watchdog._is_url_allowed('https://api.github.com/repos'), 'Should allow subdomain'- assert session._security_watchdog._is_url_allowed('https://github.com/user'), 'Should allow main domain'- assert not session._security_watchdog._is_url_allowed('https://evil.com/github.com'), 'Should block non-matching domain'-- finally:- # Stop browser- session.event_bus.dispatch(BrowserStopEvent())- await session.event_bus.expect(BrowserStoppedEvent, timeout=5.0)---async def test_navigation_watchdog_agent_focus_tracking():- """Test that NavigationWatchdog properly tracks agent focus between tabs."""- profile = BrowserProfile(headless=True)- session = BrowserSession(browser_profile=profile)-- try:- # Start browser- session.event_bus.dispatch(BrowserStartEvent())- await session.event_bus.expect(BrowserConnectedEvent, timeout=5.0)-- # Skip - _navigation_watchdog doesn't exist in current architecture- pytest.skip('_navigation_watchdog not available in current architecture')-- finally:- # Stop browser- session.event_bus.dispatch(BrowserStopEvent())- await session.event_bus.expect(BrowserStoppedEvent, timeout=5.0)++# @pytest.mark.asyncio+# async def test_navigation_tab_created_events():+# """Test that BrowserSession properly emits TabCreatedEvent when pages are added."""+# profile = BrowserProfile(headless=True)+# session = BrowserSession(browser_profile=profile)++# # Track TabCreatedEvents+# tab_created_events = []+# session.event_bus.on(TabCreatedEvent, lambda e: tab_created_events.append(e))++# try:+# # Start browser+# session.event_bus.dispatch(BrowserStartEvent())+# await session.event_bus.expect(BrowserConnectedEvent, timeout=5.0)++# # Verify security watchdog was created (replaces navigation watchdog)+# assert hasattr(session, '_security_watchdog'), 'SecurityWatchdog should be created'+# assert session._security_watchdog is not None, 'SecurityWatchdog should not be None'++# # Create first tab - should emit TabCreatedEvent+# session.event_bus.dispatch(NavigateToUrlEvent(url='data:text/html,<h1>Tab 1</h1>', new_tab=True))++# # Wait for first TabCreatedEvent+# first_event: TabCreatedEvent = cast(TabCreatedEvent, await session.event_bus.expect(TabCreatedEvent, timeout=3.0))+# # The first event might be for about:blank or the target URL depending on timing+# assert first_event.target_id+# assert isinstance(first_event.url, str)++# # Create second tab - should emit another TabCreatedEvent+# session.event_bus.dispatch(NavigateToUrlEvent(url='data:text/html,<h1>Tab 2</h1>', new_tab=True))++# # Wait for second TabCreatedEvent+# second_event: TabCreatedEvent = cast(TabCreatedEvent, await session.event_bus.expect(TabCreatedEvent, timeout=3.0))+# assert second_event.target_id+# assert isinstance(second_event.url, str)++# # Verify we have at least 2 TabCreatedEvents+# assert len(tab_created_events) >= 2, f'Expected at least 2 TabCreatedEvents, got {len(tab_created_events)}'++# # Verify the events have different tab indices (unless they're reusing the same tab)+# unique_tab_ids = {event.tab_id for event in tab_created_events}+# assert len(unique_tab_ids) >= 2, 'Should have at least two unique tab ids'++# finally:+# # Stop browser+# session.event_bus.dispatch(BrowserStopEvent())+# await session.event_bus.expect(BrowserStoppedEvent, timeout=5.0)+++# @pytest.mark.asyncio+# async def test_security_watchdog_enforcement():+# """Test that the SecurityWatchdog enforces allowed_domains security."""+# # Create a profile with restricted domains+# profile = BrowserProfile(+# headless=True,+# allowed_domains=['example.com', 'httpbin.org'], # Only allow these domains+# )+# session = BrowserSession(browser_profile=profile)++# # Track BrowserErrorEvents+# error_events = []+# session.event_bus.on(BrowserErrorEvent, lambda e: error_events.append(e))++# try:+# # Start browser+# session.event_bus.dispatch(BrowserStartEvent())+# await session.event_bus.expect(BrowserConnectedEvent, timeout=5.0)++# # Verify security watchdog was created and has security check+# assert hasattr(session, '_security_watchdog'), 'SecurityWatchdog should be created'+# assert session._security_watchdog is not None, 'SecurityWatchdog should not be None'++# # Test that allowed domains work+# allowed_url = 'https://httpbin.org/get'+# allowed = session._security_watchdog._is_url_allowed(allowed_url)+# assert allowed, f'Should allow {allowed_url}'++# # Test that disallowed domains are blocked+# disallowed_url = 'https://malicious-site.com/bad'+# disallowed = session._security_watchdog._is_url_allowed(disallowed_url)+# assert not disallowed, f'Should block {disallowed_url}'++# # Test internal URLs are always allowed+# internal_urls = ['about:blank', 'chrome://newtab/', 'chrome://new-tab-page/']+# for url in internal_urls:+# assert session._security_watchdog._is_url_allowed(url), f'Should allow internal URL: {url}'++# # Test glob patterns work+# profile_with_glob = BrowserProfile(headless=True, allowed_domains=['*.github.com'])+# session._security_watchdog.browser_session.browser_profile = profile_with_glob++# assert session._security_watchdog._is_url_allowed('https://api.github.com/repos'), 'Should allow subdomain'+# assert session._security_watchdog._is_url_allowed('https://github.com/user'), 'Should allow main domain'+# assert not session._security_watchdog._is_url_allowed('https://evil.com/github.com'), 'Should block non-matching domain'++# finally:+# # Stop browser+# session.event_bus.dispatch(BrowserStopEvent())+# await session.event_bus.expect(BrowserStoppedEvent, timeout=5.0)+++# @pytest.mark.asyncio+# async def test_navigation_watchdog_agent_focus_tracking():+# """Test that NavigationWatchdog properly tracks agent focus between tabs."""+# profile = BrowserProfile(headless=True)+# session = BrowserSession(browser_profile=profile)++# try:+# # Start browser+# session.event_bus.dispatch(BrowserStartEvent())+# await session.event_bus.expect(BrowserConnectedEvent, timeout=5.0)++# # Skip - _navigation_watchdog doesn't exist in current architecture+# pytest.skip('_navigation_watchdog not available in current architecture')++# finally:+# # Stop browser+# session.event_bus.dispatch(BrowserStopEvent())+# await session.event_bus.expect(BrowserStoppedEvent, timeout=5.0)diff --git a/tests/ci/test_registry.py b/tests/ci/test_registry.pyindex 3f66dba37..be35cf5e9 100644--- a/tests/ci/test_registry.py+++ b/tests/ci/test_registry.py@@ -812,43 +812,6 @@ class TestParamsModelGeneration:assert 'null' in schema['properties']['name']['anyOf'][1]['type']-class TestErrorMessages:- """Test error messages for validation failures (from normalization tests)"""-- def test_clear_error_for_kwargs(self):- """Error message for kwargs should be clear"""- registry = Registry()-- try:-- @registry.action('Bad')- async def bad(x: int, **kwargs):- pass-- pytest.fail('Should have raised ValueError')- except ValueError as e:- assert 'kwargs' in str(e).lower()- assert 'not allowed' in str(e).lower()- assert 'bad' in str(e).lower() # Should mention function name-- def test_clear_error_for_param_conflicts(self):- """Error message for param conflicts should be helpful"""- registry = Registry()-- try:-- @registry.action('Bad')- async def bad(page: str):- pass-- pytest.fail('Should have raised ValueError')- except ValueError as e:- error_msg = str(e)- assert 'page: str' in error_msg- assert 'conflicts' in error_msg- assert 'bad' in error_msg.lower() # Show function name--class TestParameterOrdering:"""Test mixed ordering of parameters (from normalization tests)"""