Skip to content

Open-source Python library for AI browser agents, plus Browser Use Cloud: stealth browsers and a hosted agent API.

when click_element_by_index fails, auto-call get_dropdown_options and return result directly

Nick Sweeting5bc9cbe141b9
diff --git a/browser_use/browser/default_action_watchdog.py b/browser_use/browser/default_action_watchdog.py
index ff7e09c21..b3a07b706 100644
--- a/browser_use/browser/default_action_watchdog.py
+++ b/browser_use/browser/default_action_watchdog.py
@@ -230,24 +230,9 @@ class DefaultActionWatchdog(BaseWatchdog):
element_type = element_node.attributes.get('type', '').lower() if element_node.attributes else ''
if tag_name == 'select':
- try:
- dropdown_options = (
- await self.event_bus.dispatch(GetDropdownOptionsEvent(node=element_node)).event_result(raise_if_none=True)
- or {}
- )
- except Exception as e:
- self.logger.warning(f'Failed to get dropdown options: {type(e).__name__}: {e}')
- dropdown_options = {}
- available_options = (
- ('Available options: [' + ', '.join(dropdown_options.keys()) + ']')
- if dropdown_options and len(dropdown_options) < 100
- else 'Call get_dropdown_options() to get available options list.'
- )
- self.logger.warning(
- f'Cannot click on <select> elements. Use select_dropdown_option() action instead. {available_options}]'
- )
+ self.logger.warning('Cannot click on <select> elements. Use select_dropdown_option() action instead.')
raise Exception(
- f'<llm_error_msg>Cannot click on <select> elements. Use select_dropdown_option() action instead. {available_options}</llm_error_msg>'
+ '<llm_error_msg>Cannot click on <select> elements. Use select_dropdown_option() action instead.</llm_error_msg>'
)
if tag_name == 'input' and element_type == 'file':
@@ -1485,15 +1470,15 @@ class DefaultActionWatchdog(BaseWatchdog):
status = ' (selected)' if opt.get('selected') else ''
formatted_options.append(f'{opt["index"]}: text={encoded_text}, value={json.dumps(opt["value"])}{status}')
- dropdown_type = dropdown_data.get('type', 'unknown')
- element_info = f'ID: {dropdown_data.get("id", "none")}, Name: {dropdown_data.get("name", "none")}'
+ dropdown_type = dropdown_data.get('type', 'select')
+ element_info = f'Index: {index_for_logging}, Type: {dropdown_type}, ID: {dropdown_data.get("id", "none")}, Name: {dropdown_data.get("name", "none")}'
source_info = dropdown_data.get('source', 'unknown')
if source_info == 'target':
msg = f'Found {dropdown_type} dropdown ({element_info}):\n' + '\n'.join(formatted_options)
else:
msg = f'Found {dropdown_type} dropdown in {source_info} ({element_info}):\n' + '\n'.join(formatted_options)
- msg += '\n\nUse the exact text string (without quotes) in select_dropdown_option'
+ msg += f'\n\nUse the exact text or value string (without quotes) in select_dropdown_option(index={index_for_logging}, text=...)'
if source_info == 'target':
self.logger.info(f'📋 Found {len(dropdown_data["options"])} dropdown options for index {index_for_logging}')
diff --git a/browser_use/browser/events.py b/browser_use/browser/events.py
index 7358780d9..99f2b60e7 100644
--- a/browser_use/browser/events.py
+++ b/browser_use/browser/events.py
@@ -216,17 +216,19 @@ class UploadFileEvent(ElementSelectedEvent[None]):
class GetDropdownOptionsEvent(ElementSelectedEvent[dict[str, str]]):
"""Get all options from any dropdown (native <select>, ARIA menus, or custom dropdowns).
-
+
Returns a dict containing dropdown type, options list, and element metadata."""
node: 'EnhancedDOMTreeNode'
- event_timeout: float | None = 8.0 # seconds
+ event_timeout: float | None = (
+ 15.0 # some dropdowns lazy-load the list of options on first interaction, so we need to wait for them to load (e.g. table filter lists can have thousands of options)
+ )
class SelectDropdownOptionEvent(ElementSelectedEvent[dict[str, str]]):
"""Select a dropdown option by exact text from any dropdown type.
-
+
Returns a dict containing success status and selection details."""
node: 'EnhancedDOMTreeNode'
@@ -367,7 +369,7 @@ class TabClosedEvent(BaseEvent):
event_timeout: float | None = 10.0 # seconds
-# TODO: emit this when DOM changes signficiantly, inner frame navigates, form submits, history.pushState(), etc.
+# TODO: emit this when DOM changes significantly, inner frame navigates, form submits, history.pushState(), etc.
# class TabUpdatedEvent(BaseEvent):
# """Tab information updated (URL changed, etc.)."""
diff --git a/browser_use/controller/service.py b/browser_use/controller/service.py
index 1c32ad810..46ce579a9 100644
--- a/browser_use/controller/service.py
+++ b/browser_use/controller/service.py
@@ -16,6 +16,7 @@ from browser_use.browser import BrowserSession
from browser_use.browser.events import (
ClickElementEvent,
CloseTabEvent,
+ GetDropdownOptionsEvent,
GoBackEvent,
NavigateToUrlEvent,
ScrollEvent,
@@ -289,6 +290,14 @@ class Controller(Generic[Context]):
logger.error(f'Failed to execute ClickElementEvent: {type(e).__name__}: {e}')
clean_msg = extract_llm_error_message(e)
error_msg = f'Failed to click element {params.index}: {clean_msg}'
+
+ # If it's a select dropdown error, automatically get the dropdown options
+ if '<select> element' in str(e) and node:
+ try:
+ return await get_dropdown_options(index=params.index, browser_session=browser_session)
+ except Exception as dropdown_error:
+ pass
+
return ActionResult(error=error_msg)
@self.registry.action(
@@ -716,8 +725,6 @@ Provide the extracted information in a clear, structured format."""
# Dispatch GetDropdownOptionsEvent to the event handler
import json
- from browser_use.browser.events import GetDropdownOptionsEvent
-
event = browser_session.event_bus.dispatch(GetDropdownOptionsEvent(node=node))
dropdown_data = await event.event_result(timeout=3.0, raise_if_none=True, raise_if_any=True)