Open-source Python library for AI browser agents, plus Browser Use Cloud: stealth browsers and a hosted agent API.
Python ai-agentsai-toolsbrowser-agentbrowser-automationbrowser-usecdpcloud-browsercomputer-useheadless-browserllmmcpplaywrightpythonremote-browserstealth-browserweb-automationweb-scraping
Remove outdated tests for AboutBlankWatchdog functionality and comment out DownloadsWatchdog test due to issues with the old API.
Magnus Müller5f03c8787b97
diff --git a/tests/ci/test_browser_watchdog_aboutblank.py b/tests/ci/test_browser_watchdog_aboutblank.pydeleted file mode 100644index 6f69c9331..000000000--- a/tests/ci/test_browser_watchdog_aboutblank.py+++ /dev/null@@ -1,231 +0,0 @@-"""Test AboutBlankWatchdog functionality."""--import asyncio--import pytest--from browser_use.browser.events import (- AboutBlankDVDScreensaverShownEvent,- BrowserConnectedEvent,- BrowserStartEvent,- BrowserStopEvent,- NavigateToUrlEvent,- TabCreatedEvent,-)-from browser_use.browser.profile import BrowserProfile-from browser_use.browser.session import BrowserSession-from browser_use.browser.watchdogs.crash_watchdog import CrashWatchdog--[email protected](reason='Browser initialization timeout in test environment - timing issue')-async def test_aboutblank_watchdog_lifecycle():- """Test that AboutBlankWatchdog starts and stops with browser session."""- profile = BrowserProfile(headless=True)- session = BrowserSession(browser_profile=profile)-- try:- # Start browser- session.event_bus.dispatch(BrowserStartEvent())- await session.event_bus.expect(BrowserConnectedEvent, timeout=5.0)-- # Verify aboutblank watchdog was created- assert hasattr(session, '_aboutblank_watchdog'), 'AboutBlankWatchdog should be created'- assert session._aboutblank_watchdog is not None, 'AboutBlankWatchdog should not be None'-- finally:- await session.kill()- await session.event_bus.stop(clear=True, timeout=5)---async def test_aboutblank_watchdog_handles_tab_creation():- """Test that AboutBlankWatchdog responds to TabCreatedEvent."""- profile = BrowserProfile(headless=True)- session = BrowserSession(browser_profile=profile)-- try:- # Start browser- session.event_bus.dispatch(BrowserStartEvent())- await session.event_bus.expect(BrowserConnectedEvent, timeout=5.0)-- # Get aboutblank watchdog- watchdog = session._aboutblank_watchdog- assert watchdog is not None-- # Create a new tab- session.event_bus.dispatch(NavigateToUrlEvent(url='data:text/html,<h1>Test Tab</h1>', new_tab=True))- await session.event_bus.expect(TabCreatedEvent, timeout=3.0)-- # Give watchdog time to process the new tab- await asyncio.sleep(0.3)-- # The watchdog should have processed the TabCreatedEvent- # We can't easily verify internal state without accessing private methods-- finally:- await session.kill()- await session.event_bus.stop(clear=True, timeout=5)---async def test_aboutblank_watchdog_dvd_screensaver():- """Test that AboutBlankWatchdog can show DVD screensaver on about:blank tabs."""- profile = BrowserProfile(headless=True)- session = BrowserSession(browser_profile=profile)-- try:- # Start browser- session.event_bus.dispatch(BrowserStartEvent())- await session.event_bus.expect(BrowserConnectedEvent, timeout=5.0)-- # Get aboutblank watchdog- watchdog = session._aboutblank_watchdog- assert watchdog is not None-- # Wait for animation tab to be created- await asyncio.sleep(0.5)-- # Find new tab pages- tabs = await session.get_tabs()- new_tab_pages = [t for t in tabs if CrashWatchdog._is_new_tab_page(t.url)]-- # AboutBlankWatchdog should have detected the initial new tab page- assert len(new_tab_pages) >= 1, (- f'Expected at least one new tab page for DVD screensaver test, but found {len(new_tab_pages)}'- )-- if new_tab_pages:- # Try to show screensaver on first about:blank page- try:- await watchdog._show_dvd_screensaver_on_about_blank_tabs()- # If no exception is thrown, the method executed successfully- except Exception as e:- # Method might fail in test environment, that's okay- print(f'DVD screensaver test encountered expected issue: {e}')-- finally:- await session.kill()- await session.event_bus.stop(clear=True, timeout=5)---async def test_aboutblank_watchdog_animation_tab_management():- """Test that AboutBlankWatchdog manages animation tabs properly."""- profile = BrowserProfile(headless=True)- session = BrowserSession(browser_profile=profile)-- try:- # Start browser- session.event_bus.dispatch(BrowserStartEvent())- await session.event_bus.expect(BrowserConnectedEvent, timeout=5.0)-- # Get aboutblank watchdog- watchdog = session._aboutblank_watchdog- assert watchdog is not None-- # Wait for initial setup- await asyncio.sleep(0.5)-- # Check current state- tabs = await session.get_tabs()- initial_page_count = len(tabs)-- # Create multiple tabs to potentially trigger animation tab management- for i in range(3):- session.event_bus.dispatch(NavigateToUrlEvent(url=f'data:text/html,<h1>Tab {i}</h1>', new_tab=True))- await asyncio.sleep(0.2)-- # Give watchdog time to process and manage animation tabs- await asyncio.sleep(1.0)-- # Verify pages still exist (watchdog shouldn't break tab management)- final_tabs = await session.get_tabs()- assert len(final_tabs) >= initial_page_count, 'Should not lose tabs'-- finally:- await session.kill()- await session.event_bus.stop(clear=True, timeout=5)---async def test_aboutblank_watchdog_javascript_execution():- """Test that the DVD screensaver JavaScript executes without errors."""- profile = BrowserProfile(headless=True)- session = BrowserSession(browser_profile=profile)-- try:- # Start browser- session.event_bus.dispatch(BrowserStartEvent())- await session.event_bus.expect(BrowserConnectedEvent, timeout=5.0)-- # Test 1: Initial new tab should get animation- # The watchdog should detect the chrome://newtab/ page is a new tab and show animation- initial_tabs = await session.get_tabs()- assert len(initial_tabs) == 1, 'Should have one initial tab'- assert 'newtab' in initial_tabs[0].url or 'new-tab-page' in initial_tabs[0].url, 'Initial tab should be a new tab page'-- # Wait for AboutBlankWatchdog to show DVD screensaver on the initial new tab- dvd_event1 = await session.event_bus.expect(AboutBlankDVDScreensaverShownEvent, timeout=10.0)- assert dvd_event1.error is None, f'DVD screensaver failed on initial tab: {dvd_event1.error}'-- # Get the page and verify animation- # Get tab info instead of page- tabs1 = await session.get_tabs()- tab1 = next((tab for tab in tabs1 if tab.target_id == dvd_event1.target_id), None)- assert tab1 is not None, f'Could not find tab at index {dvd_event1.target_id}'-- # Verify the animation was created- # Note: We can't directly evaluate on the page without accessing internal APIs- # The test should verify through events instead- assert dvd_event1.target_id, 'DVD screensaver event should have valid tab index'-- # Test 2: Close the tab and verify watchdog creates new about:blank tab with animation- from browser_use.browser.events import CloseTabEvent-- event = session.event_bus.dispatch(CloseTabEvent(target_id=dvd_event1.target_id))- await event-- # Wait for new about:blank tab to be created and animation shown- dvd_event2 = await session.event_bus.expect(AboutBlankDVDScreensaverShownEvent, timeout=10.0)- assert dvd_event2.error is None, f'DVD screensaver failed on auto-created tab: {dvd_event2.error}'-- # Get the new page- # Get tab info instead of page- tabs2 = await session.get_tabs()- tab2 = next((tab for tab in tabs2 if tab.target_id == dvd_event2.target_id), None)- assert tab2 is not None, f'Could not find tab # {dvd_event2.target_id}'- assert CrashWatchdog._is_new_tab_page(tab2.url), f'Auto-created tab should be a new tab page, but got: {tab2.url}'-- # Verify animation on the new tab through events- # Note: We can't directly evaluate on the page without accessing internal APIs- assert dvd_event2.target_id, 'Second DVD screensaver event should have valid tab index'-- # Verify no JavaScript errors occurred (particularly arguments.callee)- console_errors = []-- async def capture_console(msg):- if msg.type == 'error':- console_errors.append(msg.text)-- # Note: We can't access page objects directly anymore- # Console errors would need to be monitored through CDP or events- await asyncio.sleep(0.5)-- finally:- # Allow any pending operations to complete- await asyncio.sleep(0.5)-- # Stop browser properly through the session- stop_event = session.event_bus.dispatch(BrowserStopEvent())- try:- await asyncio.wait_for(stop_event, timeout=5.0)- except TimeoutError:- print('BrowserStopEvent processing timed out')-- # Wait a bit more for playwright internal cleanup- await asyncio.sleep(1.0)-- # Stop event bus to prevent hanging- await session.event_bus.stop(clear=True, timeout=5)diff --git a/tests/ci/test_browser_watchdog_downloads.py b/tests/ci/test_browser_watchdog_downloads.pyindex 0baeed568..acc70601d 100644--- a/tests/ci/test_browser_watchdog_downloads.py+++ b/tests/ci/test_browser_watchdog_downloads.py@@ -140,50 +140,50 @@ def comprehensive_download_test_server():httpserver.stop()-async def test_downloads_watchdog_page_attachment():- """Test that DownloadsWatchdog attaches to pages properly."""-- # Create temp directory for downloads- with tempfile.TemporaryDirectory() as temp_dir:- downloads_path = Path(temp_dir)-- profile = BrowserProfile(headless=True, downloads_path=downloads_path)- session = BrowserSession(browser_profile=profile)-- try:- # Start browser- session.event_bus.dispatch(BrowserStartEvent())- await session.event_bus.expect(BrowserConnectedEvent, timeout=5.0)-- # Get downloads watchdog- downloads_watchdog = session._downloads_watchdog- assert downloads_watchdog is not None-- # Navigate to create a new page- event = session.event_bus.dispatch(NavigateToUrlEvent(url='data:text/html,<h1>Test Page</h1>'))- await event- await event.event_result(raise_if_any=True, raise_if_none=False)-- # Verify watchdog has pages with listeners- assert hasattr(downloads_watchdog, '_pages_with_listeners')-- # Give it a moment for page attachment- await asyncio.sleep(0.2)-- # The watchdog should have attached to at least one page- # Note: We can't easily verify the internal WeakSet without accessing private attrs-- finally:- # Clean shutdown- try:- session.event_bus.dispatch(BrowserStopEvent())- await session.event_bus.expect(BrowserStoppedEvent, timeout=3.0)- except Exception:- # If graceful shutdown fails, force cleanup- await session.kill()- # Always stop event bus to prevent hanging- await session.event_bus.stop(clear=True, timeout=5)+# @pytest.mark.asyncio+# async def test_downloads_watchdog_page_attachment():+# """Test that DownloadsWatchdog attaches to pages properly."""++# # Create temp directory for downloads+# with tempfile.TemporaryDirectory() as temp_dir:+# downloads_path = Path(temp_dir)++# profile = BrowserProfile(headless=True, downloads_path=downloads_path)+# session = BrowserSession(browser_profile=profile)++# try:+# # Start browser+# session.event_bus.dispatch(BrowserStartEvent())+# await session.event_bus.expect(BrowserConnectedEvent, timeout=5.0)++# # Get downloads watchdog+# downloads_watchdog = session._downloads_watchdog+# assert downloads_watchdog is not None++# # Navigate to create a new page+# event = session.event_bus.dispatch(NavigateToUrlEvent(url='data:text/html,<h1>Test Page</h1>'))+# await event+# await event.event_result(raise_if_any=True, raise_if_none=False)++# # Verify watchdog has pages with listeners+# assert hasattr(downloads_watchdog, '_pages_with_listeners')++# # Give it a moment for page attachment+# await asyncio.sleep(0.2)++# # The watchdog should have attached to at least one page+# # Note: We can't easily verify the internal WeakSet without accessing private attrs++# finally:+# # Clean shutdown+# try:+# session.event_bus.dispatch(BrowserStopEvent())+# await session.event_bus.expect(BrowserStoppedEvent, timeout=3.0)+# except Exception:+# # If graceful shutdown fails, force cleanup+# await session.kill()+# # Always stop event bus to prevent hanging+# await session.event_bus.stop(clear=True, timeout=5)@pytest.mark.asyncio