Skip to content

Open-source Python library for AI browser agents, plus Browser Use Cloud: stealth browsers and a hosted agent API.

dont use preload cache for anything after the first step

Nick Sweeting6c2e854ee563
diff --git a/browser_use/agent/service.py b/browser_use/agent/service.py
index df0f8e8b2..26643e869 100644
--- a/browser_use/agent/service.py
+++ b/browser_use/agent/service.py
@@ -702,7 +702,8 @@ class Agent(Generic[Context, AgentStructuredOutput]):
self.logger.debug(f'🌐 Step {self.state.n_steps}: Getting browser state...')
# Always take screenshots for all steps
# Use caching based on preload setting - if preload is False, don't use cached state
- use_cache = self.preload
+ is_first_step = self.state.n_steps in (0, 1)
+ use_cache = is_first_step and self.preload
self.logger.debug(f'πŸ“Έ Requesting browser state with include_screenshot=True, cached={use_cache}')
browser_state_summary = await self.browser_session.get_browser_state_summary(
cache_clickable_elements_hashes=True,
diff --git a/browser_use/browser/dom_watchdog.py b/browser_use/browser/dom_watchdog.py
index 4a4702dc5..e0977c725 100644
--- a/browser_use/browser/dom_watchdog.py
+++ b/browser_use/browser/dom_watchdog.py
@@ -174,6 +174,14 @@ class DOMWatchdog(BaseWatchdog):
tabs_info = await self.browser_session.get_tabs()
self.logger.debug(f'πŸ” DOMWatchdog.on_BrowserStateRequestEvent: Got {len(tabs_info)} tabs')
+ # Get viewport / scroll position info, remember changing scroll position should invalidate selector_map cache because it only includes visible elements
+ # cdp_session = await self.browser_session.get_or_create_cdp_session(focus=True)
+ # scroll_info = await cdp_session.cdp_client.send.Runtime.evaluate(
+ # params={'expression': 'JSON.stringify({y: document.body.scrollTop, x: document.body.scrollLeft, width: document.documentElement.clientWidth, height: document.documentElement.clientHeight})'},
+ # session_id=cdp_session.session_id,
+ # )
+ # self.logger.debug(f'πŸ” DOMWatchdog.on_BrowserStateRequestEvent: Got scroll info: {scroll_info["result"]}')
+
try:
# Fast path for empty pages
if not_a_meaningful_website:
@@ -388,23 +396,23 @@ class DOMWatchdog(BaseWatchdog):
try:
self.logger.debug('πŸ” DOMWatchdog._build_dom_tree: Removing existing highlights...')
await self.browser_session.remove_highlights()
- self.logger.debug('πŸ” DOMWatchdog._build_dom_tree: βœ… Highlights removed')
+ # self.logger.debug('πŸ” DOMWatchdog._build_dom_tree: βœ… Highlights removed')
except Exception as e:
self.logger.debug(f'πŸ” DOMWatchdog._build_dom_tree: Failed to remove existing highlights: {e}')
# Create or reuse DOM service
if self._dom_service is None:
- self.logger.debug('πŸ” DOMWatchdog._build_dom_tree: Creating DomService...')
+ # self.logger.debug('πŸ” DOMWatchdog._build_dom_tree: Creating DomService...')
self._dom_service = DomService(browser_session=self.browser_session, logger=self.logger)
- self.logger.debug('πŸ” DOMWatchdog._build_dom_tree: βœ… DomService created')
- else:
- self.logger.debug('πŸ” DOMWatchdog._build_dom_tree: Reusing existing DomService')
+ # self.logger.debug('πŸ” DOMWatchdog._build_dom_tree: βœ… DomService created')
+ # else:
+ # self.logger.debug('πŸ” DOMWatchdog._build_dom_tree: Reusing existing DomService')
# Get serialized DOM tree using the service
self.logger.debug('πŸ” DOMWatchdog._build_dom_tree: Calling DomService.get_serialized_dom_tree...')
start = time.time()
self.current_dom_state, self.enhanced_dom_tree, timing_info = await self._dom_service.get_serialized_dom_tree(
- previous_cached_state=previous_state
+ previous_cached_state=previous_state,
)
end = time.time()
self.logger.debug('πŸ” DOMWatchdog._build_dom_tree: βœ… DomService.get_serialized_dom_tree completed')