Skip to content

Open-source Python library for AI browser agents, plus Browser Use Cloud: stealth browsers and a hosted agent API.

fix(llm): ignore empty reasoning model patterns

ECD5A6cd3fffca3a1
diff --git a/browser_use/llm/azure/chat.py b/browser_use/llm/azure/chat.py
index 21b14aabc..ca6f510da 100644
--- a/browser_use/llm/azure/chat.py
+++ b/browser_use/llm/azure/chat.py
@@ -9,6 +9,7 @@ from openai.types.responses import Response
from openai.types.shared import ChatModel
from pydantic import BaseModel
+from browser_use.llm.base import is_reasoning_model
from browser_use.llm.exceptions import ModelProviderError, ModelRateLimitError
from browser_use.llm.messages import BaseMessage
from browser_use.llm.openai.like import ChatOpenAILike
@@ -179,7 +180,7 @@ class ChatAzureOpenAI(ChatOpenAILike):
model_params['service_tier'] = self.service_tier
# Handle reasoning models
- if self.reasoning_models and any(str(m).lower() in str(self.model).lower() for m in self.reasoning_models):
+ if is_reasoning_model(self.model, self.reasoning_models):
# For reasoning models, use reasoning parameter instead of reasoning_effort
model_params['reasoning'] = {'effort': self.reasoning_effort}
model_params.pop('temperature', None)
diff --git a/browser_use/llm/base.py b/browser_use/llm/base.py
index 7a591c62f..0cfd2a571 100644
--- a/browser_use/llm/base.py
+++ b/browser_use/llm/base.py
@@ -4,6 +4,7 @@ We have switched all of our code from langchain to openai.types.chat.chat_comple
For easier transition we have
"""
+from collections.abc import Iterable
from typing import Any, Protocol, TypeVar, overload, runtime_checkable
from pydantic import BaseModel
@@ -14,6 +15,20 @@ from browser_use.llm.views import ChatInvokeCompletion
T = TypeVar('T', bound=BaseModel)
+def is_reasoning_model(model: object, reasoning_models: Iterable[object] | None) -> bool:
+ """Return whether a model matches a non-empty reasoning-model pattern."""
+ if not reasoning_models:
+ return False
+
+ model_name = str(model).lower()
+ for pattern in reasoning_models:
+ pattern_name = str(pattern).lower()
+ if pattern_name.strip() and pattern_name in model_name:
+ return True
+
+ return False
+
+
@runtime_checkable
class BaseChatModel(Protocol):
_verified_api_keys: bool = False
diff --git a/browser_use/llm/openai/chat.py b/browser_use/llm/openai/chat.py
index 1074d3439..51226e5db 100644
--- a/browser_use/llm/openai/chat.py
+++ b/browser_use/llm/openai/chat.py
@@ -11,7 +11,7 @@ from openai.types.shared_params.reasoning_effort import ReasoningEffort
from openai.types.shared_params.response_format_json_schema import JSONSchema, ResponseFormatJSONSchema
from pydantic import BaseModel
-from browser_use.llm.base import BaseChatModel
+from browser_use.llm.base import BaseChatModel, is_reasoning_model
from browser_use.llm.exceptions import ModelOutputTruncatedError, ModelProviderError, ModelRateLimitError
from browser_use.llm.messages import BaseMessage
from browser_use.llm.openai.serializer import OpenAIMessageSerializer
@@ -186,7 +186,7 @@ class ChatOpenAI(BaseChatModel):
if self.service_tier is not None:
model_params['service_tier'] = self.service_tier
- if self.reasoning_models and any(str(m).lower() in str(self.model).lower() for m in self.reasoning_models):
+ if is_reasoning_model(self.model, self.reasoning_models):
model_params['reasoning_effort'] = self.reasoning_effort
model_params.pop('temperature', None)
model_params.pop('frequency_penalty', None)
diff --git a/browser_use/llm/vercel/chat.py b/browser_use/llm/vercel/chat.py
index 7a6e10f1e..c10842aed 100644
--- a/browser_use/llm/vercel/chat.py
+++ b/browser_use/llm/vercel/chat.py
@@ -13,7 +13,7 @@ from openai.types.shared_params.response_format_json_schema import (
)
from pydantic import BaseModel
-from browser_use.llm.base import BaseChatModel
+from browser_use.llm.base import BaseChatModel, is_reasoning_model
from browser_use.llm.exceptions import ModelProviderError, ModelRateLimitError
from browser_use.llm.messages import BaseMessage, ContentPartTextParam, SystemMessage
from browser_use.llm.schema import SchemaOptimizer
@@ -556,11 +556,9 @@ class ChatVercel(BaseChatModel):
else:
is_google_model = self.model.startswith('google/')
is_anthropic_model = self.model.startswith('anthropic/')
- is_reasoning_model = self.reasoning_models and any(
- str(pattern).lower() in str(self.model).lower() for pattern in self.reasoning_models
- )
+ is_reasoning = is_reasoning_model(self.model, self.reasoning_models)
- if is_google_model or is_anthropic_model or is_reasoning_model:
+ if is_google_model or is_anthropic_model or is_reasoning:
modified_messages = [m.model_copy(deep=True) for m in messages]
schema = SchemaOptimizer.create_gemini_optimized_schema(output_format)
diff --git a/tests/ci/models/test_llm_openai.py b/tests/ci/models/test_llm_openai.py
index 5fef442a1..d29e49645 100644
--- a/tests/ci/models/test_llm_openai.py
+++ b/tests/ci/models/test_llm_openai.py
@@ -1,9 +1,30 @@
"""Test OpenAI model button click."""
+from types import SimpleNamespace
+
+import pytest
+
+from browser_use.llm.base import is_reasoning_model
+from browser_use.llm.messages import UserMessage
from browser_use.llm.openai.chat import ChatOpenAI
from tests.ci.models.model_test_helper import run_model_button_click_test
+ ('model', 'reasoning_models', 'expected'),
+ [
+ ('gpt-4.1', [''], False),
+ ('gpt-4.1', [' ', ''], False),
+ ('o3-mini', ['', 'o3'], True),
+ ('o3-mini', [' o3'], False),
+ ('gpt-4.1', None, False),
+ ],
+)
+def test_reasoning_model_matching_ignores_empty_patterns(model, reasoning_models, expected):
+ """Empty patterns must not match every model name."""
+ assert is_reasoning_model(model, reasoning_models) is expected
+
+
async def test_openai_gpt_4_1_mini(httpserver):
"""Test OpenAI gpt-4.1-mini can click a button."""
await run_model_button_click_test(
@@ -13,3 +34,33 @@ async def test_openai_gpt_4_1_mini(httpserver):
extra_kwargs={},
httpserver=httpserver,
)
+
+
[email protected]('reasoning_models', [[], [''], [' ', '', '']])
+async def test_openai_empty_reasoning_model_patterns_preserve_sampling_parameters(monkeypatch, reasoning_models):
+ """Empty reasoning patterns must not classify a regular model as reasoning."""
+ captured: dict[str, object] = {}
+
+ class FakeCompletions:
+ async def create(self, **kwargs):
+ captured.update(kwargs)
+ return SimpleNamespace(
+ choices=[SimpleNamespace(message=SimpleNamespace(content='ok'), finish_reason='stop')],
+ usage=None,
+ )
+
+ fake_client = SimpleNamespace(chat=SimpleNamespace(completions=FakeCompletions()))
+ llm = ChatOpenAI(
+ model='gpt-4.1',
+ api_key='test-key',
+ temperature=0.7,
+ frequency_penalty=0.4,
+ reasoning_models=reasoning_models,
+ )
+ monkeypatch.setattr(llm, 'get_client', lambda: fake_client)
+
+ await llm.ainvoke([UserMessage(content='hello')])
+
+ assert captured['temperature'] == 0.7
+ assert captured['frequency_penalty'] == 0.4
+ assert 'reasoning_effort' not in captured