Skip to content

Open-source Python library for AI browser agents, plus Browser Use Cloud: stealth browsers and a hosted agent API.

More tests updated

Magnus Müller6ce7a491b4bf
diff --git a/tests/ci/test_browser_session_recent_events.py b/tests/ci/test_browser_session_recent_events.py
index 344dcbf32..60fcf85cf 100644
--- a/tests/ci/test_browser_session_recent_events.py
+++ b/tests/ci/test_browser_session_recent_events.py
@@ -66,9 +66,13 @@ class TestBrowserRecentEvents:
await browser_session.start()
# Navigate to the page with the slow iframe
- # Don't await to allow navigation to start in background
- event = browser_session.event_bus.dispatch(NavigateToUrlEvent(url=httpserver.url_for('/')))
- nav_task = asyncio.create_task(event)
+ # Start navigation in background
+ async def nav_task():
+ event = browser_session.event_bus.dispatch(NavigateToUrlEvent(url=httpserver.url_for('/')))
+ await event
+ return await event.event_result(raise_if_any=True, raise_if_none=False)
+
+ nav_task = asyncio.create_task(nav_task())
# Give navigation a moment to start loading resources
await asyncio.sleep(0.5)
@@ -451,17 +455,16 @@ class TestEventHistoryInfrastructure:
await screenshot_event.event_result(raise_if_any=True, raise_if_none=False)
await browser_session.get_tabs()
- # Test different limits
- summary_3 = browser_session._generate_recent_events_summary(max_events=3)
- summary_1 = browser_session._generate_recent_events_summary(max_events=1)
+ # Test recent events summary via BrowserStateSummary
+ state_with_events = await browser_session.get_browser_state_summary(include_recent_events=True)
+ assert state_with_events.recent_events is not None
- events_3 = json.loads(summary_3)
- events_1 = json.loads(summary_1)
+ # Parse the JSON events
+ events = json.loads(state_with_events.recent_events)
- # Should respect the limits
- assert len(events_3) <= 3, 'Should limit to 3 events'
- assert len(events_1) <= 1, 'Should limit to 1 event'
- assert len(events_1) <= len(events_3), 'Smaller limit should have fewer events'
+ # Should have some events
+ assert len(events) > 0, 'Should have some recent events'
+ assert isinstance(events, list), 'Events should be a list'
finally:
await browser_session.kill()
diff --git a/tests/ci/test_browser_session_start.py b/tests/ci/test_browser_session_start.py
index b139b2abe..8483bbf3f 100644
--- a/tests/ci/test_browser_session_start.py
+++ b/tests/ci/test_browser_session_start.py
@@ -17,6 +17,7 @@ from pathlib import Path
import pytest
+from browser_use.browser.events import NavigateToUrlEvent
from browser_use.browser.profile import (
BROWSERUSE_DEFAULT_CHANNEL,
BrowserChannel,
@@ -120,9 +121,9 @@ class TestBrowserSessionStart:
assert isinstance(tabs_after_close, list)
# Create a new tab explicitly
- new_page = await browser_session.create_new_tab()
- assert new_page is not None
- assert not new_page.is_closed()
+ event = browser_session.event_bus.dispatch(NavigateToUrlEvent(url='about:blank', new_tab=True))
+ await event
+ await event.event_result(raise_if_any=True, raise_if_none=False)
# Should have at least one tab now
final_tabs = await browser_session.get_tabs_info()
@@ -262,7 +263,7 @@ class TestBrowserSessionStart:
# Stop should not actually close the browser with keep_alive=True
await session.stop()
# Browser should still be connected
- assert session._cdp_client_root and session._cdp_client_root.pages[0]
+ assert session._cdp_client_root is not None
finally:
await session.kill()
@@ -418,20 +419,28 @@ class TestBrowserSessionReusePatterns:
await browser_session1.start()
await browser_session2.start()
- assert await browser_session1.is_connected()
- assert await browser_session2.is_connected()
+ assert browser_session1._cdp_client_root is not None
+ assert browser_session2._cdp_client_root is not None
assert browser_session1._cdp_client_root != browser_session2._cdp_client_root
- await browser_session1.create_new_tab('chrome://version')
- await browser_session2.create_new_tab('chrome://settings')
+ event1 = browser_session1.event_bus.dispatch(NavigateToUrlEvent(url='chrome://version', new_tab=True))
+ await event1
+ await event1.event_result(raise_if_any=True, raise_if_none=False)
+ event2 = browser_session2.event_bus.dispatch(NavigateToUrlEvent(url='chrome://settings', new_tab=True))
+ await event2
+ await event2.event_result(raise_if_any=True, raise_if_none=False)
await browser_session2.kill()
# ensure that the browser_session1 is still connected and unaffected by the kill of browser_session2
- assert await browser_session1.is_connected()
assert browser_session1._cdp_client_root is not None
- await browser_session1.create_new_tab('chrome://settings')
- await browser_session1._cdp_client_root.pages[0].evaluate('alert(1)')
+ assert browser_session1._cdp_client_root is not None
+ event = browser_session1.event_bus.dispatch(NavigateToUrlEvent(url='chrome://settings', new_tab=True))
+ await event
+ await event.event_result(raise_if_any=True, raise_if_none=False)
+ # Test that browser is still functional by getting tabs
+ tabs = await browser_session1.get_tabs()
+ assert len(tabs) > 0
await browser_session1.kill()
@@ -626,7 +635,7 @@ class TestBrowserSessionEventSystem:
print('Ensuring all parallel browser sessions are connected and usable...')
new_tab_tasks = []
for browser_session in browser_sessions:
- assert await browser_session.is_connected()
+ assert browser_session._cdp_client_root is not None
assert browser_session._cdp_client_root is not None
new_tab_tasks.append(browser_session.create_new_tab('chrome://version'))
await asyncio.gather(*new_tab_tasks)
@@ -646,7 +655,7 @@ class TestBrowserSessionEventSystem:
new_tab_tasks = []
screenshot_tasks = []
for browser_session in filter(bool, browser_sessions):
- assert await browser_session.is_connected()
+ assert browser_session._cdp_client_root is not None
assert browser_session._cdp_client_root is not None
new_tab_tasks.append(browser_session.create_new_tab('chrome://version'))
screenshot_tasks.append(browser_session.take_screenshot())
diff --git a/tests/ci/test_browser_session_tab_management.py b/tests/ci/test_browser_session_tab_management.py
index e006c5733..a89e6471c 100644
--- a/tests/ci/test_browser_session_tab_management.py
+++ b/tests/ci/test_browser_session_tab_management.py
@@ -69,8 +69,8 @@ async def browser_session(base_url):
await asyncio.sleep(1)
# Verify that page is properly set
- assert browser_session.page is not None
- assert base_url in browser_session.page.url
+ current_url = await browser_session.get_current_page_url()
+ assert base_url in current_url
# page might be None initially until user interaction occurs
# This is expected behavior with the new watchdog architecture
@@ -148,13 +148,17 @@ class TestTabManagement:
"""Test that page changes and page remains the same when a new tab is opened."""
initial_tab = await self._reset_tab_state(browser_session, base_url)
- await initial_tab.goto(f'{base_url}/page1')
- assert initial_tab.url == f'{base_url}/page1'
- initial_tab_count = len(browser_session.tabs)
+ event = browser_session.event_bus.dispatch(NavigateToUrlEvent(url=f'{base_url}/page1'))
+ await event
+ await event.event_result(raise_if_any=True, raise_if_none=False)
+ current_url = await browser_session.get_current_page_url()
+ assert current_url == f'{base_url}/page1'
+ tabs = await browser_session.get_tabs()
+ initial_tab_count = len(tabs)
# Debug: Check tab count
print(f'DEBUG: initial_tab_count = {initial_tab_count}')
- print(f'DEBUG: browser_session.tabs = {[p.url for p in browser_session.tabs]}')
+ print(f'DEBUG: browser_session.tabs = {[p.url for p in tabs]}')
# The test expects 1 tab, but if there's more we need to understand why
if initial_tab_count != 1:
@@ -165,29 +169,34 @@ class TestTabManagement:
assert initial_tab_count >= 1
# test opening a new tab
- new_tab = await browser_session.create_new_tab(f'{base_url}/page2')
- new_tab_count = len(browser_session._cdp_client_root.pages)
+ event = browser_session.event_bus.dispatch(NavigateToUrlEvent(url=f'{base_url}/page2', new_tab=True))
+ await event
+ await event.event_result(raise_if_any=True, raise_if_none=False)
+ new_tabs = await browser_session.get_tabs()
+ new_tab_count = len(new_tabs)
# Debug: Check tab count after new tab creation
print(f'DEBUG: new_tab_count = {new_tab_count}')
- print(f'DEBUG: browser_session.tabs count = {len(browser_session.tabs)}')
- print(f'DEBUG: browser_session.tabs = {[p.url for p in browser_session.tabs]}')
+ print(f'DEBUG: browser_session.tabs count = {len(new_tabs)}')
+ print(f'DEBUG: browser_session.tabs = {[p.url for p in new_tabs]}')
# After creating a new tab, we should have one more tab than before
expected_new_count = initial_tab_count + 1
- assert new_tab_count == len(browser_session.tabs) == expected_new_count
+ assert new_tab_count == expected_new_count
# Give time for watchdogs to process the new tab creation
await asyncio.sleep(1.0)
# test agent open new tab updates agent focus
- assert browser_session.page.url == new_tab.url == f'{base_url}/page2'
+ current_url = await browser_session.get_current_page_url()
+ assert current_url == f'{base_url}/page2'
# test agent navigation updates agent focus
event = browser_session.event_bus.dispatch(NavigateToUrlEvent(url=f'{base_url}/page3'))
await event
await event.event_result(raise_if_any=True, raise_if_none=False)
- assert browser_session.page.url == f'{base_url}/page3' # agent should now be on the new tab
+ current_url = await browser_session.get_current_page_url()
+ assert current_url == f'{base_url}/page3' # agent should now be on the new tab
async def test_switch_tab(self, browser_session, base_url):
"""Test that switch_tab updates agent tab reference."""
@@ -197,23 +206,27 @@ class TestTabManagement:
event = browser_session.event_bus.dispatch(NavigateToUrlEvent(url=f'{base_url}/page1'))
await event
await event.event_result(raise_if_any=True, raise_if_none=False)
- assert first_tab.url == f'{base_url}/page1'
+ current_url = await browser_session.get_current_page_url()
+ assert current_url == f'{base_url}/page1'
# open a new tab that the agent will switch to automatically
- second_tab = await browser_session.create_new_tab(f'{base_url}/page2')
- current_tab = await browser_session.get_current_page()
+ event = browser_session.event_bus.dispatch(NavigateToUrlEvent(url=f'{base_url}/page2', new_tab=True))
+ await event
+ await event.event_result(raise_if_any=True, raise_if_none=False)
# assert agent focus is on new tab
- assert current_tab.url == second_tab.url == f'{base_url}/page2' == browser_session.page.url
+ current_url = await browser_session.get_current_page_url()
+ assert current_url == f'{base_url}/page2'
# Find the correct tab index for the first tab (page1)
+ tabs = await browser_session.get_tabs()
first_tab_id = None
- for i, tab in enumerate(browser_session.tabs):
+ for i, tab in enumerate(tabs):
if f'{base_url}/page1' in tab.url:
- first_tab_id = tab.target_id[-4:]
+ first_tab_id = tab.target_id
break
- assert first_tab_id is not None, f'Could not find tab with page1 URL in {[p.url for p in browser_session.tabs]}'
+ assert first_tab_id is not None, f'Could not find tab with page1 URL in {[p.url for p in tabs]}'
# Switch agent back to the first tab using correct index
from browser_use.browser.events import SwitchTabEvent
@@ -223,7 +236,8 @@ class TestTabManagement:
# assert agent focus is on first tab
current_tab = await browser_session.get_current_page()
- assert f'{base_url}/page1' in current_tab.url == browser_session.page.url
+ current_url = await browser_session.get_current_page_url()
+ assert f'{base_url}/page1' in current_tab.url == current_url
# Find the correct tab index for the second tab (page2)
second_tab_id = None
@@ -240,7 +254,8 @@ class TestTabManagement:
# assert agent focus is back on second tab
current_tab = await browser_session.get_current_page()
- assert f'{base_url}/page2' in current_tab.url == browser_session.page.url
+ current_url = await browser_session.get_current_page_url()
+ assert f'{base_url}/page2' in current_tab.url == current_url
async def test_close_tab(self, browser_session, base_url):
"""Test that closing a tab updates references correctly."""
@@ -249,8 +264,9 @@ class TestTabManagement:
event = browser_session.event_bus.dispatch(NavigateToUrlEvent(url=f'{base_url}/page1'))
await event
await event.event_result(raise_if_any=True, raise_if_none=False)
- # After navigation, browser_session.page should be the correct reference
- assert browser_session.page.url == f'{base_url}/page1'
+ # After navigation, current page should be the correct reference
+ current_url = await browser_session.get_current_page_url()
+ assert current_url == f'{base_url}/page1'
# The initial_tab (which was about:blank) should now show the new URL too
assert initial_tab.url == f'{base_url}/page1'
@@ -266,7 +282,8 @@ class TestTabManagement:
await asyncio.sleep(0.5)
# Agent reference should be auto-updated to the first available tab
- assert browser_session.page.url == f'{base_url}/page1'
+ current_url = await browser_session.get_current_page_url()
+ assert current_url == f'{base_url}/page1'
assert initial_tab.url == f'{base_url}/page1'
assert not browser_session.page.is_closed()
@@ -275,7 +292,8 @@ class TestTabManagement:
await asyncio.sleep(0.5)
# close_tab should have called get_current_page, which creates a new about:blank tab if none are left
- assert browser_session.page.url == 'about:blank'
+ current_url = await browser_session.get_current_page_url()
+ assert current_url == 'about:blank'
async def test_cdp_client_root_state_after_error(self, browser_session):
"""Test browser context state remains consistent after errors"""
@@ -304,7 +322,7 @@ class TestTabManagement:
assert current_url is not None
assert browser_session._cdp_client_root is not None
assert browser_session._cdp_client_root != original_context
- assert (await browser_session.is_connected()) is True
+ assert browser_session._cdp_client_root is not None
class TestEventDrivenTabOperations:
diff --git a/tests/ci/test_browser_session_via_cdp.py b/tests/ci/test_browser_session_via_cdp.py
index f133a99d1..b9f383a12 100644
--- a/tests/ci/test_browser_session_via_cdp.py
+++ b/tests/ci/test_browser_session_via_cdp.py
@@ -2,7 +2,6 @@ import pytest
from browser_use.browser import BrowserSession
from browser_use.browser.profile import BrowserProfile
-from browser_use.browser.types import async_playwright
async def test_connection_via_cdp():
@@ -19,15 +18,6 @@ async def test_connection_via_cdp():
# Assert on the exception value outside the context manager
assert 'ECONNREFUSED' in str(e.value)
- playwright = await async_playwright().start()
- browser = await playwright.chromium.launch(args=['--remote-debugging-port=9898'])
-
- async with await browser_session.start():
- await browser_session.create_new_tab()
-
- assert (await browser_session.get_current_page()).url == 'about:blank'
-
- await browser.close()
-
- await browser_session.kill()
- await playwright.stop()
+ # This test requires Playwright to create a browser instance with CDP enabled
+ # For now, skip this test as we've moved away from Playwright dependencies
+ pytest.skip('Test requires Playwright integration which has been removed')
diff --git a/tests/ci/test_browser_watchdog_crash.py b/tests/ci/test_browser_watchdog_crash.py
index a0cd541d7..4140fe148 100644
--- a/tests/ci/test_browser_watchdog_crash.py
+++ b/tests/ci/test_browser_watchdog_crash.py
@@ -100,9 +100,9 @@ async def test_crash_watchdog_browser_disconnect():
# Mock browser disconnection by overriding is_connected
# This simulates what would happen if the browser process crashed
- if session._browser:
- original_is_connected = session._browser.is_connected
- session._browser.is_connected = lambda: False
+ if session._cdp_client_root:
+ original_is_connected = session._cdp_client_root.is_connected
+ session._cdp_client_root.is_connected = lambda: False
try:
# Wait for watchdog to detect disconnection
@@ -117,7 +117,7 @@ async def test_crash_watchdog_browser_disconnect():
assert 'disconnected unexpectedly' in disconnect_error.message
finally:
# Restore original method
- session._browser.is_connected = original_is_connected
+ session._cdp_client_root.is_connected = original_is_connected
finally:
# Force stop even if browser is marked as disconnected
diff --git a/tests/ci/test_browser_watchdog_downloads.py b/tests/ci/test_browser_watchdog_downloads.py
index c423f7971..e6b84157a 100644
--- a/tests/ci/test_browser_watchdog_downloads.py
+++ b/tests/ci/test_browser_watchdog_downloads.py
@@ -311,119 +311,6 @@ async def comprehensive_download_test_server(httpserver):
return httpserver
-async def test_downloads_watchdog_detection_timing(comprehensive_download_test_server, tmp_path):
- """Test that download detection adds appropriate delay to clicks when downloads_dir is set."""
-
- # Test 1: With downloads_dir set (default behavior)
- browser_with_downloads = BrowserSession(
- browser_profile=BrowserProfile(
- headless=True,
- downloads_path=str(tmp_path / 'downloads'),
- user_data_dir=None,
- )
- )
-
- await browser_with_downloads.start()
- page = await browser_with_downloads.get_current_page()
- await page.goto(comprehensive_download_test_server.url_for('/'))
-
- # Get the actual DOM state to find the button
- state = await browser_with_downloads.get_browser_state_summary()
-
- # Find the button element
- button_node = None
- for elem in state.dom_state.selector_map.values():
- if elem.tag_name == 'button' and elem.attributes.get('id') == 'test-button':
- button_node = elem
- break
-
- if button_node is None:
- # Try alternative approach - find by text content or use Playwright directly
- await page.wait_for_selector('#test-button', timeout=5000)
- # Use a simpler approach with playwright locator for timing test
- start_time = time.time()
- await page.click('#test-button')
- duration_with_downloads = time.time() - start_time
-
- # Verify click worked
- result_text = await page.locator('#result').text_content()
- assert result_text == 'Clicked!'
- else:
- # Time the click using browser session method
- start_time = time.time()
- event = browser_with_downloads.event_bus.dispatch(ClickElementEvent(element_node=button_node))
- await event
- result = await event.event_result()
- result = result.get('download_path') if result else None
- duration_with_downloads = time.time() - start_time
-
- # Verify click worked
- result_text = await page.locator('#result').text_content()
- assert result_text == 'Clicked!'
- assert result is None # No download happened
-
- await browser_with_downloads.close()
- await browser_with_downloads.event_bus.stop(clear=True, timeout=5)
-
- # Test 2: With downloads_dir set to None (disables download detection)
- browser_no_downloads = BrowserSession(
- browser_profile=BrowserProfile(
- headless=True,
- downloads_path=None,
- user_data_dir=None,
- )
- )
-
- await browser_no_downloads.start()
- page = await browser_no_downloads.get_current_page()
- await page.goto(comprehensive_download_test_server.url_for('/'))
-
- # Clear previous result
- await page.evaluate('document.getElementById("result").innerText = ""')
-
- # Get the DOM state again for the new browser session
- state = await browser_no_downloads.get_browser_state_summary()
-
- # Find the button element again
- button_node = None
- for elem in state.dom_state.selector_map.values():
- if elem.tag_name == 'button' and elem.attributes.get('id') == 'test-button':
- button_node = elem
- break
-
- if button_node is None:
- # Use Playwright directly as fallback
- await page.wait_for_selector('#test-button', timeout=5000)
- start_time = time.time()
- await page.click('#test-button')
- duration_no_downloads = time.time() - start_time
- else:
- # Time the click using browser session method
- start_time = time.time()
- event = browser_no_downloads.event_bus.dispatch(ClickElementEvent(element_node=button_node))
- await event
- result = await event.event_result()
- result = result.get('download_path') if result else None
- duration_no_downloads = time.time() - start_time
-
- # Verify click worked
- result_text = await page.locator('#result').text_content()
- assert result_text == 'Clicked!'
-
- await browser_no_downloads.close()
- await browser_no_downloads.event_bus.stop(clear=True, timeout=5)
-
- # Check timing differences
- print(f'Click with downloads_dir: {duration_with_downloads:.2f}s')
- print(f'Click without downloads_dir: {duration_no_downloads:.2f}s')
- print(f'Difference: {duration_with_downloads - duration_no_downloads:.2f}s')
-
- # Both should be fast now since we're clicking a button (not a download link)
- assert duration_with_downloads < 8, f'Expected <8s with downloads_dir, got {duration_with_downloads:.2f}s'
- assert duration_no_downloads < 3, f'Expected <3s without downloads_dir, got {duration_no_downloads:.2f}s'
-
-
@pytest.mark.asyncio
async def test_downloads_watchdog_actual_download_detection(comprehensive_download_test_server, tmp_path):
"""Test that DownloadsWatchdog detects actual downloads correctly."""
@@ -515,8 +402,7 @@ async def test_downloads_watchdog_actual_download_detection(comprehensive_downlo
print(f'✅ Download successful: {latest_download} ({file_size} bytes) with correct content: {file_content!r}')
- await browser_session.close()
- await browser_session.event_bus.stop(clear=True, timeout=5)
+ await browser_session.kill()
@pytest.mark.asyncio
diff --git a/tests/ci/test_browser_watchdog_downloads_upload_full_circle.py b/tests/ci/test_browser_watchdog_downloads_upload_full_circle.py
index 0e5ca3b07..029b9a965 100644
--- a/tests/ci/test_browser_watchdog_downloads_upload_full_circle.py
+++ b/tests/ci/test_browser_watchdog_downloads_upload_full_circle.py
@@ -172,6 +172,9 @@ class TestDownloadUploadFullCircle:
# Get browser state to find download link
event = browser_session.event_bus.dispatch(BrowserStateRequestEvent())
state_result = await event.event_result()
+ assert state_result is not None
+ assert state_result.dom_state is not None
+ assert state_result.dom_state.selector_map is not None
# Find download link
download_link_index = None
@@ -241,7 +244,11 @@ class TestDownloadUploadFullCircle:
# Get browser state to find file input
event = browser_session.event_bus.dispatch(BrowserStateRequestEvent())
- state_result = await event.event_result()
+ await event
+ state_result = await event.event_result(raise_if_any=True, raise_if_none=False)
+ assert state_result is not None
+ assert state_result.dom_state is not None
+ assert state_result.dom_state.selector_map is not None
# Debug: print page URL and title
print('\n🔍 Getting DOM state:')