Open-source Python library for AI browser agents, plus Browser Use Cloud: stealth browsers and a hosted agent API.
Python ai-agentsai-toolsbrowser-agentbrowser-automationbrowser-usecdpcloud-browsercomputer-useheadless-browserllmmcpplaywrightpythonremote-browserstealth-browserweb-automationweb-scraping
Update PopupsWatchdog to automatically accept JavaScript dialogs instead of dismissing them. Adjust logging messages accordingly and remove unused post-dialog recovery method.
Magnus Müller770955e0b063
diff --git a/browser_use/browser/watchdogs/popups_watchdog.py b/browser_use/browser/watchdogs/popups_watchdog.pyindex 819dcf8fa..32dc6419d 100644--- a/browser_use/browser/watchdogs/popups_watchdog.py+++ b/browser_use/browser/watchdogs/popups_watchdog.py@@ -11,7 +11,7 @@ from browser_use.browser.watchdog_base import BaseWatchdogclass PopupsWatchdog(BaseWatchdog):- """Handles JavaScript dialogs (alert, confirm, prompt) by automatically dismissing them immediately."""+ """Handles JavaScript dialogs (alert, confirm, prompt) by automatically accepting them immediately."""# Events this watchdog listens to and emitsLISTENS_TO: ClassVar[list[type[BaseEvent]]] = [TabCreatedEvent]@@ -52,9 +52,9 @@ class PopupsWatchdog(BaseWatchdog):dialog_type = event_data.get('type', 'alert')message = event_data.get('message', '')- self.logger.info(f"🔔 JavaScript {dialog_type} dialog: '{message[:100]}' - attempting to dismiss...")+ self.logger.info(f"🔔 JavaScript {dialog_type} dialog: '{message[:100]}' - attempting to accept...")- self.logger.debug('Trying all approaches to dismiss dialog...')+ self.logger.debug('Trying all approaches to accept dialog...')# Approach 1: Use the session that detected the dialogif self.browser_session._cdp_client_root and session_id:@@ -67,11 +67,11 @@ class PopupsWatchdog(BaseWatchdog):),timeout=0.25,)- except (asyncio.TimeoutError, Exception) as e:+ except (TimeoutError, Exception) as e:pass# Approach 2: Try with current agent focus session- if self.browser_session.agent_focus:+ if self.browser_session._cdp_client_root and self.browser_session.agent_focus:try:self.logger.debug(f'🔄 Approach 2: Using agent focus session {self.browser_session.agent_focus.session_id}'@@ -83,11 +83,9 @@ class PopupsWatchdog(BaseWatchdog):),timeout=0.25,)- except (asyncio.TimeoutError, Exception) as e:+ except (TimeoutError, Exception) as e:pass- # await self._post_dialog_recovery()-except Exception as e:self.logger.error(f'❌ Critical error in dialog handler: {type(e).__name__}: {e}')@@ -111,33 +109,4 @@ class PopupsWatchdog(BaseWatchdog):self.logger.debug(f'Set up JavaScript dialog handling for tab {target_id}')except Exception as e:- self.logger.warning(f'Failed to set up dialog handling for tab {target_id}: {e}')-- async def _post_dialog_recovery(self) -> None:- """Perform post-dialog recovery to ensure browser session continues normally."""- try:- self.logger.debug('🔄 Starting post-dialog recovery...')-- # Small delay to let browser process dialog dismissal- await asyncio.sleep(0.1)-- # Ensure agent focus is still valid- if self.browser_session.agent_focus:- try:- # Try to reactivate the current target to ensure it's responsive- await self.browser_session._cdp_client_root.send.Target.activateTarget(- params={'targetId': self.browser_session.agent_focus.target_id}- )- self.logger.debug('✅ Reactivated agent focus target after dialog dismissal')- except Exception as reactivate_error:- self.logger.warning(f'Failed to reactivate target after dialog: {reactivate_error}')-- # Clear any cached browser state that might be stale- if hasattr(self.browser_session, '_cached_browser_state'):- self.browser_session._cached_browser_state = None- self.logger.debug('🧹 Cleared cached browser state')-- self.logger.info('✅ Post-dialog recovery completed')-- except Exception as recovery_error:- self.logger.error(f'❌ Post-dialog recovery failed: {recovery_error}')+ self.logger.warning(f'Failed to set up popup handling for tab {target_id}: {e}')