Skip to content

Open-source Python library for AI browser agents, plus Browser Use Cloud: stealth browsers and a hosted agent API.

fix: accept shutting-down race in test_close_orphaned_daemon

ShawnPana7db93b7ac7db
diff --git a/tests/ci/test_cli_lifecycle.py b/tests/ci/test_cli_lifecycle.py
index 0c555bcc9..fa216b215 100644
--- a/tests/ci/test_cli_lifecycle.py
+++ b/tests/ci/test_cli_lifecycle.py
@@ -282,9 +282,15 @@ def test_close_orphaned_daemon(home_dir):
result = _run_cli('close', home_dir=home_dir)
assert result.returncode == 0, f'close failed: stdout={result.stdout!r} stderr={result.stderr!r}'
- # Daemon may have exited between socket deletion and CLI probe (race),
- # so accept either "Browser closed" (killed orphan) or "No active browser session" (already dead)
- assert 'Browser closed' in result.stdout or 'No active browser session' in result.stdout
+ # Race between socket deletion and CLI probe means several outcomes are valid:
+ # - "Browser closed" (killed orphan successfully)
+ # - "No active browser session" (daemon already exited)
+ # - "daemon may still be shutting down" on stderr (SIGTERM sent but PID hasn't died yet)
+ assert (
+ 'Browser closed' in result.stdout
+ or 'No active browser session' in result.stdout
+ or 'shutting down' in result.stderr
+ )
# Clean up — daemon may still be shutting down asynchronously
_kill_daemon(pid)