Skip to content

Open-source Python library for AI browser agents, plus Browser Use Cloud: stealth browsers and a hosted agent API.

fix(orcarouter): address review feedback on ChatOrcaRouter

XiaoHuo888-hue82a673b3fa3e
diff --git a/browser_use/llm/orcarouter/chat.py b/browser_use/llm/orcarouter/chat.py
index c3d91c9d6..66523aba7 100644
--- a/browser_use/llm/orcarouter/chat.py
+++ b/browser_use/llm/orcarouter/chat.py
@@ -65,8 +65,6 @@ class ChatOrcaRouter(BaseChatModel):
'default_headers': self.default_headers,
'default_query': self.default_query,
'_strict_response_validation': self._strict_response_validation,
- 'top_p': self.top_p,
- 'seed': self.seed,
}
# Create client_params dict with non-None values
@@ -147,9 +145,24 @@ class ChatOrcaRouter(BaseChatModel):
**(self.extra_body or {}),
)
+ choice = response.choices[0] if response.choices else None
+ if choice is None:
+ base_url = str(self.base_url) if self.base_url is not None else None
+ hint = f' (base_url={base_url})' if base_url is not None else ''
+ raise ModelProviderError(
+ message=(
+ 'Invalid OrcaRouter chat completion response: missing or empty `choices`.'
+ ' If you are using a proxy via `base_url`, ensure it implements the OpenAI'
+ ' `/v1/chat/completions` schema and returns `choices` as a non-empty list.'
+ f'{hint}'
+ ),
+ status_code=502,
+ model=self.name,
+ )
+
usage = self._get_usage(response)
return ChatInvokeCompletion(
- completion=response.choices[0].message.content or '',
+ completion=choice.message.content or '',
usage=usage,
)
@@ -177,7 +190,22 @@ class ChatOrcaRouter(BaseChatModel):
**(self.extra_body or {}),
)
- if response.choices[0].message.content is None:
+ choice = response.choices[0] if response.choices else None
+ if choice is None:
+ base_url = str(self.base_url) if self.base_url is not None else None
+ hint = f' (base_url={base_url})' if base_url is not None else ''
+ raise ModelProviderError(
+ message=(
+ 'Invalid OrcaRouter chat completion response: missing or empty `choices`.'
+ ' If you are using a proxy via `base_url`, ensure it implements the OpenAI'
+ ' `/v1/chat/completions` schema and returns `choices` as a non-empty list.'
+ f'{hint}'
+ ),
+ status_code=502,
+ model=self.name,
+ )
+
+ if choice.message.content is None:
raise ModelProviderError(
message='Failed to parse structured output from model response',
status_code=500,
@@ -185,13 +213,17 @@ class ChatOrcaRouter(BaseChatModel):
)
usage = self._get_usage(response)
- parsed = output_format.model_validate_json(response.choices[0].message.content)
+ parsed = output_format.model_validate_json(choice.message.content)
return ChatInvokeCompletion(
completion=parsed,
usage=usage,
)
+ except ModelProviderError:
+ # Preserve status_code and message from validation errors
+ raise
+
except RateLimitError as e:
raise ModelRateLimitError(message=e.message, model=self.name) from e