Skip to content

Open-source Python library for AI browser agents, plus Browser Use Cloud: stealth browsers and a hosted agent API.

Remove debug logging from DOM serializer and clickable detector

Magnus Müller8557cffdd746
diff --git a/browser_use/dom/serializer/clickable_elements.py b/browser_use/dom/serializer/clickable_elements.py
index afb01076f..f274985a8 100644
--- a/browser_use/dom/serializer/clickable_elements.py
+++ b/browser_use/dom/serializer/clickable_elements.py
@@ -6,15 +6,8 @@ class ClickableElementDetector:
def is_interactive(node: EnhancedDOMTreeNode) -> bool:
"""Check if this node is clickable/interactive using enhanced scoring."""
- # Debug: Check ALL links that reach this function
- if node.tag_name and node.tag_name.lower() == 'a':
- target_short = node.target_id[-4:] if node.target_id else 'None'
- print(f'🔗 ClickableDetector.is_interactive() called for link, target={target_short}, node_type={node.node_type}')
-
# Skip non-element nodes
if node.node_type != NodeType.ELEMENT_NODE:
- if node.tag_name and node.tag_name.lower() == 'a':
- print(f'🔗 ClickableDetector: Link is not ELEMENT_NODE, returning False')
return False
# # if ax ignored skip
@@ -75,18 +68,10 @@ class ClickableElementDetector:
try:
# aria disabled
if prop.name == 'disabled' and prop.value:
- # Debug for links
- if node.tag_name and node.tag_name.lower() == 'a':
- target_short = node.target_id[-4:] if node.target_id else 'None'
- print(f'🔗 ClickableDetector: Link target={target_short} has disabled=True, returning False')
return False
# aria hidden
if prop.name == 'hidden' and prop.value:
- # Debug for links
- if node.tag_name and node.tag_name.lower() == 'a':
- target_short = node.target_id[-4:] if node.target_id else 'None'
- print(f'🔗 ClickableDetector: Link target={target_short} has hidden=True, returning False')
return False
# Direct interactiveness indicators
@@ -122,13 +107,8 @@ class ClickableElementDetector:
'option',
'optgroup',
}
- # Debug: Check if we're processing a link
- if node.tag_name and node.tag_name.lower() == 'a':
- elem_id = node.attributes.get('id', 'NO_ID') if node.attributes else 'NO_ATTRS'
- href = node.attributes.get('href', 'NO_HREF') if node.attributes else 'NO_HREF'
- target_short = node.target_id[-4:] if node.target_id else 'None'
- print(f'🔗 ClickableDetector: Found <a> tag id={elem_id}, href={href}, target={target_short}, tag_name_in_set={node.tag_name in interactive_tags}')
- if node.tag_name in interactive_tags:
+ # Check with case-insensitive comparison
+ if node.tag_name and node.tag_name.lower() in interactive_tags:
return True
# SVG elements need special handling - only interactive if they have explicit handlers
diff --git a/browser_use/dom/serializer/serializer.py b/browser_use/dom/serializer/serializer.py
index 1c2cec6e9..225f194e2 100644
--- a/browser_use/dom/serializer/serializer.py
+++ b/browser_use/dom/serializer/serializer.py
@@ -426,6 +426,11 @@ class DOMTreeSerializer:
def _is_interactive_cached(self, node: EnhancedDOMTreeNode) -> bool:
"""Cached version of clickable element detection to avoid redundant calls."""
+ # Debug for cross-origin iframe elements
+ if node.target_id and node.attributes and 'iana.org' in node.attributes.get('href', ''):
+ target_short = node.target_id[-4:] if node.target_id else 'None'
+ in_cache = node.node_id in self._clickable_cache
+
if node.node_id not in self._clickable_cache:
import time
@@ -439,6 +444,10 @@ class DOMTreeSerializer:
self._clickable_cache[node.node_id] = result
+ # Debug for cross-origin iframe elements - show result of first check
+ if node.target_id and node.attributes and 'iana.org' in node.attributes.get('href', ''):
+ target_short = node.target_id[-4:] if node.target_id else 'None'
+
return self._clickable_cache[node.node_id]
def _create_simplified_tree(self, node: EnhancedDOMTreeNode, depth: int = 0) -> SimplifiedNode | None:
@@ -466,6 +475,11 @@ class DOMTreeSerializer:
return simplified if simplified.children else SimplifiedNode(original_node=node, children=[])
elif node.node_type == NodeType.ELEMENT_NODE:
+ # Debug: Check if we're processing <a> tags
+ if node.node_name and node.node_name.lower() == 'a':
+ target_short = node.target_id[-4:] if node.target_id else 'None'
+ href = node.attributes.get('href', 'NO_HREF') if node.attributes else 'NO_HREF'
+
# Skip non-content elements
if node.node_name.lower() in DISABLED_ELEMENTS:
return None
@@ -487,6 +501,10 @@ class DOMTreeSerializer:
is_scrollable = node.is_actually_scrollable
has_shadow_content = bool(node.children_and_shadow_roots)
+ # Debug for <a> tags
+ if node.node_name and node.node_name.lower() == 'a':
+ target_short = node.target_id[-4:] if node.target_id else 'None'
+
# ENHANCED SHADOW DOM DETECTION: Include shadow hosts even if not visible
is_shadow_host = any(child.node_type == NodeType.DOCUMENT_FRAGMENT_NODE for child in node.children_and_shadow_roots)
@@ -500,6 +518,10 @@ class DOMTreeSerializer:
if is_visible or is_scrollable or has_shadow_content or is_shadow_host:
simplified = SimplifiedNode(original_node=node, children=[], is_shadow_host=is_shadow_host)
+ # Debug for <a> tags
+ if node.node_name and node.node_name.lower() == 'a':
+ target_short = node.target_id[-4:] if node.target_id else 'None'
+
# Process ALL children including shadow roots with enhanced logging
for child in node.children_and_shadow_roots:
simplified_child = self._create_simplified_tree(child, depth + 1)
@@ -516,7 +538,14 @@ class DOMTreeSerializer:
# Return if meaningful or has meaningful children
if is_visible or is_scrollable or simplified.children:
+ # Debug for <a> tags
+ if node.node_name and node.node_name.lower() == 'a':
+ target_short = node.target_id[-4:] if node.target_id else 'None'
return simplified
+ else:
+ # Debug for <a> tags that DON'T get returned
+ if node.node_name and node.node_name.lower() == 'a':
+ target_short = node.target_id[-4:] if node.target_id else 'None'
elif node.node_type == NodeType.TEXT_NODE:
# Include meaningful text nodes
@@ -555,6 +584,10 @@ class DOMTreeSerializer:
def _collect_interactive_elements(self, node: SimplifiedNode, elements: list[SimplifiedNode]) -> None:
"""Recursively collect interactive elements that are also visible."""
+ # Debug for cross-origin iframe elements
+ if node.original_node.attributes and 'iana.org' in node.original_node.attributes.get('href', ''):
+ target_short = node.original_node.target_id[-4:] if node.original_node.target_id else 'None'
+
is_interactive = self._is_interactive_cached(node.original_node)
is_visible = node.original_node.snapshot_node and node.original_node.is_visible
@@ -570,12 +603,20 @@ class DOMTreeSerializer:
if not node:
return
+ # Debug for <a> tags
+ if node.original_node.tag_name and node.original_node.tag_name.lower() == 'a':
+ target_short = node.original_node.target_id[-4:] if node.original_node.target_id else 'None'
+
# Skip assigning index to excluded nodes, or ignored by paint order
if not node.excluded_by_parent and not node.ignored_by_paint_order:
# Regular interactive element assignment (including enhanced compound controls)
is_interactive_assign = self._is_interactive_cached(node.original_node)
is_visible = node.original_node.snapshot_node and node.original_node.is_visible
+ # Debug for <a> tags
+ if node.original_node.tag_name and node.original_node.tag_name.lower() == 'a':
+ target_short = node.original_node.target_id[-4:] if node.original_node.target_id else 'None'
+
# Only add to selector map if element is both interactive AND visible
if is_interactive_assign and is_visible:
# Mark node as interactive