Skip to content

Open-source Python library for AI browser agents, plus Browser Use Cloud: stealth browsers and a hosted agent API.

make agent focus on new tabs when they open as a suprise after clicking

Nick Sweeting8684fa0d00c4
diff --git a/browser_use/browser/crash_watchdog.py b/browser_use/browser/crash_watchdog.py
index b63510aed..2118354d0 100644
--- a/browser_use/browser/crash_watchdog.py
+++ b/browser_use/browser/crash_watchdog.py
@@ -300,15 +300,23 @@ class CrashWatchdog(BaseWatchdog):
self.logger.debug(f'[CrashWatchdog] Checking browser health for target {self.browser_session.agent_focus}')
cdp_session = await self.browser_session.get_or_create_cdp_session()
except Exception as e:
- self.logger.debug(f'[CrashWatchdog] Checking browser health for target {self.browser_session.agent_focus} error: {type(e).__name__}: {e}')
- self.agent_focus = cdp_session = await self.browser_session.get_or_create_cdp_session(target_id=self.agent_focus.target_id, new_socket=True, focus=True)
+ self.logger.debug(
+ f'[CrashWatchdog] Checking browser health for target {self.browser_session.agent_focus} error: {type(e).__name__}: {e}'
+ )
+ self.agent_focus = cdp_session = await self.browser_session.get_or_create_cdp_session(
+ target_id=self.agent_focus.target_id, new_socket=True, focus=True
+ )
for target in (await self.browser_session.cdp_client.send.Target.getTargets()).get('targetInfos', []):
if target.get('type') == 'page':
cdp_session = await self.browser_session.get_or_create_cdp_session(target_id=target.get('targetId'))
if self._is_new_tab_page(target.get('url')) and target.get('url') != 'about:blank':
- self.logger.debug(f'[CrashWatchdog] Redirecting chrome://new-tab-page/ to about:blank {target.get("url")}')
- await cdp_session.cdp_client.send.Page.navigate(params={'url': 'about:blank'}, session_id=cdp_session.session_id)
+ self.logger.debug(
+ f'[CrashWatchdog] Redirecting chrome://new-tab-page/ to about:blank {target.get("url")}'
+ )
+ await cdp_session.cdp_client.send.Page.navigate(
+ params={'url': 'about:blank'}, session_id=cdp_session.session_id
+ )
# Quick ping to check if session is alive
self.logger.debug(f'[CrashWatchdog] Attempting to run simple JS test expression in session {cdp_session} 1+1')
@@ -318,7 +326,9 @@ class CrashWatchdog(BaseWatchdog):
)
self.logger.debug(f'[CrashWatchdog] Browser health check passed for target {self.browser_session.agent_focus}')
except Exception as e:
- self.logger.error(f'[CrashWatchdog] ❌ Crashed session detected for target {self.browser_session.agent_focus} error: {type(e).__name__}: {e}')
+ self.logger.error(
+ f'[CrashWatchdog] ❌ Crashed session detected for target {self.browser_session.agent_focus} error: {type(e).__name__}: {e}'
+ )
# Remove crashed session from pool
if self.browser_session.agent_focus and (target_id := self.browser_session.agent_focus.target_id):
if session := self.browser_session._cdp_session_pool.pop(target_id, None):
diff --git a/browser_use/browser/default_action_watchdog.py b/browser_use/browser/default_action_watchdog.py
index 5ee463821..f5db21654 100644
--- a/browser_use/browser/default_action_watchdog.py
+++ b/browser_use/browser/default_action_watchdog.py
@@ -86,14 +86,17 @@ class DefaultActionWatchdog(BaseWatchdog):
msg += f' - {new_tab_msg}'
self.logger.info(f'🔗 {new_tab_msg}')
- # Optional:Switch to the newly created tab
- # Not recommended usually in order to match normal behavior with Cmd/Ctrl+Click
- # If agent wanted to focus on the new page they would've clicked without new_tab
- # from browser_use.browser.events import SwitchTabEvent
-
- # last_tab_index = len(after_target_ids) - 1
- # switch_event = self.event_bus.dispatch(SwitchTabEvent(tab_index=last_tab_index))
- # await switch_event
+ if not event.new_tab:
+ # if new_tab=False it means agent was not expecting a new tab to be opened
+ # so we need to switch to the new tab to make the agent aware of the surprise new tab that was opened.
+ # slightly counter-intuitive, when new_tab=True we dont actually want to switch to it,
+ # the agent is instructed that new_tab=True is equivalent to ctrl+click which opens in the background,
+ # so in multi_act it usually already sends [click_element_by_index(123, new_tab=True), switch_tab(-1)] anyway
+ from browser_use.browser.events import SwitchTabEvent
+
+ last_tab_index = len(after_target_ids) - 1
+ switch_event = self.event_bus.dispatch(SwitchTabEvent(tab_index=last_tab_index))
+ await switch_event
# Successfully clicked, return None
return None
diff --git a/browser_use/browser/dom_watchdog.py b/browser_use/browser/dom_watchdog.py
index e0977c725..31e535c4d 100644
--- a/browser_use/browser/dom_watchdog.py
+++ b/browser_use/browser/dom_watchdog.py
@@ -406,7 +406,7 @@ class DOMWatchdog(BaseWatchdog):
self._dom_service = DomService(browser_session=self.browser_session, logger=self.logger)
# self.logger.debug('🔍 DOMWatchdog._build_dom_tree: ✅ DomService created')
# else:
- # self.logger.debug('🔍 DOMWatchdog._build_dom_tree: Reusing existing DomService')
+ # self.logger.debug('🔍 DOMWatchdog._build_dom_tree: Reusing existing DomService')
# Get serialized DOM tree using the service
self.logger.debug('🔍 DOMWatchdog._build_dom_tree: Calling DomService.get_serialized_dom_tree...')