Open-source Python library for AI browser agents, plus Browser Use Cloud: stealth browsers and a hosted agent API.
Python ai-agentsai-toolsbrowser-agentbrowser-automationbrowser-usecdpcloud-browsercomputer-useheadless-browserllmmcpplaywrightpythonremote-browserstealth-browserweb-automationweb-scraping
Fix screenshot
Magnus Müller8b4d74a3691b
diff --git a/browser_use/browser/dom_watchdog.py b/browser_use/browser/dom_watchdog.pyindex 38eed3d34..6dd776c22 100644--- a/browser_use/browser/dom_watchdog.py+++ b/browser_use/browser/dom_watchdog.py@@ -261,18 +261,26 @@ class DOMWatchdog(BaseWatchdog):handler_names = [getattr(h, '__name__', str(h)) for h in handlers]self.logger.debug(f'📸 ScreenshotEvent handlers registered: {len(handlers)} - {handler_names}')- screenshot_event = self.event_bus.dispatch(ScreenshotEvent(full_page=False, event_timeout=15.0))+ screenshot_event = self.event_bus.dispatch(ScreenshotEvent(full_page=False, event_timeout=6.0))self.logger.debug('📸 Dispatched ScreenshotEvent, waiting for event to complete...')- # Get the screenshot base64 string directly from event_result()- screenshot_b64 = await screenshot_event.event_result(raise_if_any=True, raise_if_none=True)- if screenshot_b64:- self.logger.debug(f'📸 Got screenshot: {len(screenshot_b64)} characters')- else:- screenshot_b64 = None- self.logger.warning('📸 Screenshot handler returned None')+ # Wait for the event itself to complete (this waits for all handlers)+ await screenshot_event++ # Now get the results after the event has completed+ screenshot_result = await screenshot_event.event_results_flat_dict()+ self.logger.debug(f'📸 Got screenshot result: {screenshot_result.keys() if screenshot_result else None}')++ if screenshot_result:+ screenshot_b64 = screenshot_result.get('screenshot')+ if screenshot_b64:+ self.logger.debug(f'📸 Screenshot captured in DOM watchdog, length: {len(screenshot_b64)}')+ else:+ self.logger.warning('📸 Screenshot result returned but screenshot was None')+except TimeoutError:- self.logger.warning('📸 Screenshot timed out after 15 seconds - no handler registered or slow page?')+ self.logger.warning('📸 Screenshot timed out after 6 seconds - no handler registered or slow page?')+except Exception as e:self.logger.warning(f'📸 Screenshot failed: {type(e).__name__}: {e}')else:diff --git a/browser_use/browser/events.py b/browser_use/browser/events.pyindex e20f39718..307be13fa 100644--- a/browser_use/browser/events.py+++ b/browser_use/browser/events.py@@ -141,8 +141,8 @@ class CloseTabEvent(BaseEvent[None]):event_timeout: float | None = 10.0 # seconds-class ScreenshotEvent(BaseEvent[str]):- """Request to take a screenshot. Returns screenshot as base64 string."""+class ScreenshotEvent(BaseEvent):+ """Request to take a screenshot."""full_page: bool = Falseclip: dict[str, float] | None = None # {x, y, width, height}diff --git a/browser_use/browser/screenshot_watchdog.py b/browser_use/browser/screenshot_watchdog.pyindex d2598fe09..7c0431e69 100644--- a/browser_use/browser/screenshot_watchdog.py+++ b/browser_use/browser/screenshot_watchdog.py@@ -21,36 +21,20 @@ class ScreenshotWatchdog(BaseWatchdog):# Events this watchdog emitsEMITS: ClassVar[list[type[BaseEvent[Any]]]] = []- async def on_ScreenshotEvent(self, event: ScreenshotEvent) -> str:+ async def on_ScreenshotEvent(self, event: ScreenshotEvent) -> dict[str, str | None]:"""Handle screenshot request using CDP.Args:event: ScreenshotEvent with optional full_page and clip parametersReturns:- Screenshot as base64-encoded string-- Raises:- Exception: If screenshot capture fails+ Dict with 'screenshot' key containing base64-encoded screenshot or None"""self.logger.debug('[ScreenshotWatchdog] Handler START - on_ScreenshotEvent called')try:# Get CDP client and session for current targetcdp_session = await self.browser_session.get_or_create_cdp_session()- # Activate the target to ensure it's focused- self.logger.debug(f'[ScreenshotWatchdog] Activating target: {cdp_session.target_id}')- try:- # Use Target.activateTarget to bring the tab to front- await self.browser_session.cdp_client.send.Target.activateTarget(params={'targetId': cdp_session.target_id})- except Exception as e:- self.logger.debug(f'[ScreenshotWatchdog] Could not activate target: {e}')-- # Small delay to ensure the tab switch is complete- import asyncio-- await asyncio.sleep(0.1)-# Prepare screenshot parametersparams = CaptureScreenshotParameters(format='png', captureBeyondViewport=False)@@ -58,7 +42,7 @@ class ScreenshotWatchdog(BaseWatchdog):self.logger.debug(f'[ScreenshotWatchdog] Taking screenshot with params: {params}')result = await cdp_session.cdp_client.send.Page.captureScreenshot(params=params, session_id=cdp_session.session_id)- # Return base64-encoded screenshot data as string+ # Return base64-encoded screenshot dataif result and 'data' in result:self.logger.debug('[ScreenshotWatchdog] Screenshot captured successfully')@@ -69,17 +53,16 @@ class ScreenshotWatchdog(BaseWatchdog):except Exception as e:self.logger.debug(f'[ScreenshotWatchdog] Failed to remove highlights: {e}')- # Return the base64 string directly (no need to decode and re-encode)- return result['data']+ return {'screenshot': result['data']}else:self.logger.warning('[ScreenshotWatchdog] Screenshot result missing data')- raise Exception('Screenshot capture failed: no data returned')+ return {'screenshot': None}except Exception as e:self.logger.error(f'[ScreenshotWatchdog] Screenshot failed: {e}')# Try to remove highlights even on failuretry:await self.browser_session.remove_highlights()- except:+ except Exception:pass- raise+ return {'screenshot': None}