Skip to content

Open-source Python library for AI browser agents, plus Browser Use Cloud: stealth browsers and a hosted agent API.

Fix patterns use in allowed_domains

Pierre Lalet973b58590521
diff --git a/browser_use/browser/watchdogs/security_watchdog.py b/browser_use/browser/watchdogs/security_watchdog.py
index 8e5096867..68941783f 100644
--- a/browser_use/browser/watchdogs/security_watchdog.py
+++ b/browser_use/browser/watchdogs/security_watchdog.py
@@ -156,11 +156,14 @@ class SecurityWatchdog(BaseWatchdog):
return True
else:
# Use fnmatch for other glob patterns
- if fnmatch.fnmatch(host, pattern):
+ if fnmatch.fnmatch(
+ full_url_pattern if '://' in pattern else host,
+ pattern,
+ ):
return True
else:
# Exact match
- if pattern.startswith(('http://', 'https://', 'chrome://', 'brave://', 'file://')):
+ if '://' in pattern:
# Full URL pattern
if url.startswith(pattern):
return True
diff --git a/tests/ci/test_browser_watchdog_security2.py b/tests/ci/test_browser_watchdog_security2.py
index 6cd0598ae..3bc85fd07 100644
--- a/tests/ci/test_browser_watchdog_security2.py
+++ b/tests/ci/test_browser_watchdog_security2.py
@@ -51,7 +51,14 @@ class TestUrlAllowlistSecurity:
# Test more complex glob patterns
browser_profile = BrowserProfile(
- allowed_domains=['*.google.com', 'https://wiki.org', 'https://good.com', 'chrome://version', 'brave://*'],
+ allowed_domains=[
+ '*.google.com',
+ 'https://wiki.org',
+ 'https://good.com',
+ 'https://*.test.com',
+ 'chrome://version',
+ 'brave://*',
+ ],
headless=True,
user_data_dir=None,
)
@@ -90,6 +97,10 @@ class TestUrlAllowlistSecurity:
assert watchdog._is_url_allowed('https://sub.example.com%[email protected]') is False
assert watchdog._is_url_allowed('https://[email protected]') is False
+ # Test pattern matching
+ assert watchdog._is_url_allowed('https://www.test.com') is True
+ assert watchdog._is_url_allowed('https://www.testx.com') is False
+
def test_glob_pattern_edge_cases(self):
"""Test edge cases for glob pattern matching to ensure proper behavior."""
from bubus import EventBus