Skip to content

Open-source Python library for AI browser agents, plus Browser Use Cloud: stealth browsers and a hosted agent API.

fix(registry): replace sensitive placeholders in tuples

郑耀翔9bfb1d3258ff
diff --git a/browser_use/tools/registry/service.py b/browser_use/tools/registry/service.py
index f45068b07..1f4e7838d 100644
--- a/browser_use/tools/registry/service.py
+++ b/browser_use/tools/registry/service.py
@@ -464,7 +464,7 @@ class Registry(Generic[Context]):
# Filter out empty values
applicable_secrets = {k: v for k, v in applicable_secrets.items() if v}
- def recursively_replace_secrets(value: str | dict | list) -> str | dict | list:
+ def recursively_replace_secrets(value: str | dict | list | tuple) -> str | dict | list | tuple:
if isinstance(value, str):
# 1. Handle tagged secrets: <secret>label</secret>
matches = secret_pattern.findall(value)
@@ -499,6 +499,8 @@ class Registry(Generic[Context]):
return {k: recursively_replace_secrets(v) for k, v in value.items()}
elif isinstance(value, list):
return [recursively_replace_secrets(v) for v in value]
+ elif isinstance(value, tuple):
+ return tuple(recursively_replace_secrets(v) for v in value)
return value
params_dump = params.model_dump()
diff --git a/tests/ci/security/test_sensitive_data.py b/tests/ci/security/test_sensitive_data.py
index 3976e31da..6160653d7 100644
--- a/tests/ci/security/test_sensitive_data.py
+++ b/tests/ci/security/test_sensitive_data.py
@@ -18,6 +18,18 @@ class SensitiveParams(BaseModel):
text: str = Field(description='Text with sensitive data placeholders')
+class TupleSensitiveParams(BaseModel):
+ """Test parameter model for tuple-based sensitive data placeholders."""
+
+ items: tuple[str, ...] = Field(description='Tuple with sensitive data placeholders')
+
+
+class NestedTupleSensitiveParams(BaseModel):
+ """Test parameter model for nested tuple-based sensitive data placeholders."""
+
+ payload: tuple[dict[str, tuple[str, list[str]]], ...] = Field(description='Nested tuple with sensitive data placeholders')
+
+
@pytest.fixture
def registry():
return Registry()
@@ -72,6 +84,29 @@ def test_replace_sensitive_data_with_missing_keys(registry, caplog):
assert '<secret>password</secret>' in result.text # Empty value's tag remains
+def test_replace_sensitive_data_inside_tuple(registry):
+ """Test that _replace_sensitive_data replaces placeholders inside tuple fields."""
+ params = TupleSensitiveParams(items=('<secret>api_key</secret>', 'username', 'unchanged'))
+ sensitive_data = {'api_key': 'sk-replaced', 'username': 'admin_user'}
+
+ result = registry._replace_sensitive_data(params, sensitive_data)
+
+ assert result.items == ('sk-replaced', 'admin_user', 'unchanged')
+ assert isinstance(result.items, tuple)
+
+
+def test_replace_sensitive_data_inside_nested_tuple(registry):
+ """Test that _replace_sensitive_data replaces placeholders inside nested tuples."""
+ params = NestedTupleSensitiveParams(payload=({'credentials': ('<secret>token</secret>', ['<secret>username</secret>'])},))
+ sensitive_data = {'token': 'token-replaced', 'username': 'admin_user'}
+
+ result = registry._replace_sensitive_data(params, sensitive_data)
+
+ assert result.payload == ({'credentials': ('token-replaced', ['admin_user'])},)
+ assert isinstance(result.payload, tuple)
+ assert isinstance(result.payload[0]['credentials'], tuple)
+
+
def test_simple_domain_specific_sensitive_data(registry, caplog):
"""Test the basic functionality of domain-specific sensitive data replacement"""
# Create a simple Pydantic model with sensitive data placeholders