Open-source Python library for AI browser agents, plus Browser Use Cloud: stealth browsers and a hosted agent API.
Python ai-agentsai-toolsbrowser-agentbrowser-automationbrowser-usecdpcloud-browsercomputer-useheadless-browserllmmcpplaywrightpythonremote-browserstealth-browserweb-automationweb-scraping
refactor(dom): simplify cross-origin iframe size filter
MagMueller9c8d12f7a70a
diff --git a/browser_use/dom/service.py b/browser_use/dom/service.pyindex e860e99b9..16e04cf63 100644--- a/browser_use/dom/service.py+++ b/browser_use/dom/service.py@@ -1,7 +1,6 @@import asyncioimport loggingimport time-from dataclasses import dataclass, fieldfrom typing import TYPE_CHECKING, Anyfrom cdp_use.cdp.accessibility.commands import GetFullAXTreeReturns@@ -35,42 +34,12 @@ if TYPE_CHECKING:_MAX_JS_CLICK_LISTENER_ELEMENTS = 100_DESCRIBE_NODE_BATCH_SIZE = 20_JS_CLICK_LISTENER_OVERFLOW = '__browser_use_too_many_click_listeners__'-_PREVIOUS_MIN_CROSS_ORIGIN_IFRAME_AREA = 50 * 50-_MIN_CROSS_ORIGIN_IFRAME_AREA = 10 * 10_MIN_CROSS_ORIGIN_IFRAME_EDGE = 10-_MAX_COMPACT_CROSS_ORIGIN_IFRAMES = 10def _is_cross_origin_iframe_size_eligible(width: float, height: float) -> bool:- """Keep pixel-sized beacons out while allowing compact embedded controls."""- return (- width >= _MIN_CROSS_ORIGIN_IFRAME_EDGE- and height >= _MIN_CROSS_ORIGIN_IFRAME_EDGE- and width * height >= _MIN_CROSS_ORIGIN_IFRAME_AREA- )---@dataclass-class _CrossOriginIframeTraversalContext:- """Bound recursive OOPIF traversal across the complete stitched DOM capture."""-- max_targets: int- max_compact_targets: int- visited_target_ids: set[TargetID] = field(default_factory=set)- traversed_target_count: int = 0- traversed_compact_target_count: int = 0-- def try_visit(self, target_id: TargetID, *, is_compact: bool) -> bool:- """Reserve one unique child target without exceeding the configured budget."""- if target_id in self.visited_target_ids or self.traversed_target_count >= self.max_targets:- return False- if is_compact and self.traversed_compact_target_count >= self.max_compact_targets:- return False- self.visited_target_ids.add(target_id)- self.traversed_target_count += 1- if is_compact:- self.traversed_compact_target_count += 1- return True+ """Include cross-origin frames that are at least 10px in each dimension."""+ return width >= _MIN_CROSS_ORIGIN_IFRAME_EDGE and height >= _MIN_CROSS_ORIGIN_IFRAME_EDGEclass DomService:@@ -738,7 +707,7 @@ class DomService:initial_html_frames: list[EnhancedDOMTreeNode] | None = None,initial_total_frame_offset: DOMRect | None = None,iframe_depth: int = 0,- cross_origin_traversal: _CrossOriginIframeTraversalContext | None = None,+ visited_cross_origin_targets: set[TargetID] | None = None,) -> tuple[EnhancedDOMTreeNode, dict[str, float]]:"""Get the DOM tree for a specific target.@@ -748,17 +717,13 @@ class DomService:initial_html_frames: List of HTML frame nodes encountered so farinitial_total_frame_offset: Accumulated coordinate offsetiframe_depth: Current depth of iframe nesting to prevent infinite recursion- cross_origin_traversal: Shared recursive OOPIF target budget and cycle guard+ visited_cross_origin_targets: Target IDs already included in this DOM captureReturns:Tuple of (enhanced_dom_tree_node, timing_info)"""- if cross_origin_traversal is None:- cross_origin_traversal = _CrossOriginIframeTraversalContext(- max_targets=self.max_iframes,- max_compact_targets=min(self.max_iframes, _MAX_COMPACT_CROSS_ORIGIN_IFRAMES),- visited_target_ids={target_id},- )+ if visited_cross_origin_targets is None:+ visited_cross_origin_targets = {target_id}timing_info: dict[str, float] = {}timing_start_total = time.time()@@ -1004,11 +969,8 @@ class DomService:f'Skipping iframe at depth {iframe_depth} to prevent infinite recursion (max depth: {self.max_iframe_depth})')else:- # Check if the iframe is visible and large enough to contain an interactive control.- # Use area rather than requiring both edges to be >= 50px: hosted payment fields- # are commonly wide but only ~40px tall.+ # Ignore only frames smaller than 10px in either dimension.should_process_iframe = False- is_compact_cross_origin_iframe = False# First check if the iframe element itself is visibleif dom_tree_node.is_visible:@@ -1020,13 +982,11 @@ class DomService:if _is_cross_origin_iframe_size_eligible(width, height):should_process_iframe = True- is_compact_cross_origin_iframe = width * height < _PREVIOUS_MIN_CROSS_ORIGIN_IFRAME_AREAself.logger.debug(f'Processing cross-origin iframe: visible=True, width={width}, height={height}')else:self.logger.debug(f'Skipping small cross-origin iframe: width={width}, height={height} '- f'(needs >= {_MIN_CROSS_ORIGIN_IFRAME_AREA}px² area and '- f'>= {_MIN_CROSS_ORIGIN_IFRAME_EDGE}px per edge)'+ f'(needs >= {_MIN_CROSS_ORIGIN_IFRAME_EDGE}px per edge)')else:self.logger.debug('Skipping cross-origin iframe: no bounds available')@@ -1076,33 +1036,31 @@ class DomService:# if target actually exists in one of the frames, just recursively build the dom tree for itif iframe_document_target:- if not cross_origin_traversal.try_visit(- iframe_document_target['targetId'],- is_compact=is_compact_cross_origin_iframe,- ):+ child_target_id = iframe_document_target['targetId']+ traversed_child_count = len(visited_cross_origin_targets) - 1+ if child_target_id in visited_cross_origin_targets or traversed_child_count >= self.max_iframes:self.logger.debug(- f'Skipping already visited or over-budget cross-origin iframe target '- f'{iframe_document_target["targetId"]} '- f'(max targets: {cross_origin_traversal.max_targets}, '- f'max compact targets: {cross_origin_traversal.max_compact_targets})'+ f'Skipping duplicate or over-limit cross-origin iframe target {child_target_id}')- else:- self.logger.debug(- f'Getting content document for iframe {node.get("frameId", None)} at depth {iframe_depth + 1}'+ return dom_tree_node++ visited_cross_origin_targets.add(child_target_id)+ self.logger.debug(+ f'Getting content document for iframe {node.get("frameId", None)} at depth {iframe_depth + 1}'+ )+ try:+ content_document, _ = await self.get_dom_tree(+ target_id=child_target_id,+ all_frames=all_frames,+ # Current config: if the cross origin iframe is AT ALL visible, include everything inside it+ initial_total_frame_offset=total_frame_offset,+ iframe_depth=iframe_depth + 1,+ visited_cross_origin_targets=visited_cross_origin_targets,)- try:- content_document, _ = await self.get_dom_tree(- target_id=iframe_document_target['targetId'],- all_frames=all_frames,- # Current config: if the cross origin iframe is AT ALL visible, include everything inside it- initial_total_frame_offset=total_frame_offset,- iframe_depth=iframe_depth + 1,- cross_origin_traversal=cross_origin_traversal,- )- dom_tree_node.content_document = content_document- dom_tree_node.content_document.parent_node = dom_tree_node- except Exception as e:- self.logger.debug(f'Failed to get DOM tree for cross-origin iframe {frame_id}: {e}')+ dom_tree_node.content_document = content_document+ dom_tree_node.content_document.parent_node = dom_tree_node+ except Exception as e:+ self.logger.debug(f'Failed to get DOM tree for cross-origin iframe {frame_id}: {e}')return dom_tree_nodediff --git a/tests/ci/test_dom_visibility.py b/tests/ci/test_dom_visibility.pyindex b26c0dd95..7b8ff6e10 100644--- a/tests/ci/test_dom_visibility.py+++ b/tests/ci/test_dom_visibility.py@@ -6,11 +6,7 @@ node must not be transformed by its own bounds when it appears in its ownframe chain (as built by _construct_enhanced_node)."""-from browser_use.dom.service import (- DomService,- _CrossOriginIframeTraversalContext,- _is_cross_origin_iframe_size_eligible,-)+from browser_use.dom.service import DomService, _is_cross_origin_iframe_size_eligiblefrom browser_use.dom.views import DOMRect, EnhancedDOMTreeNode, EnhancedSnapshotNode, NodeType@@ -121,6 +117,9 @@ class TestCrossOriginIframeSizeEligibility:assert _is_cross_origin_iframe_size_eligible(width=1, height=1) is Falseassert _is_cross_origin_iframe_size_eligible(width=1, height=2500) is False+ def test_accepts_exact_minimum_size(self):+ assert _is_cross_origin_iframe_size_eligible(width=10, height=10) is True+def test_accepts_native_checkbox_sized_frame(self):"""Chromium renders an unstyled native checkbox at roughly 13x13 CSS pixels."""assert _is_cross_origin_iframe_size_eligible(width=13, height=13) is True@@ -128,30 +127,3 @@ class TestCrossOriginIframeSizeEligibility:def test_rejects_frames_below_the_minimum_edge(self):assert _is_cross_origin_iframe_size_eligible(width=9, height=100) is Falseassert _is_cross_origin_iframe_size_eligible(width=100, height=9) is False---class TestCrossOriginIframeTraversalContext:- def test_caps_unique_recursive_targets_globally(self):- context = _CrossOriginIframeTraversalContext(max_targets=2, max_compact_targets=2, visited_target_ids={'root'})-- assert context.try_visit('child-1', is_compact=False) is True- assert context.try_visit('child-2', is_compact=False) is True- assert context.try_visit('child-3', is_compact=False) is False- assert context.traversed_target_count == 2-- def test_rejects_duplicate_targets_without_spending_budget(self):- context = _CrossOriginIframeTraversalContext(max_targets=2, max_compact_targets=2, visited_target_ids={'root'})-- assert context.try_visit('child-1', is_compact=False) is True- assert context.try_visit('child-1', is_compact=False) is False- assert context.try_visit('child-2', is_compact=False) is True- assert context.traversed_target_count == 2-- def test_compact_target_budget_does_not_block_larger_frames(self):- context = _CrossOriginIframeTraversalContext(max_targets=4, max_compact_targets=1, visited_target_ids={'root'})-- assert context.try_visit('compact-1', is_compact=True) is True- assert context.try_visit('compact-2', is_compact=True) is False- assert context.try_visit('large-1', is_compact=False) is True- assert context.traversed_compact_target_count == 1- assert context.traversed_target_count == 2