Skip to content

Open-source Python library for AI browser agents, plus Browser Use Cloud: stealth browsers and a hosted agent API.

Fix scroll action

mertunsalla396927435f2
diff --git a/browser_use/browser/watchdogs/default_action_watchdog.py b/browser_use/browser/watchdogs/default_action_watchdog.py
index 2ff574b92..5fbe25b9a 100644
--- a/browser_use/browser/watchdogs/default_action_watchdog.py
+++ b/browser_use/browser/watchdogs/default_action_watchdog.py
@@ -1625,7 +1625,7 @@ class DefaultActionWatchdog(BaseWatchdog):
async def _scroll_with_cdp_gesture(self, pixels: int) -> bool:
"""
- Scroll using CDP Input.dispatchMouseEvent to simulate mouse wheel.
+ Scroll using CDP Input.synthesizeScrollGesture to simulate realistic scroll gesture.
Args:
pixels: Number of pixels to scroll (positive = down, negative = up)
@@ -1639,35 +1639,41 @@ class DefaultActionWatchdog(BaseWatchdog):
cdp_client = cdp_session.cdp_client
session_id = cdp_session.session_id
- # Get viewport dimensions
- layout_metrics = await cdp_client.send.Page.getLayoutMetrics(session_id=session_id)
- viewport_width = layout_metrics['layoutViewport']['clientWidth']
- viewport_height = layout_metrics['layoutViewport']['clientHeight']
+ # Get viewport dimensions from cached value if available
+ if self.browser_session._original_viewport_size:
+ viewport_width, viewport_height = self.browser_session._original_viewport_size
+ else:
+ # Fallback: query layout metrics
+ layout_metrics = await cdp_client.send.Page.getLayoutMetrics(session_id=session_id)
+ viewport_width = layout_metrics['layoutViewport']['clientWidth']
+ viewport_height = layout_metrics['layoutViewport']['clientHeight']
# Calculate center of viewport
center_x = viewport_width / 2
center_y = viewport_height / 2
- # For mouse wheel, positive deltaY scrolls down, negative scrolls up
- delta_y = pixels
+ # For scroll gesture, positive yDistance scrolls up, negative scrolls down
+ # (opposite of mouseWheel deltaY convention)
+ y_distance = -pixels
- # Dispatch mouse wheel event
- await cdp_client.send.Input.dispatchMouseEvent(
+ # Synthesize scroll gesture with faster speed
+ await cdp_client.send.Input.synthesizeScrollGesture(
params={
- 'type': 'mouseWheel',
'x': center_x,
'y': center_y,
- 'deltaX': 0,
- 'deltaY': delta_y,
+ 'xDistance': 0,
+ 'yDistance': y_distance,
+ 'speed': 1200, # pixels per second (faster than default 800)
},
session_id=session_id,
)
- self.logger.debug(f'πŸ“„ Scrolled via CDP mouse wheel: {pixels}px')
+ self.logger.debug(f'πŸ“„ Scrolled via CDP gesture: {pixels}px')
return True
except Exception as e:
- self.logger.warning(f'❌ Scrolling via CDP failed: {type(e).__name__}: {e}')
+ # Not critical - JavaScript fallback will handle scrolling
+ self.logger.debug(f'CDP gesture scroll failed ({type(e).__name__}: {e}), falling back to JS')
return False
async def _scroll_element_container(self, element_node, pixels: int) -> bool:
diff --git a/browser_use/browser/watchdogs/dom_watchdog.py b/browser_use/browser/watchdogs/dom_watchdog.py
index 701c7f947..6cadcac8a 100644
--- a/browser_use/browser/watchdogs/dom_watchdog.py
+++ b/browser_use/browser/watchdogs/dom_watchdog.py
@@ -491,7 +491,7 @@ class DOMWatchdog(BaseWatchdog):
self.browser_session._cached_browser_state_summary = browser_state
# Cache viewport size for coordinate conversion (if llm_screenshot_size is enabled)
- if self.browser_session.llm_screenshot_size and page_info:
+ if page_info:
self.browser_session._original_viewport_size = (page_info.viewport_width, page_info.viewport_height)
self.logger.debug('πŸ” DOMWatchdog.on_BrowserStateRequestEvent: βœ… COMPLETED - Returning browser state')