Skip to content

Open-source Python library for AI browser agents, plus Browser Use Cloud: stealth browsers and a hosted agent API.

fix tab close handling

Nick Sweetingb5892850ce43
diff --git a/browser_use/browser/profile.py b/browser_use/browser/profile.py
index d6c5cd914..06b135497 100644
--- a/browser_use/browser/profile.py
+++ b/browser_use/browser/profile.py
@@ -569,6 +569,9 @@ class ProxySettings(BaseModel):
username: str | None = Field(default=None, description='Proxy auth username')
password: str | None = Field(default=None, description='Proxy auth password')
+ def __getitem__(self, key: str) -> str | None:
+ return getattr(self, key)
+
class BrowserProfile(BrowserConnectArgs, BrowserLaunchPersistentContextArgs, BrowserLaunchArgs, BrowserNewContextArgs):
"""
@@ -609,9 +612,9 @@ class BrowserProfile(BrowserConnectArgs, BrowserLaunchPersistentContextArgs, Bro
# --- Proxy settings ---
# New consolidated proxy config (typed)
- proxy: ProxySettings | dict | None = Field(
+ proxy: ProxySettings | None = Field(
default=None,
- description='Proxy settings. Use ProxySettings(server, bypass, username, password). Dicts are accepted and coerced.',
+ description='Proxy settings. Use browser_use.browser.profile.ProxySettings(server, bypass, username, password)',
)
enable_default_extensions: bool = Field(
default=True,
@@ -737,16 +740,6 @@ class BrowserProfile(BrowserConnectArgs, BrowserLaunchPersistentContextArgs, Bro
)
return self
- @field_validator('proxy', mode='before')
- @classmethod
- def _coerce_proxy(cls, v: Any) -> Any:
- """Accept dicts for proxy and coerce to ProxySettings."""
- if v is None or isinstance(v, ProxySettings):
- return v
- if isinstance(v, dict):
- return ProxySettings(**v)
- return v
-
@model_validator(mode='after')
def validate_proxy_settings(self) -> Self:
"""Ensure proxy configuration is consistent."""
diff --git a/browser_use/browser/session.py b/browser_use/browser/session.py
index f9c6ced60..2b7b82125 100644
--- a/browser_use/browser/session.py
+++ b/browser_use/browser/session.py
@@ -7,8 +7,9 @@ from typing import Any, Self, cast
import httpx
from bubus import EventBus
from cdp_use import CDPClient
+from cdp_use.cdp.fetch import AuthRequiredEvent, RequestPausedEvent
from cdp_use.cdp.network import Cookie
-from cdp_use.cdp.target import SessionID, TargetID
+from cdp_use.cdp.target import AttachedToTargetEvent, SessionID, TargetID
from pydantic import BaseModel, ConfigDict, Field, PrivateAttr
from uuid_extensions import uuid7str
@@ -24,6 +25,7 @@ from browser_use.browser.events import (
BrowserStateRequestEvent,
BrowserStopEvent,
BrowserStoppedEvent,
+ CloseTabEvent,
FileDownloadedEvent,
NavigateToUrlEvent,
NavigationCompleteEvent,
@@ -303,6 +305,7 @@ class BrowserSession(BaseModel):
BaseWatchdog.attach_handler_to_session(self, TabClosedEvent, self.on_TabClosedEvent)
BaseWatchdog.attach_handler_to_session(self, AgentFocusChangedEvent, self.on_AgentFocusChangedEvent)
BaseWatchdog.attach_handler_to_session(self, FileDownloadedEvent, self.on_FileDownloadedEvent)
+ BaseWatchdog.attach_handler_to_session(self, CloseTabEvent, self.on_CloseTabEvent)
async def start(self) -> None:
"""Start the browser session."""
@@ -548,6 +551,13 @@ class BrowserSession(BaseModel):
)
return self.agent_focus.target_id
+ async def on_CloseTabEvent(self, event: CloseTabEvent) -> None:
+ """Handle tab closure - update focus if needed."""
+
+ cdp_session = await self.get_or_create_cdp_session(target_id=None, focus=False)
+ await cdp_session.cdp_client.send.Target.closeTarget(params={'targetId': event.target_id})
+ await self.event_bus.dispatch(TabClosedEvent(target_id=event.target_id))
+
async def on_TabClosedEvent(self, event: TabClosedEvent) -> None:
"""Handle tab closure - update focus if needed."""
if not self.agent_focus:
@@ -1048,10 +1058,12 @@ class BrowserSession(BaseModel):
configured credentials from BrowserProfile.
"""
+ assert self._cdp_client_root
+
try:
proxy_cfg = self.browser_profile.proxy
- username = proxy_cfg.username if proxy_cfg else None
- password = proxy_cfg.password if proxy_cfg else None
+ username = proxy_cfg['username'] if proxy_cfg else None
+ password = proxy_cfg['password'] if proxy_cfg else None
if not username or not password:
self.logger.debug('Proxy credentials not provided; skipping proxy auth setup')
return
@@ -1074,14 +1086,19 @@ class BrowserSession(BaseModel):
except Exception as e:
self.logger.debug(f'Fetch.enable on focused session failed: {type(e).__name__}: {e}')
- def _on_auth_required(event: dict, session_id: SessionID | None = None):
+ def _on_auth_required(event: AuthRequiredEvent, session_id: SessionID | None = None):
# event keys may be snake_case or camelCase depending on generator; handle both
request_id = event.get('requestId') or event.get('request_id')
+ if not request_id:
+ return
+
challenge = event.get('authChallenge') or event.get('auth_challenge') or {}
source = (challenge.get('source') or '').lower()
# Only respond to proxy challenges
if source == 'proxy' and request_id:
+
async def _respond():
+ assert self._cdp_client_root
try:
await self._cdp_client_root.send.Fetch.continueWithAuth(
params={
@@ -1096,11 +1113,13 @@ class BrowserSession(BaseModel):
)
except Exception as e:
self.logger.debug(f'Proxy auth respond failed: {type(e).__name__}: {e}')
+
# schedule
asyncio.create_task(_respond())
else:
# Default behaviour for non-proxy challenges: let browser handle
async def _default():
+ assert self._cdp_client_root
try:
await self._cdp_client_root.send.Fetch.continueWithAuth(
params={'requestId': request_id, 'authChallengeResponse': {'response': 'Default'}},
@@ -1108,16 +1127,18 @@ class BrowserSession(BaseModel):
)
except Exception as e:
self.logger.debug(f'Default auth respond failed: {type(e).__name__}: {e}')
+
if request_id:
asyncio.create_task(_default())
- def _on_request_paused(event: dict, session_id: SessionID | None = None):
+ def _on_request_paused(event: RequestPausedEvent, session_id: SessionID | None = None):
# Continue all paused requests to avoid stalling the network
request_id = event.get('requestId') or event.get('request_id')
if not request_id:
return
async def _continue():
+ assert self._cdp_client_root
try:
await self._cdp_client_root.send.Fetch.continueRequest(
params={'requestId': request_id},
@@ -1140,12 +1161,13 @@ class BrowserSession(BaseModel):
self.logger.debug(f'Failed to register authRequired handlers: {type(e).__name__}: {e}')
# Auto-enable Fetch on every newly attached target to ensure auth callbacks fire
- def _on_attached(event: dict, session_id: SessionID | None = None):
+ def _on_attached(event: AttachedToTargetEvent, session_id: SessionID | None = None):
sid = event.get('sessionId') or event.get('session_id') or session_id
if not sid:
return
async def _enable():
+ assert self._cdp_client_root
try:
await self._cdp_client_root.send.Fetch.enable(
params={'handleAuthRequests': True},
@@ -1170,7 +1192,7 @@ class BrowserSession(BaseModel):
params={'handleAuthRequests': True, 'patterns': [{'urlPattern': '*'}]},
session_id=self.agent_focus.session_id,
)
- except Exception:
+ except Exception as e:
self.logger.debug(f'Fetch.enable on focused session failed: {type(e).__name__}: {e}')
except Exception as e:
self.logger.debug(f'Skipping proxy auth setup: {type(e).__name__}: {e}')
diff --git a/browser_use/controller/service.py b/browser_use/controller/service.py
index 4104882e5..bd37e07a6 100644
--- a/browser_use/controller/service.py
+++ b/browser_use/controller/service.py
@@ -49,7 +49,7 @@ from browser_use.filesystem.file_system import FileSystem
from browser_use.llm.base import BaseChatModel
from browser_use.llm.messages import UserMessage
from browser_use.observability import observe_debug
-from browser_use.utils import time_execution_sync
+from browser_use.utils import _log_pretty_url, time_execution_sync
logger = logging.getLogger(__name__)
@@ -287,13 +287,13 @@ class Controller(Generic[Context]):
memory = f'Clicked element with index {params.index}'
msg = f'🖱️ {memory}'
logger.info(msg)
-
+
# Include click coordinates in metadata if available
return ActionResult(
- extracted_content=memory,
- include_in_memory=True,
+ extracted_content=memory,
+ include_in_memory=True,
long_term_memory=memory,
- metadata=click_metadata if isinstance(click_metadata, dict) else None
+ metadata=click_metadata if isinstance(click_metadata, dict) else None,
)
except Exception as e:
logger.error(f'Failed to execute ClickElementEvent: {type(e).__name__}: {e}')
@@ -332,13 +332,13 @@ class Controller(Generic[Context]):
input_metadata = await event.event_result(raise_if_any=True, raise_if_none=False)
msg = f"Input '{params.text}' into element {params.index}."
logger.info(msg)
-
+
# Include input coordinates in metadata if available
return ActionResult(
extracted_content=msg,
include_in_memory=True,
long_term_memory=f"Input '{params.text}' into element {params.index}.",
- metadata=input_metadata if isinstance(input_metadata, dict) else None
+ metadata=input_metadata if isinstance(input_metadata, dict) else None,
)
except Exception as e:
# Log the full error for debugging
@@ -512,11 +512,16 @@ class Controller(Generic[Context]):
# Dispatch close tab event
try:
target_id = await browser_session.get_target_id_from_tab_id(params.tab_id)
+ cdp_session = await browser_session.get_or_create_cdp_session()
+ target_info = await cdp_session.cdp_client.send.Target.getTargetInfo(
+ params={'targetId': target_id}, session_id=cdp_session.session_id
+ )
+ tab_url = target_info['targetInfo']['url']
event = browser_session.event_bus.dispatch(CloseTabEvent(target_id=target_id))
await event
await event.event_result(raise_if_any=True, raise_if_none=False)
- memory = f'Closed tab # {params.tab_id}'
- logger.info(f'❌ {memory}')
+ memory = f'Closed tab # {params.tab_id} ({_log_pretty_url(tab_url)})'
+ logger.info(f'🗑️ {memory}')
return ActionResult(
extracted_content=memory,
include_in_memory=True,