Open-source Python library for AI browser agents, plus Browser Use Cloud: stealth browsers and a hosted agent API.
Python ai-agentsai-toolsbrowser-agentbrowser-automationbrowser-usecdpcloud-browsercomputer-useheadless-browserllmmcpplaywrightpythonremote-browserstealth-browserweb-automationweb-scraping
fix(tools): truncate long URLs in save_as_pdf footer so page numbers stay visible
Saurav Pandab88fd7048136
diff --git a/browser_use/tools/service.py b/browser_use/tools/service.pyindex a41083e61..10be3018c 100644--- a/browser_use/tools/service.py+++ b/browser_use/tools/service.py@@ -88,8 +88,11 @@ _DEFAULT_PDF_HEADER_TEMPLATE = (_DEFAULT_PDF_FOOTER_TEMPLATE = ('<div style="font-size:9px; color:#666; width:100%; padding:0 0.4in; ''box-sizing:border-box; display:flex; justify-content:space-between;">'- '<span class="url"></span>'- '<span><span class="pageNumber"></span> / <span class="totalPages"></span></span></div>'+ # A flex item defaults to min-width:auto and won't shrink below its content,+ # so a long/unbroken URL would overflow and push the page count off-page.+ # min-width:0 + ellipsis lets the URL truncate while page numbers stay put.+ '<span class="url" style="min-width:0; overflow:hidden; text-overflow:ellipsis; white-space:nowrap;"></span>'+ '<span style="flex-shrink:0; padding-left:8px;"><span class="pageNumber"></span> / <span class="totalPages"></span></span></div>')diff --git a/tests/ci/test_action_save_as_pdf.py b/tests/ci/test_action_save_as_pdf.pyindex 5d20d8367..c893403c6 100644--- a/tests/ci/test_action_save_as_pdf.py+++ b/tests/ci/test_action_save_as_pdf.py@@ -332,6 +332,33 @@ class TestSaveAsPdf:assert 'CONFIDENTIALDRAFT' in text_no_ws, f'Custom header not found in PDF text: {text_no_ws!r}'+ async def test_save_as_pdf_long_url_keeps_page_number(self, tools, browser_session, base_url):+ """A long footer URL truncates instead of pushing the page number off the printable area."""+ import pypdf++ # Long, unbroken URL — without min-width:0 + ellipsis on the url span this+ # overflows the footer and pushes the page count past the page edge.+ long_url = f'{base_url}/pdf-test?q={"x" * 400}'+ await tools.navigate(url=long_url, new_tab=False, browser_session=browser_session)+ await asyncio.sleep(0.5)++ with tempfile.TemporaryDirectory() as temp_dir:+ file_system = FileSystem(temp_dir)+ result = await tools.save_as_pdf(+ file_name='long-url',+ # Suppress the header date so the page-number check below is unambiguous.+ header_template='<span></span>',+ browser_session=browser_session,+ file_system=file_system,+ )++ pdf_path = _get_attachments(result)[0]+ reader = pypdf.PdfReader(pdf_path)+ text_no_ws = ''.join(reader.pages[0].extract_text().split())++ # The footer page count must still render despite the very long URL.+ assert '1/1' in text_no_ws, f'page number pushed off-page by long URL: {text_no_ws!r}'+async def test_save_as_pdf_param_model_schema(self):"""SaveAsPdfAction schema exposes the right fields with defaults."""from browser_use.tools.views import SaveAsPdfAction