Skip to content

Open-source Python library for AI browser agents, plus Browser Use Cloud: stealth browsers and a hosted agent API.

Update navigation event

Magnus Müllerbe1a014f56dc
diff --git a/tests/ci/test_browser_event_NavigateToUrlEvent2.py b/tests/ci/test_browser_event_NavigateToUrlEvent2.py
index 1e364e976..0266bc638 100644
--- a/tests/ci/test_browser_event_NavigateToUrlEvent2.py
+++ b/tests/ci/test_browser_event_NavigateToUrlEvent2.py
@@ -222,7 +222,8 @@ async def test_navigation_events_history_pushstate(httpserver):
if hasattr(element, 'attributes') and element.attributes.get('id') == 'push-btn':
push_button_found = True
click_element = await session.get_dom_element_by_index(idx)
- session.event_bus.dispatch(ClickElementEvent(node=click_element))
+ if click_element is not None:
+ session.event_bus.dispatch(ClickElementEvent(node=click_element))
break
assert push_button_found, 'Should find push state button'
@@ -241,7 +242,8 @@ async def test_navigation_events_history_pushstate(httpserver):
if hasattr(element, 'attributes') and element.attributes.get('id') == 'same-tab-link':
same_tab_link_found = True
click_element = await session.get_dom_element_by_index(idx)
- session.event_bus.dispatch(ClickElementEvent(node=click_element))
+ if click_element is not None:
+ session.event_bus.dispatch(ClickElementEvent(node=click_element))
break
assert same_tab_link_found, 'Should find same tab link'
@@ -271,7 +273,8 @@ async def test_navigation_events_history_pushstate(httpserver):
new_tab_link_found = True
# Use new_tab=True parameter to properly trigger new tab behavior
click_element = await session.get_dom_element_by_index(idx)
- session.event_bus.dispatch(ClickElementEvent(node=click_element, while_holding_ctrl=True))
+ if click_element is not None:
+ session.event_bus.dispatch(ClickElementEvent(node=click_element, while_holding_ctrl=True))
break
if new_tab_link_found:
@@ -367,7 +370,8 @@ async def test_navigation_events_link_clicks(httpserver):
if hasattr(element, 'attributes') and element.attributes.get('id') == 'same-tab-link':
same_tab_link_found = True
click_element = await session.get_dom_element_by_index(idx)
- session.event_bus.dispatch(ClickElementEvent(node=click_element))
+ if click_element is not None:
+ session.event_bus.dispatch(ClickElementEvent(node=click_element))
break
assert same_tab_link_found, 'Should find same tab link'
@@ -396,7 +400,8 @@ async def test_navigation_events_link_clicks(httpserver):
if hasattr(element, 'attributes') and element.attributes.get('id') == 'new-tab-link':
new_tab_link_found = True
click_element = await session.get_dom_element_by_index(idx)
- session.event_bus.dispatch(ClickElementEvent(node=click_element, while_holding_ctrl=True))
+ if click_element is not None:
+ session.event_bus.dispatch(ClickElementEvent(node=click_element, while_holding_ctrl=True))
break
if new_tab_link_found:
@@ -424,7 +429,8 @@ async def test_navigation_events_link_clicks(httpserver):
if hasattr(element, 'attributes') and element.attributes.get('id') == 'js-navigation':
js_link_found = True
click_element = await session.get_dom_element_by_index(idx)
- session.event_bus.dispatch(ClickElementEvent(node=click_element))
+ if click_element is not None:
+ session.event_bus.dispatch(ClickElementEvent(node=click_element))
break
if js_link_found:
diff --git a/tests/ci/test_browser_session_element_cache.py b/tests/ci/test_browser_session_element_cache.py
index c078c0f6a..b70e858d9 100644
--- a/tests/ci/test_browser_session_element_cache.py
+++ b/tests/ci/test_browser_session_element_cache.py
@@ -5,8 +5,6 @@ Test each assumption step by step to isolate the problem.
import pytest
-pytest.skip('TODO: fix - uses removed get_current_page method', allow_module_level=True)
-
from browser_use.browser import BrowserSession
from browser_use.browser.profile import BrowserProfile
from browser_use.tools.service import Tools
diff --git a/tests/ci/test_browser_session_output_paths.py b/tests/ci/test_browser_session_output_paths.py
index 138ff366c..b909654f8 100644
--- a/tests/ci/test_browser_session_output_paths.py
+++ b/tests/ci/test_browser_session_output_paths.py
@@ -10,6 +10,7 @@ import pytest
from browser_use import Agent, AgentHistoryList
from browser_use.browser import BrowserProfile, BrowserSession
+from browser_use.browser.events import NavigateToUrlEvent
from tests.ci.conftest import create_mock_llm
@@ -248,7 +249,9 @@ class TestBrowserProfileRecordings:
)
await browser_session.start()
try:
- await browser_session.navigate(httpserver_url)
+ event = browser_session.event_bus.dispatch(NavigateToUrlEvent(url=httpserver_url))
+ await event
+ await event.event_result(raise_if_any=True, raise_if_none=False)
await asyncio.sleep(0.5)
finally:
await browser_session.kill()
@@ -292,7 +295,9 @@ class TestBrowserProfileRecordings:
await browser_session1.start()
try:
# Create some activity to establish browser context
- await browser_session1.navigate(httpserver_url)
+ event = browser_session1.event_bus.dispatch(NavigateToUrlEvent(url=httpserver_url))
+ await event
+ await event.event_result(raise_if_any=True, raise_if_none=False)
await asyncio.sleep(0.5)
# Step 2: Connect to the SAME browser but WITH video recording
@@ -309,12 +314,14 @@ class TestBrowserProfileRecordings:
await browser_session2.start()
try:
# Verify contexts are different (with the fix)
- assert browser_session1.browser_context != browser_session2.browser_context, (
+ assert browser_session1._cdp_client_root != browser_session2._cdp_client_root, (
'Bug still exists: Same context was reused instead of creating new one for video recording'
)
# Test video recording functionality
- await browser_session2.navigate(httpserver_url)
+ event = browser_session2.event_bus.dispatch(NavigateToUrlEvent(url=httpserver_url))
+ await event
+ await event.event_result(raise_if_any=True, raise_if_none=False)
await asyncio.sleep(1) # Record some content
finally:
@@ -361,7 +368,9 @@ class TestBrowserProfileRecordings:
)
await browser_session.start()
try:
- await browser_session.navigate(httpserver_url)
+ event = browser_session.event_bus.dispatch(NavigateToUrlEvent(url=httpserver_url))
+ await event
+ await event.event_result(raise_if_any=True, raise_if_none=False)
await asyncio.sleep(0.5)
finally:
await browser_session.kill()
diff --git a/tests/ci/test_browser_session_recent_events.py b/tests/ci/test_browser_session_recent_events.py
index 47853ffa3..fdbffb878 100644
--- a/tests/ci/test_browser_session_recent_events.py
+++ b/tests/ci/test_browser_session_recent_events.py
@@ -11,6 +11,7 @@ from pytest_httpserver import HTTPServer
from werkzeug.wrappers import Response
from browser_use.browser import BrowserProfile, BrowserSession
+from browser_use.browser.events import NavigateToUrlEvent, ScreenshotEvent
class TestBrowserRecentEvents:
@@ -66,7 +67,8 @@ class TestBrowserRecentEvents:
# Navigate to the page with the slow iframe
# Don't await to allow navigation to start in background
- nav_task = asyncio.create_task(browser_session.navigate(httpserver.url_for('/')))
+ event = browser_session.event_bus.dispatch(NavigateToUrlEvent(url=httpserver.url_for('/')))
+ nav_task = asyncio.create_task(event)
# Give navigation a moment to start loading resources
await asyncio.sleep(0.5)
@@ -139,7 +141,9 @@ class TestBrowserRecentEvents:
await browser_session.start()
# Navigate to the fast-loading page
- await browser_session.navigate(httpserver.url_for('/fast'))
+ event = browser_session.event_bus.dispatch(NavigateToUrlEvent(url=httpserver.url_for('/fast')))
+ await event
+ await event.event_result(raise_if_any=True, raise_if_none=False)
# Get browser state
state = await browser_session.get_browser_state_summary()
@@ -203,7 +207,9 @@ class TestBrowserRecentEvents:
await browser_session.start()
# Navigate to slow page
- await browser_session.navigate(httpserver.url_for('/slow'))
+ event = browser_session.event_bus.dispatch(NavigateToUrlEvent(url=httpserver.url_for('/slow')))
+ await event
+ await event.event_result(raise_if_any=True, raise_if_none=False)
state1 = await browser_session.get_browser_state_summary()
assert state1.recent_events is not None
events1 = json.loads(state1.recent_events)
@@ -211,7 +217,9 @@ class TestBrowserRecentEvents:
assert 'NavigationCompleteEvent' in event_types1 or 'NavigateToUrlEvent' in event_types1
# Navigate to fast page
- await browser_session.navigate(httpserver.url_for('/fast'))
+ event = browser_session.event_bus.dispatch(NavigateToUrlEvent(url=httpserver.url_for('/fast')))
+ await event
+ await event.event_result(raise_if_any=True, raise_if_none=False)
state2 = await browser_session.get_browser_state_summary()
# Recent events should show both navigations
@@ -269,7 +277,9 @@ class TestBrowserRecentEvents:
await browser_session.start()
# Navigate to the malformed page
- await browser_session.navigate(httpserver.url_for('/malformed'))
+ event = browser_session.event_bus.dispatch(NavigateToUrlEvent(url=httpserver.url_for('/malformed')))
+ await event
+ await event.event_result(raise_if_any=True, raise_if_none=False)
# Get browser state - this might fall back to minimal state
state = await browser_session.get_browser_state_summary()
@@ -321,7 +331,9 @@ class TestBrowserRecentEvents:
await browser_session.start()
# Navigate to the page
- await browser_session.navigate(httpserver.url_for(f'/timeout_{timeout_seconds}'))
+ event = browser_session.event_bus.dispatch(NavigateToUrlEvent(url=httpserver.url_for(f'/timeout_{timeout_seconds}')))
+ await event
+ await event.event_result(raise_if_any=True, raise_if_none=False)
# Get browser state
state = await browser_session.get_browser_state_summary()
@@ -363,8 +375,12 @@ class TestEventHistoryInfrastructure:
)
# Perform actions that generate events
- await browser_session.navigate(httpserver.url_for('/history-test'))
- await browser_session.take_screenshot()
+ event = browser_session.event_bus.dispatch(NavigateToUrlEvent(url=httpserver.url_for('/history-test')))
+ await event
+ await event.event_result(raise_if_any=True, raise_if_none=False)
+ screenshot_event = browser_session.event_bus.dispatch(ScreenshotEvent())
+ await screenshot_event
+ await screenshot_event.event_result(raise_if_any=True, raise_if_none=False)
# Verify event history has grown
final_history_count = len(browser_session.event_bus.event_history)
@@ -391,7 +407,9 @@ class TestEventHistoryInfrastructure:
'<html><body><h1>JSON Test</h1></body></html>',
content_type='text/html',
)
- await browser_session.navigate(httpserver.url_for('/json-test'))
+ event = browser_session.event_bus.dispatch(NavigateToUrlEvent(url=httpserver.url_for('/json-test')))
+ await event
+ await event.event_result(raise_if_any=True, raise_if_none=False)
# Test the NEW method _generate_recent_events_summary
recent_events_json = browser_session._generate_recent_events_summary(max_events=5)
@@ -423,8 +441,12 @@ class TestEventHistoryInfrastructure:
)
# Perform multiple actions to generate events
- await browser_session.navigate(httpserver.url_for('/limit-test'))
- await browser_session.take_screenshot()
+ event = browser_session.event_bus.dispatch(NavigateToUrlEvent(url=httpserver.url_for('/limit-test')))
+ await event
+ await event.event_result(raise_if_any=True, raise_if_none=False)
+ screenshot_event = browser_session.event_bus.dispatch(ScreenshotEvent())
+ await screenshot_event
+ await screenshot_event.event_result(raise_if_any=True, raise_if_none=False)
await browser_session.get_tabs()
# Test different limits
diff --git a/tests/ci/test_browser_session_reuse.py b/tests/ci/test_browser_session_reuse.py
deleted file mode 100644
index d4bf16b4c..000000000
--- a/tests/ci/test_browser_session_reuse.py
+++ /dev/null
@@ -1,172 +0,0 @@
-"""
-Test browser session reuse and regeneration after browser disconnection.
-
-Tests cover:
-- Browser regeneration after context is closed
-- Screenshot functionality after regeneration
-- Multiple regeneration cycles
-"""
-
-import asyncio
-
-import pytest
-
-from browser_use.browser.profile import BrowserProfile
-from browser_use.browser.session import BrowserSession
-
-
-class TestBrowserSessionReuse:
- """Tests for browser session reuse and regeneration after disconnection."""
-
- # TODO: fix this test / pid detection
- # async def test_browser_regeneration_after_disconnect(self):
- # """Test that browser regenerates and screenshot succeeds after disconnection"""
- # session = BrowserSession(browser_profile=BrowserProfile(headless=True, user_data_dir=None))
-
- # try:
- # # Start browser session
- # await session.start()
-
- # # Navigate to a test page
- # assert session.page is not None
- # await session.page.goto('data:text/html,<h1>Test Page - Before Disconnect</h1>')
-
- # # Take a screenshot before disconnection
- # screenshot1 = await session.take_screenshot()
- # assert screenshot1 is not None
- # assert len(screenshot1) > 0
-
- # # Store initial browser PID
- # initial_browser_pid = session.browser_pid
- # assert initial_browser_pid is not None
-
- # # Force disconnect the browser by closing the browser context
- # assert session._cdp_client_root is not None
- # await session._cdp_client_root.close()
-
- # # Try to take a screenshot - this should trigger regeneration internally
- # # Thanks to the @require_initialization decorator and our fix, this should succeed
- # screenshot2 = await session.take_screenshot()
- # assert screenshot2 is not None
- # assert len(screenshot2) > 0
-
- # # Check if browser was regenerated (new browser context created)
- # assert session._cdp_client_root is not None
- # # Verify the context is valid by checking if we can access its pages
- # assert session._cdp_client_root.pages is not None
-
- # # Verify we can still interact with the browser
- # assert session.page is not None
- # await session.page.goto('data:text/html,<h1>Test Page - After Regeneration</h1>')
- # screenshot3 = await session.take_screenshot()
- # assert screenshot3 is not None
- # assert len(screenshot3) > 0
-
- # finally:
- # await session.stop()
-
- @pytest.mark.skip(reason='TODO: fix')
- async def test_multiple_browser_regenerations(self, httpserver):
- """Test multiple browser regeneration cycles"""
- session = BrowserSession(browser_profile=BrowserProfile(headless=True, user_data_dir=None))
-
- httpserver.expect_request('/normal').respond_with_data(
- '<html><body><h1>Normal Page</h1></body></html>',
- content_type='text/html',
- )
-
- try:
- await session.start()
-
- for i in range(3):
- # Navigate to a test page
- assert session.page is not None
- await session.page.goto(httpserver.url_for('/normal'), wait_until='load', timeout=3000)
-
- # Take screenshot before disconnect
- screenshot_before = await session.take_screenshot()
- assert screenshot_before is not None
- assert len(screenshot_before) > 100
-
- # Properly kill the session to clean up browser subprocess
- await session.kill()
-
- # Add a delay to ensure all resources are released
- await asyncio.sleep(0.5)
-
- # Start a fresh session for the next iteration
- await session.start()
-
- # Take screenshot after regeneration
- screenshot_after = await session.take_screenshot()
- assert screenshot_after is not None
- assert len(screenshot_after) > 0 and len(screenshot_after) < 200, (
- 'expected white 4px screenshot of about:blank when browser is reset after disconnection'
- )
-
- finally:
- await session.kill()
-
- @pytest.mark.skip(reason='TODO: fix')
- async def test_browser_session_reuse_with_retry_decorator(self):
- """Test that the retry decorator properly handles browser regeneration"""
- session = BrowserSession(browser_profile=BrowserProfile(headless=True, user_data_dir=None))
-
- try:
- await session.start()
-
- # Navigate to a test page
- assert session.page is not None
- await session.page.goto('data:text/html,<h1>Test Retry Decorator</h1>')
-
- # Take a screenshot to verify it works
- screenshot1 = await session.take_screenshot()
- assert screenshot1 is not None
-
- # Store browser PID
- initial_pid = session.browser_pid
-
- # Close the browser context while a screenshot is in progress
- # This simulates a browser crash during CDP operation
- async def close_during_operation():
- await asyncio.sleep(0.05) # Small delay to let CDP operation start
- if session._cdp_client_root:
- try:
- await session._cdp_client_root.close()
- except Exception:
- # Context might already be closed
- pass
-
- # Start the close task
- close_task = asyncio.create_task(close_during_operation())
-
- try:
- # Try to take a screenshot - the retry decorator should handle the failure
- # Note: This might succeed if the screenshot completes before the close
- try:
- screenshot2 = await session.take_screenshot()
- # If it succeeded, the browser should have been regenerated
- assert screenshot2 is not None
- except Exception:
- # If it failed, that's also OK - the browser state was reset
- pass
-
- # Wait for close task to complete
- await close_task
- finally:
- # Ensure the task is properly cancelled if it hasn't completed
- if not close_task.done():
- close_task.cancel()
- try:
- await close_task
- except asyncio.CancelledError:
- pass
-
- # Verify we can still use the browser after regeneration
- await session.start() # Ensure browser is started
- screenshot3 = await session.take_screenshot()
- assert screenshot3 is not None
- assert len(screenshot3) > 0
-
- finally:
- await session.stop()
diff --git a/tests/ci/test_browser_session_storage_state.py b/tests/ci/test_browser_session_storage_state.py
index be9115289..61a1cb2d5 100644
--- a/tests/ci/test_browser_session_storage_state.py
+++ b/tests/ci/test_browser_session_storage_state.py
@@ -14,9 +14,6 @@ import tempfile
from pathlib import Path
import pytest
-
-pytest.skip('TODO: fix - uses removed _cdp_client_root attribute', allow_module_level=True)
-
from pytest_httpserver import HTTPServer
from browser_use.browser.events import SaveStorageStateEvent
diff --git a/tests/ci/test_browser_session_via_cdp.py b/tests/ci/test_browser_session_via_cdp.py
index 9aca50788..f133a99d1 100644
--- a/tests/ci/test_browser_session_via_cdp.py
+++ b/tests/ci/test_browser_session_via_cdp.py
@@ -1,7 +1,5 @@
import pytest
-pytest.skip('TODO: fix - import error for async_playwright', allow_module_level=True)
-
from browser_use.browser import BrowserSession
from browser_use.browser.profile import BrowserProfile
from browser_use.browser.types import async_playwright
diff --git a/tests/ci/test_browser_session_viewport_and_proxy.py b/tests/ci/test_browser_session_viewport_and_proxy.py
index 7dcee9e71..e224fd8e2 100644
--- a/tests/ci/test_browser_session_viewport_and_proxy.py
+++ b/tests/ci/test_browser_session_viewport_and_proxy.py
@@ -1,7 +1,3 @@
-import pytest
-
-pytest.skip('TODO: fix - import error for ProxySettings', allow_module_level=True)
-
from browser_use.browser import BrowserSession
from browser_use.browser.profile import BrowserProfile, ProxySettings, ViewportSize
diff --git a/tests/ci/test_browser_watchdog_aboutblank.py b/tests/ci/test_browser_watchdog_aboutblank.py
index 058a3ac0f..069394df0 100644
--- a/tests/ci/test_browser_watchdog_aboutblank.py
+++ b/tests/ci/test_browser_watchdog_aboutblank.py
@@ -200,7 +200,7 @@ async def test_aboutblank_watchdog_javascript_execution():
# Get the page and verify animation
# Get tab info instead of page
tabs1 = await session.get_tabs()
- tab1 = tabs1[dvd_event1.target_id]
+ tab1 = next((tab for tab in tabs1 if tab.target_id == dvd_event1.target_id), None)
assert tab1 is not None, f'Could not find tab at index {dvd_event1.target_id}'
# Verify the animation was created
@@ -221,7 +221,7 @@ async def test_aboutblank_watchdog_javascript_execution():
# Get the new page
# Get tab info instead of page
tabs2 = await session.get_tabs()
- tab2 = tabs2[dvd_event2.target_id]
+ tab2 = next((tab for tab in tabs2 if tab.target_id == dvd_event2.target_id), None)
assert tab2 is not None, f'Could not find tab # {dvd_event2.target_id}'
assert CrashWatchdog._is_new_tab_page(tab2.url), f'Auto-created tab should be a new tab page, but got: {tab2.url}'