Skip to content

Open-source Python library for AI browser agents, plus Browser Use Cloud: stealth browsers and a hosted agent API.

cli fixes and types for input

Nick Sweetingcb5fb38036a3
diff --git a/browser_use/cli.py b/browser_use/cli.py
index ea643ea90..7b24d0494 100644
--- a/browser_use/cli.py
+++ b/browser_use/cli.py
@@ -499,12 +499,21 @@ class BrowserUseApp(App):
browser_use_logger.setLevel(root.level)
# Also ensure agent loggers go to the main output
- for logger_name in ['browser_use.Agent', 'browser_use.controller']:
+ # Use a wildcard pattern to catch all agent-related loggers
+ for logger_name in ['browser_use.Agent', 'browser_use.controller', 'browser_use.agent', 'browser_use.agent.service']:
agent_logger = logging.getLogger(logger_name)
agent_logger.propagate = False
agent_logger.handlers = [log_handler]
agent_logger.setLevel(root.level)
+ # Also catch any dynamically created agent loggers with task IDs
+ for name, logger in logging.Logger.manager.loggerDict.items():
+ if isinstance(name, str) and 'browser_use.Agent' in name:
+ if isinstance(logger, logging.Logger):
+ logger.propagate = False
+ logger.handlers = [log_handler]
+ logger.setLevel(root.level)
+
# Silence third-party loggers
for logger_name in [
'WDM',
diff --git a/browser_use/controller/service.py b/browser_use/controller/service.py
index 59cba5621..c2a8f2cd0 100644
--- a/browser_use/controller/service.py
+++ b/browser_use/controller/service.py
@@ -2,6 +2,7 @@ import asyncio
import enum
import json
import logging
+import os
from typing import Generic, TypeVar
try:
@@ -277,12 +278,15 @@ class Controller(Generic[Context]):
selector_map = await browser_session.get_selector_map()
if params.index not in selector_map:
raise BrowserError(f'Element with index {params.index} not found in selector map')
-
+
node = selector_map[params.index]
-
+
# Helper function to find file input near the selected element
- def find_file_input_near_element(node: EnhancedDOMTreeNode, max_height: int = 3, max_descendant_depth: int = 3) -> EnhancedDOMTreeNode | None:
+ def find_file_input_near_element(
+ node: EnhancedDOMTreeNode, max_height: int = 3, max_descendant_depth: int = 3
+ ) -> EnhancedDOMTreeNode | None:
"""Find the closest file input to the selected element."""
+
def find_file_input_in_descendants(n: EnhancedDOMTreeNode, depth: int) -> EnhancedDOMTreeNode | None:
if depth < 0:
return None
@@ -293,7 +297,7 @@ class Controller(Generic[Context]):
if result:
return result
return None
-
+
current = node
for _ in range(max_height + 1):
# Check the current node itself
@@ -317,29 +321,30 @@ class Controller(Generic[Context]):
if not current:
break
return None
-
+
# Try to find a file input element near the selected element
file_input_node = find_file_input_near_element(node)
-
+
# If not found near the selected element, fallback to finding the closest file input to current scroll position
if file_input_node is None:
- logger.info(f'No file upload element found near index {params.index}, searching for closest file input to scroll position')
-
+ logger.info(
+ f'No file upload element found near index {params.index}, searching for closest file input to scroll position'
+ )
+
# Get current scroll position
cdp_session = await browser_session.get_or_create_cdp_session()
try:
scroll_info = await cdp_session.cdp_client.send.Runtime.evaluate(
- params={'expression': 'window.scrollY || window.pageYOffset || 0'},
- session_id=cdp_session.session_id
+ params={'expression': 'window.scrollY || window.pageYOffset || 0'}, session_id=cdp_session.session_id
)
current_scroll_y = scroll_info.get('result', {}).get('value', 0)
except:
current_scroll_y = 0
-
+
# Find all file inputs in the selector map and pick the closest one to scroll position
closest_file_input = None
min_distance = float('inf')
-
+
for idx, element in selector_map.items():
if browser_session.is_file_input(element):
# Get element's Y position
@@ -349,22 +354,17 @@ class Controller(Generic[Context]):
if distance < min_distance:
min_distance = distance
closest_file_input = element
-
+
if closest_file_input:
file_input_node = closest_file_input
logger.info(f'Found file input closest to scroll position (distance: {min_distance}px)')
else:
- msg = f'No file upload element found on the page'
+ msg = 'No file upload element found on the page'
logger.info(msg)
raise BrowserError(msg)
# Dispatch upload file event with the file input node
- event = browser_session.event_bus.dispatch(
- UploadFileEvent(
- node=file_input_node,
- file_path=params.path
- )
- )
+ event = browser_session.event_bus.dispatch(UploadFileEvent(node=file_input_node, file_path=params.path))
await event
msg = f'📁 Successfully uploaded file to index {params.index}'