Skip to content

Open-source Python library for AI browser agents, plus Browser Use Cloud: stealth browsers and a hosted agent API.

fix(mcp): surface CallToolResult.isError as a failed ActionResult

Andrew Chenceda06382e42
diff --git a/browser_use/mcp/client.py b/browser_use/mcp/client.py
index 46db1a15e..36dbf9856 100644
--- a/browser_use/mcp/client.py
+++ b/browser_use/mcp/client.py
@@ -326,6 +326,10 @@ class MCPClient:
# Convert MCP result to ActionResult
extracted_content = self._format_mcp_result(result)
+ if getattr(result, 'isError', False):
+ error_msg = f"MCP tool '{tool.name}' reported an error: {extracted_content}"
+ return ActionResult(error=error_msg, success=False)
+
return ActionResult(
extracted_content=extracted_content,
long_term_memory=f"Used MCP tool '{tool.name}' from {self.server_name}",
@@ -370,6 +374,10 @@ class MCPClient:
# Convert MCP result to ActionResult
extracted_content = self._format_mcp_result(result)
+ if getattr(result, 'isError', False):
+ error_msg = f"MCP tool '{tool.name}' reported an error: {extracted_content}"
+ return ActionResult(error=error_msg, success=False)
+
return ActionResult(
extracted_content=extracted_content,
long_term_memory=f"Used MCP tool '{tool.name}' from {self.server_name}",
diff --git a/tests/ci/test_mcp_client_error_result.py b/tests/ci/test_mcp_client_error_result.py
new file mode 100644
index 000000000..6d3219a54
--- /dev/null
+++ b/tests/ci/test_mcp_client_error_result.py
@@ -0,0 +1,66 @@
+"""Regression test for MCP tool calls that fail at the application level.
+
+Per the MCP spec, `CallToolResult.isError` signals that the tool itself
+reported a failure (e.g. "File not found") even though the RPC call
+succeeded. `MCPClient` must surface that as a failed `ActionResult`
+instead of silently treating `result.content` as a successful result.
+"""
+
+from unittest.mock import AsyncMock, MagicMock
+
+import pytest
+from mcp import types
+
+from browser_use import Tools
+from browser_use.mcp.client import MCPClient
+
+
+def _make_connected_client() -> MCPClient:
+ client = MCPClient(server_name='test-server', command='test-command')
+ client._telemetry = MagicMock()
+ client._connected = True
+ client.session = MagicMock()
+ return client
+
+
+async def test_mcp_tool_isError_true_is_surfaced_as_action_result_error():
+ """An MCP tool that reports isError=True must not look like a success."""
+ client = _make_connected_client()
+ client.session.call_tool = AsyncMock( # type: ignore[union-attr]
+ return_value=types.CallToolResult(
+ content=[types.TextContent(type='text', text='File not found: /tmp/does-not-exist.txt')],
+ isError=True,
+ )
+ )
+
+ tools = Tools()
+ tool = types.Tool(name='read_file', description='Read a file', inputSchema={'type': 'object', 'properties': {}})
+ client._register_tool_as_action(tools.registry, 'read_file', tool)
+
+ result = await tools.registry.execute_action('read_file', {})
+
+ assert result.success is False, f'expected success=False for a failed MCP tool call, got {result!r}'
+ assert result.error, f'expected result.error to be set for a failed MCP tool call, got {result!r}'
+ assert 'File not found' in result.error
+
+
+async def test_mcp_tool_isError_false_still_succeeds():
+ """Sanity check: a normal successful MCP tool call is unaffected by the fix."""
+ client = _make_connected_client()
+ client.session.call_tool = AsyncMock( # type: ignore[union-attr]
+ return_value=types.CallToolResult(
+ content=[types.TextContent(type='text', text='ok')],
+ isError=False,
+ )
+ )
+
+ tools = Tools()
+ tool = types.Tool(name='read_file', description='Read a file', inputSchema={'type': 'object', 'properties': {}})
+ client._register_tool_as_action(tools.registry, 'read_file', tool)
+
+ result = await tools.registry.execute_action('read_file', {})
+
+ assert result.error is None
+ assert result.extracted_content == 'ok'