Open-source Python library for AI browser agents, plus Browser Use Cloud: stealth browsers and a hosted agent API.
Python ai-agentsai-toolsbrowser-agentbrowser-automationbrowser-usecdpcloud-browsercomputer-useheadless-browserllmmcpplaywrightpythonremote-browserstealth-browserweb-automationweb-scraping
fix: address review comments (StopIteration, isClickable semantics)
MagMuellerd2aab6b49513
diff --git a/browser_use/dom/enhanced_snapshot.py b/browser_use/dom/enhanced_snapshot.pyindex 43a70fbb3..ecb110c6d 100644--- a/browser_use/dom/enhanced_snapshot.py+++ b/browser_use/dom/enhanced_snapshot.py@@ -88,12 +88,13 @@ def build_snapshot_lookup(# The raw CDP data uses List[int] which makes `index in list` O(n).# Called once per node, this was O(n²) total — the #1 bottleneck.# At 20k elements: 5,925ms (list) → 2ms (set) = 3,000x speedup.- is_clickable_set: set[int] = set(nodes['isClickable']['index']) if 'isClickable' in nodes else set()+ has_clickable_data = 'isClickable' in nodes+ is_clickable_set: set[int] = set(nodes['isClickable']['index']) if has_clickable_data else set()# Build snapshot lookup for each backend node idfor backend_node_id, snapshot_index in backend_node_to_snapshot_index.items():is_clickable = None- if is_clickable_set:+ if has_clickable_data:is_clickable = _parse_rare_boolean_data(is_clickable_set, snapshot_index)# Find corresponding layout nodediff --git a/browser_use/dom/service.py b/browser_use/dom/service.pyindex 268b10794..b32f2f218 100644--- a/browser_use/dom/service.py+++ b/browser_use/dom/service.py@@ -427,27 +427,23 @@ class DomService:iframe_scroll_ms = (time.time() - start_iframe_scroll) * 1000# Detect elements with JavaScript click event listeners (without mutating DOM)- # Skipped on heavy pages (>10k elements) where the querySelectorAll('*') loop +- # per-element DOM.describeNode calls can take 10s+. Elements are still detected- # via the accessibility tree and ClickableElementDetector heuristics.+ # On heavy pages (>10k elements) the querySelectorAll('*') + getEventListeners()+ # loop plus per-element DOM.describeNode CDP calls can take 10s+.+ # The JS expression below bails out early if the page is too heavy.+ # Elements are still detected via the accessibility tree and ClickableElementDetector.start_js_listener_detection = time.time()js_click_listener_backend_ids: set[int] = set()try:- # Quick check: skip on heavy pages- _el_count_r = await cdp_session.cdp_client.send.Runtime.evaluate(- params={'expression': 'document.querySelectorAll("*").length', 'returnByValue': True},- session_id=cdp_session.session_id,- )- _el_count = _el_count_r.get('result', {}).get('value', 0) if _el_count_r else 0- if _el_count > 10000:- self.logger.info(f'Skipping JS listener detection on heavy page ({_el_count} elements)')- raise StopIteration # Jump to except block — clean skip-# Step 1: Run JS to find elements with click listeners and return them by referencejs_listener_result = await cdp_session.cdp_client.send.Runtime.evaluate(params={'expression': """(() => {+ // Skip on heavy pages — listener detection is too expensive+ if (document.querySelectorAll('*').length > 10000) {+ return null;+ }+// getEventListeners is only available in DevTools context via includeCommandLineAPIif (typeof getEventListeners !== 'function') {return null;@@ -525,8 +521,6 @@ class DomService:pass # Best effort cleanupself.logger.debug(f'Detected {len(js_click_listener_backend_ids)} elements with JS click listeners')- except StopIteration:- pass # Heavy page skip — not an errorexcept Exception as e:self.logger.debug(f'Failed to detect JS event listeners: {e}')js_listener_detection_ms = (time.time() - start_js_listener_detection) * 1000