Skip to content

Open-source Python library for AI browser agents, plus Browser Use Cloud: stealth browsers and a hosted agent API.

Fix critical test issues: remove non-existent parameters and fix type errors

Magnus Müllerd3570cb3d0fc
diff --git a/tests/ci/test_browser_event_NavigateToUrlEvent2.py b/tests/ci/test_browser_event_NavigateToUrlEvent2.py
index b85befd09..1e364e976 100644
--- a/tests/ci/test_browser_event_NavigateToUrlEvent2.py
+++ b/tests/ci/test_browser_event_NavigateToUrlEvent2.py
@@ -89,7 +89,6 @@ async def test_navigation_events_slow_page_with_timeout(httpserver):
# Create profile with shorter timeout for faster testing
profile = BrowserProfile(
headless=True,
- maximum_wait_page_load_time=2.0, # 2 second timeout for network monitoring
wait_for_network_idle_page_load_time=0.5, # 0.5 second network idle
)
session = BrowserSession(browser_profile=profile)
diff --git a/tests/ci/test_browser_session_file_uploads.py b/tests/ci/test_browser_session_file_uploads.py
deleted file mode 100644
index b0563ca17..000000000
--- a/tests/ci/test_browser_session_file_uploads.py
+++ /dev/null
@@ -1,336 +0,0 @@
-"""
-Tests for browser session file upload functionality using real HTML.
-
-Tests cover common real-world file upload patterns:
-- Standard form file uploads
-- Hidden file inputs triggered by buttons
-- Multiple file upload fields
-- Complex nested structures
-"""
-
-import pytest
-from pytest_httpserver import HTTPServer
-
-from browser_use.browser.profile import BrowserProfile
-from browser_use.browser.session import BrowserSession
-
-
-class TestBrowserSessionFileUploads:
- """Tests for file upload element finding functionality with real HTML."""
-
- @pytest.fixture
- async def browser_session(self):
- """Create a BrowserSession instance for testing."""
- session = BrowserSession(browser_profile=BrowserProfile(headless=True, user_data_dir=None, keep_alive=True))
- yield session
- await session.kill()
-
- @pytest.fixture
- def test_server(self, httpserver: HTTPServer):
- """Set up test HTTP server with various file upload scenarios."""
- return httpserver
-
- @pytest.mark.skip(reason='TODO: fix')
- async def test_standard_file_upload_patterns(self, browser_session: BrowserSession, test_server: HTTPServer):
- """Test finding file inputs in standard form layouts and modern UI patterns."""
- html = """
- <!DOCTYPE html>
- <html>
- <body>
- <h1>File Upload Test Page</h1>
-
- <!-- Pattern 1: Simple visible file input in form -->
- <form id="simple-form">
- <label for="file1">Choose file:</label>
- <input type="file" id="file1" name="document">
- <button type="submit">Upload</button>
- </form>
-
- <!-- Pattern 2: Hidden file input with custom button (Material/Bootstrap style) -->
- <div class="upload-section">
- <button class="btn btn-primary" onclick="document.getElementById('hidden-file').click()">
- Select File
- </button>
- <input type="file" id="hidden-file" style="display: none;" accept=".pdf,.doc,.docx">
- <span class="filename">No file selected</span>
- </div>
-
- <!-- Pattern 3: Nested file input in card/modal structure -->
- <div class="modal">
- <div class="modal-content">
- <div class="modal-header">
- <h3>Upload Document</h3>
- </div>
- <div class="modal-body">
- <div class="form-group">
- <label>Select your file:</label>
- <div class="input-wrapper">
- <input type="file" id="modal-file" class="form-control">
- </div>
- </div>
- </div>
- </div>
- </div>
-
- <!-- Pattern 4: Multiple file inputs -->
- <form id="multi-upload">
- <div class="field-group">
- <label>Profile Photo</label>
- <input type="file" name="photo" accept="image/*">
- </div>
- <div class="field-group">
- <label>Resume</label>
- <input type="file" name="resume" accept=".pdf">
- </div>
- </form>
-
- <!-- Pattern 5: Dropzone-style upload area -->
- <div class="dropzone" onclick="this.querySelector('input').click()">
- <div class="dz-message">
- <i class="icon-upload"></i>
- <p>Drop files here or click to upload</p>
- </div>
- <input type="file" multiple style="display: none;">
- </div>
- </body>
- </html>
- """
-
- test_server.expect_request('/upload').respond_with_data(html, content_type='text/html')
- await browser_session.start()
- # Navigate to upload page using event
- from browser_use.browser.events import NavigateToUrlEvent, NavigationCompleteEvent
-
- event = browser_session.event_bus.dispatch(NavigateToUrlEvent(url=test_server.url_for('/upload')))
- await event
- # Wait for page to load
- await browser_session.event_bus.expect(NavigationCompleteEvent, timeout=10.0)
-
- # Get browser state to populate selector map
- await browser_session.get_browser_state_summary(cache_clickable_elements_hashes=False)
-
- # Get the selector map after page load
- selector_map = await browser_session.get_selector_map()
-
- # The selector map contains clickable elements, so let's test by looking for elements directly
- # Test 1: Find file input when it's the clicked element itself
- all_file_inputs = []
- for idx, elem in selector_map.items():
- if elem.tag_name == 'input' and elem.attributes.get('type') == 'file':
- all_file_inputs.append((idx, elem))
-
- # Should find at least one file input in the map
- assert len(all_file_inputs) > 0, f'No file inputs found in selector map. Map has {len(selector_map)} elements'
-
- # Test finding the first file input
- first_file_idx, first_file_elem = all_file_inputs[0]
- file_input = await browser_session.find_file_upload_element_by_index(first_file_idx)
- assert file_input is not None
- assert file_input == first_file_elem
-
- # Test 2: Find hidden file input from button - look for any button
- button_indices = []
- for idx, elem in selector_map.items():
- if elem.tag_name == 'button':
- button_indices.append(idx)
-
- # Try finding file input from each button
- found_from_button = False
- for button_idx in button_indices:
- file_input = await browser_session.find_file_upload_element_by_index(button_idx)
- if file_input is not None:
- found_from_button = True
- break
-
- assert found_from_button, 'Could not find any file input from any button'
-
- # Test 3: Find file input from parent containers
- div_indices = []
- for idx, elem in selector_map.items():
- if elem.tag_name == 'div':
- div_indices.append(idx)
-
- # Try finding file input from divs
- found_from_div = False
- for div_idx in div_indices[:10]: # Test first 10 divs
- file_input = await browser_session.find_file_upload_element_by_index(div_idx)
- if file_input is not None:
- found_from_div = True
- break
-
- assert found_from_div, 'Could not find any file input from any div container'
-
- @pytest.mark.skip(reason='TODO: fix')
- async def test_dom_traversal_functionality(self, browser_session: BrowserSession, test_server: HTTPServer):
- """Test that the file upload finder correctly traverses the DOM."""
- html = """
- <!DOCTYPE html>
- <html>
- <body>
- <!-- Test case 1: Deep nesting -->
- <div class="container">
- <button class="deep-button">Upload from Deep</button>
- <div>
- <div>
- <div>
- <input type="file" id="deep-file">
- </div>
- </div>
- </div>
- </div>
-
- <!-- Test case 2: Sibling traversal -->
- <div class="upload-group">
- <div class="left-section">
- <button class="sibling-button">Choose File</button>
- </div>
- <div class="right-section">
- <input type="file" id="sibling-file">
- </div>
- </div>
-
- <!-- Test case 3: Parent traversal -->
- <div class="outer-container">
- <input type="file" id="parent-file" style="display: none;">
- <div class="inner-container">
- <button class="parent-button">Select</button>
- </div>
- </div>
-
- <!-- Test case 4: Mixed case HTML -->
- <FORM>
- <INPUT TYPE="FILE" ID="mixed-case-file">
- <BUTTON TYPE="button" CLASS="mixed-button">Upload</BUTTON>
- </FORM>
- </body>
- </html>
- """
-
- test_server.expect_request('/traversal').respond_with_data(html, content_type='text/html')
- await browser_session.start()
- # Navigate to traversal page using event
- from browser_use.browser.events import NavigateToUrlEvent, NavigationCompleteEvent
-
- event = browser_session.event_bus.dispatch(NavigateToUrlEvent(url=test_server.url_for('/traversal')))
- await event
- # Wait for page to load
- await browser_session.event_bus.expect(NavigationCompleteEvent, timeout=10.0)
-
- # Get browser state to populate selector map
- await browser_session.get_browser_state_summary(cache_clickable_elements_hashes=False)
-
- selector_map = await browser_session.get_selector_map()
-
- # Test that buttons can find nearby file inputs
- button_count = 0
- buttons_that_found_file = 0
-
- for idx, elem in selector_map.items():
- if elem.tag_name == 'button':
- button_count += 1
- file_input = await browser_session.find_file_upload_element_by_index(idx)
- if file_input is not None:
- buttons_that_found_file += 1
- # Verify it's actually a file input
- assert file_input.tag_name == 'input'
- assert file_input.attributes.get('type', '').lower() == 'file'
-
- # Most buttons should be able to find a file input through DOM traversal
- assert button_count > 0, 'No buttons found in selector map'
- assert buttons_that_found_file > 0, 'No buttons could find file inputs'
- assert buttons_that_found_file >= button_count - 1, 'Most buttons should find file inputs'
-
- @pytest.mark.skip(reason='TODO: fix')
- async def test_traversal_limits(self, browser_session: BrowserSession, test_server: HTTPServer):
- """Test that traversal limits (max_height and max_descendant_depth) work correctly."""
- html = """
- <!DOCTYPE html>
- <html>
- <body>
- <!-- Deep nesting to test limits -->
- <div class="wrapper">
- <button class="test-button">Test Button</button>
- <div>
- <div>
- <div>
- <div>
- <div>
- <input type="file" id="deeply-nested">
- </div>
- </div>
- </div>
- </div>
- </div>
- </div>
-
- <!-- Direct sibling -->
- <div class="direct-wrapper">
- <button class="direct-button">Direct Button</button>
- <input type="file" id="direct-file">
- </div>
-
- <!-- Test with element that is itself a file input -->
- <input type="file" id="self-file" class="clickable">
- </body>
- </html>
- """
-
- test_server.expect_request('/limits').respond_with_data(html, content_type='text/html')
- await browser_session.start()
- # Navigate to limits page using event
- from browser_use.browser.events import NavigateToUrlEvent, NavigationCompleteEvent
-
- event = browser_session.event_bus.dispatch(NavigateToUrlEvent(url=test_server.url_for('/limits')))
- await event
- # Wait for page to load
- await browser_session.event_bus.expect(NavigationCompleteEvent, timeout=10.0)
-
- # Get browser state to populate selector map
- await browser_session.get_browser_state_summary(cache_clickable_elements_hashes=False)
-
- selector_map = await browser_session.get_selector_map()
-
- # Test 1: Button with deep nesting
- test_button_idx = None
- for idx, elem in selector_map.items():
- if elem.tag_name == 'button' and elem.attributes.get('class') == 'test-button':
- test_button_idx = idx
- break
-
- if test_button_idx is not None:
- # With default limits, should find the deeply nested file
- file_input = await browser_session.find_file_upload_element_by_index(test_button_idx)
- assert file_input is not None
-
- # With very limited traversal, might not find it
- file_input_limited = await browser_session.find_file_upload_element_by_index(test_button_idx)
- # Could be None if file is too deep
-
- # Test 2: Direct sibling should be found easily
- direct_button_idx = None
- for idx, elem in selector_map.items():
- if elem.tag_name == 'button' and elem.attributes.get('class') == 'direct-button':
- direct_button_idx = idx
- break
-
- if direct_button_idx is not None:
- file_input = await browser_session.find_file_upload_element_by_index(direct_button_idx)
- assert file_input is not None
- assert file_input.attributes.get('id') == 'direct-file'
-
- # Test 3: Element that is itself a file input
- self_file_idx = None
- for idx, elem in selector_map.items():
- if elem.tag_name == 'input' and elem.attributes.get('id') == 'self-file':
- self_file_idx = idx
- break
-
- if self_file_idx is not None:
- file_input = await browser_session.find_file_upload_element_by_index(self_file_idx)
- assert file_input is not None
- assert file_input.attributes.get('id') == 'self-file'
-
- # Test 4: Invalid index returns None
- invalid_index = max(selector_map.keys()) + 100 if selector_map else 999
- file_input = await browser_session.find_file_upload_element_by_index(invalid_index)
- assert file_input is None
diff --git a/tests/ci/test_browser_session_output_paths.py b/tests/ci/test_browser_session_output_paths.py
index e384900fa..138ff366c 100644
--- a/tests/ci/test_browser_session_output_paths.py
+++ b/tests/ci/test_browser_session_output_paths.py
@@ -303,7 +303,7 @@ class TestBrowserProfileRecordings:
user_data_dir=str(user_data_dir),
record_video_dir=str(video_dir), # Enable video recording
),
- browser_pid=browser_session1.browser_pid, # Connect to existing browser
+ # Connect to existing browser - browser_pid parameter removed
)
await browser_session2.start()
diff --git a/tests/ci/test_browser_session_proxy.py b/tests/ci/test_browser_session_proxy.py
index cf4396d45..9445114ae 100644
--- a/tests/ci/test_browser_session_proxy.py
+++ b/tests/ci/test_browser_session_proxy.py
@@ -4,6 +4,7 @@ from typing import Any
import pytest
from browser_use.browser import BrowserProfile, BrowserSession
+from browser_use.browser.profile import ProxySettings
from browser_use.config import CONFIG
@@ -11,10 +12,10 @@ def test_chromium_args_include_proxy_flags():
profile = BrowserProfile(
headless=True,
user_data_dir=str(CONFIG.BROWSER_USE_PROFILES_DIR / 'proxy-smoke'),
- proxy={
- 'server': 'http://proxy.local:8080',
- 'bypass': 'localhost,127.0.0.1',
- },
+ proxy=ProxySettings(
+ server='http://proxy.local:8080',
+ bypass='localhost,127.0.0.1',
+ ),
)
args = profile.get_args()
assert any(a == '--proxy-server=http://proxy.local:8080' for a in args), args
@@ -27,7 +28,7 @@ async def test_cdp_proxy_auth_handler_registers_and_responds():
profile = BrowserProfile(
headless=True,
user_data_dir=str(CONFIG.BROWSER_USE_PROFILES_DIR / 'proxy-smoke'),
- proxy={'username': 'user', 'password': 'pass'},
+ proxy=ProxySettings(username='user', password='pass'),
)
session = BrowserSession(browser_profile=profile)
diff --git a/tests/ci/test_browser_session_recent_events.py b/tests/ci/test_browser_session_recent_events.py
index c5ddd1400..d9d331d8b 100644
--- a/tests/ci/test_browser_session_recent_events.py
+++ b/tests/ci/test_browser_session_recent_events.py
@@ -57,11 +57,10 @@ class TestBrowserRecentEvents:
browser_session = BrowserSession(
browser_profile=BrowserProfile(
headless=True,
- user_data_dir=None,
- keep_alive=False,
- maximum_wait_page_load_time=1.0, # 1 second max wait
- wait_for_network_idle_page_load_time=0.1, # 100ms idle time
- minimum_wait_page_load_time=0.1, # Don't wait extra
+ user_data_dir=None,
+ keep_alive=False,
+ wait_for_network_idle_page_load_time=0.1, # 100ms idle time
+ minimum_wait_page_load_time=0.1, # Don't wait extra
)
)
@@ -134,9 +133,8 @@ class TestBrowserRecentEvents:
browser_session = BrowserSession(
browser_profile=BrowserProfile(
headless=True,
- user_data_dir=None,
- keep_alive=False,
- maximum_wait_page_load_time=5.0, # Generous timeout
+ user_data_dir=None,
+ keep_alive=False,
)
)
@@ -199,9 +197,8 @@ class TestBrowserRecentEvents:
browser_session = BrowserSession(
browser_profile=BrowserProfile(
headless=True,
- user_data_dir=None,
- keep_alive=False,
- maximum_wait_page_load_time=0.5, # Short timeout for first page
+ user_data_dir=None,
+ keep_alive=False,
)
)
@@ -266,9 +263,8 @@ class TestBrowserRecentEvents:
browser_session = BrowserSession(
browser_profile=BrowserProfile(
headless=True,
- user_data_dir=None,
- keep_alive=False,
- maximum_wait_page_load_time=0.5, # Short timeout
+ user_data_dir=None,
+ keep_alive=False,
)
)
@@ -317,11 +313,10 @@ class TestBrowserRecentEvents:
browser_session = BrowserSession(
browser_profile=BrowserProfile(
headless=True,
- user_data_dir=None,
- keep_alive=False,
- maximum_wait_page_load_time=timeout_seconds,
- wait_for_network_idle_page_load_time=0.1,
- minimum_wait_page_load_time=0.1,
+ user_data_dir=None,
+ keep_alive=False,
+ wait_for_network_idle_page_load_time=0.1,
+ minimum_wait_page_load_time=0.1,
)
)
diff --git a/tests/ci/test_browser_session_via_cdp_tab_management.py b/tests/ci/test_browser_session_via_cdp_tab_management.py
index 14c019e8b..378c73a90 100644
--- a/tests/ci/test_browser_session_via_cdp_tab_management.py
+++ b/tests/ci/test_browser_session_via_cdp_tab_management.py
@@ -5,7 +5,7 @@ import asyncio
import pytest
from browser_use.browser.events import NavigateToUrlEvent, TabCreatedEvent
-from browser_use.browser.profile import BrowserProfile
+from browser_use.browser.profile import BrowserProfile, ViewportSize
from browser_use.browser.session import BrowserSession
@@ -30,7 +30,7 @@ async def httpserver_url(httpserver):
@pytest.mark.skip(reason='TODO: fix')
async def test_new_tab_cdp_session_attachment(httpserver_url):
"""Test that CDP session is properly attached when creating new tabs."""
- browser = BrowserSession(browser_profile=BrowserProfile(headless=True, viewport={'width': 800, 'height': 600}))
+ browser = BrowserSession(browser_profile=BrowserProfile(headless=True, viewport=ViewportSize(width=800, height=600)))
tab_created_events = []
@@ -89,7 +89,7 @@ async def test_new_tab_cdp_session_attachment(httpserver_url):
async def test_multiple_new_tabs_cdp_session(httpserver_url):
"""Test creating multiple new tabs in succession."""
- browser = BrowserSession(browser_profile=BrowserProfile(headless=True, viewport={'width': 800, 'height': 600}))
+ browser = BrowserSession(browser_profile=BrowserProfile(headless=True, viewport=ViewportSize(width=800, height=600)))
try:
await browser.start()
diff --git a/tests/ci/test_browser_session_viewport_and_proxy.py b/tests/ci/test_browser_session_viewport_and_proxy.py
index 125c7a94f..7dcee9e71 100644
--- a/tests/ci/test_browser_session_viewport_and_proxy.py
+++ b/tests/ci/test_browser_session_viewport_and_proxy.py
@@ -3,7 +3,7 @@ import pytest
pytest.skip('TODO: fix - import error for ProxySettings', allow_module_level=True)
from browser_use.browser import BrowserSession
-from browser_use.browser.profile import BrowserProfile, ProxySettings
+from browser_use.browser.profile import BrowserProfile, ProxySettings, ViewportSize
async def test_proxy_settings_pydantic_model():
@@ -40,8 +40,7 @@ async def test_window_size_with_real_browser():
browser_profile=BrowserProfile(
user_data_dir=None,
headless=True, # window size gets converted to viewport size in headless mode
- window_size={'width': 999, 'height': 888},
- maximum_wait_page_load_time=2.0,
+ window_size=ViewportSize(width=999, height=888),
minimum_wait_page_load_time=0.2,
)
)