Skip to content

Open-source Python library for AI browser agents, plus Browser Use Cloud: stealth browsers and a hosted agent API.

refactor: streamline logging and remove redundant timing checks

reformedoteb63257eee6e
diff --git a/browser_use/browser/session.py b/browser_use/browser/session.py
index d9fc6b8ec..073584cfe 100644
--- a/browser_use/browser/session.py
+++ b/browser_use/browser/session.py
@@ -815,11 +815,7 @@ class BrowserSession(BaseModel):
NO handler registration here - handlers are registered ONCE per session in SessionManager.
We poll stored events instead to avoid handler accumulation.
"""
- # Performance tracking
- t0 = asyncio.get_event_loop().time()
-
cdp_session = await self.get_or_create_cdp_session(target_id, focus=False)
- t1 = asyncio.get_event_loop().time()
if timeout is None:
current_url = cdp_session.url
@@ -830,15 +826,13 @@ class BrowserSession(BaseModel):
)
timeout = 2.0 if same_domain else 4.0
- # Start navigation CDP call
+ # Start performance tracking
nav_start_time = asyncio.get_event_loop().time()
- t2 = asyncio.get_event_loop().time()
nav_result = await cdp_session.cdp_client.send.Page.navigate(
params={'url': url, 'transitionType': 'address_bar'},
session_id=cdp_session.session_id,
)
- t3 = asyncio.get_event_loop().time()
# Check for immediate navigation errors
if nav_result.get('errorText'):
@@ -879,21 +873,13 @@ class BrowserSession(BaseModel):
continue
if event_name == 'networkIdle':
- t4 = asyncio.get_event_loop().time()
- duration_ms = (t4 - t0) * 1000
- self.logger.info(
- f'✅ Page ready for {url} (networkIdle, {duration_ms:.0f}ms) '
- f'[session:{(t1 - t0) * 1000:.0f}ms, cdp:{(t3 - t2) * 1000:.0f}ms, wait:{(t4 - t3) * 1000:.0f}ms]'
- )
+ duration_ms = (asyncio.get_event_loop().time() - nav_start_time) * 1000
+ self.logger.debug(f'✅ Page ready for {url} (networkIdle, {duration_ms:.0f}ms)')
return
elif event_name == 'load':
- t4 = asyncio.get_event_loop().time()
- duration_ms = (t4 - t0) * 1000
- self.logger.info(
- f'✅ Page ready for {url} (load, {duration_ms:.0f}ms) '
- f'[session:{(t1 - t0) * 1000:.0f}ms, cdp:{(t3 - t2) * 1000:.0f}ms, wait:{(t4 - t3) * 1000:.0f}ms]'
- )
+ duration_ms = (asyncio.get_event_loop().time() - nav_start_time) * 1000
+ self.logger.debug(f'✅ Page ready for {url} (load, {duration_ms:.0f}ms)')
return
except Exception as e:
@@ -903,19 +889,14 @@ class BrowserSession(BaseModel):
await asyncio.sleep(poll_interval)
# Timeout - continue anyway with detailed diagnostics
- t4 = asyncio.get_event_loop().time()
- duration_ms = (t4 - t0) * 1000
+ duration_ms = (asyncio.get_event_loop().time() - nav_start_time) * 1000
if not seen_events:
self.logger.error(
f'❌ No lifecycle events received for {url} after {duration_ms:.0f}ms! '
- f'Monitoring may have failed. Target: {cdp_session.target_id[:8]} '
- f'[session:{(t1 - t0) * 1000:.0f}ms, cdp:{(t3 - t2) * 1000:.0f}ms, wait:{(t4 - t3) * 1000:.0f}ms]'
+ f'Monitoring may have failed. Target: {cdp_session.target_id[:8]}'
)
else:
- self.logger.warning(
- f'⚠️ Page readiness timeout ({timeout}s, {duration_ms:.0f}ms) for {url} '
- f'[session:{(t1 - t0) * 1000:.0f}ms, cdp:{(t3 - t2) * 1000:.0f}ms, wait:{(t4 - t3) * 1000:.0f}ms]'
- )
+ self.logger.warning(f'⚠️ Page readiness timeout ({timeout}s, {duration_ms:.0f}ms) for {url}')
async def on_SwitchTabEvent(self, event: SwitchTabEvent) -> TargetID:
"""Handle tab switching - core browser functionality."""
@@ -1005,7 +986,6 @@ class BrowserSession(BaseModel):
async def on_AgentFocusChangedEvent(self, event: AgentFocusChangedEvent) -> None:
"""Handle agent focus change - update focus and clear cache."""
- t0 = asyncio.get_event_loop().time()
self.logger.debug(f'🔄 AgentFocusChangedEvent received: target_id=...{event.target_id[-4:]} url={event.url}')
# Clear cached DOM state since focus changed
@@ -1015,23 +995,15 @@ class BrowserSession(BaseModel):
# Clear cached browser state
self._cached_browser_state_summary = None
self._cached_selector_map.clear()
- t1 = asyncio.get_event_loop().time()
+ self.logger.debug('🔄 Cached browser state cleared')
# Update agent focus if a specific target_id is provided
if event.target_id:
self.agent_focus = await self.get_or_create_cdp_session(target_id=event.target_id, focus=True)
- t2 = asyncio.get_event_loop().time()
+ self.logger.debug(f'🔄 Updated agent focus to tab target_id=...{event.target_id[-4:]}')
else:
raise RuntimeError('AgentFocusChangedEvent received with no target_id for newly focused tab')
- total_ms = (t2 - t0) * 1000
- self.logger.info(
- f'🔄 AgentFocusChangedEvent completed ({total_ms:.0f}ms) '
- f'[clear:{(t1 - t0) * 1000:.0f}ms, session:{(t2 - t1) * 1000:.0f}ms]'
- )
-
- # self.logger.debug('🔄 AgentFocusChangedEvent handler completed successfully')
-
async def on_FileDownloadedEvent(self, event: FileDownloadedEvent) -> None:
"""Track downloaded files during this session."""
self.logger.debug(f'FileDownloadedEvent received: {event.file_name} at {event.path}')
diff --git a/browser_use/browser/watchdogs/downloads_watchdog.py b/browser_use/browser/watchdogs/downloads_watchdog.py
index 9ff2da616..0e8038a14 100644
--- a/browser_use/browser/watchdogs/downloads_watchdog.py
+++ b/browser_use/browser/watchdogs/downloads_watchdog.py
@@ -135,7 +135,6 @@ class DownloadsWatchdog(BaseWatchdog):
async def on_NavigationCompleteEvent(self, event: NavigationCompleteEvent) -> None:
"""Check for PDFs after navigation completes."""
- t0 = asyncio.get_event_loop().time()
self.logger.debug(f'[DownloadsWatchdog] NavigationCompleteEvent received for {event.url}, tab #{event.target_id[-4:]}')
# Clear PDF cache for the navigated URL since content may have changed
@@ -152,24 +151,13 @@ class DownloadsWatchdog(BaseWatchdog):
target_id = event.target_id
self.logger.debug(f'[DownloadsWatchdog] Got target_id={target_id} for tab #{event.target_id[-4:]}')
- t1 = asyncio.get_event_loop().time()
is_pdf = await self.check_for_pdf_viewer(target_id)
- t2 = asyncio.get_event_loop().time()
if is_pdf:
self.logger.debug(f'[DownloadsWatchdog] 📄 PDF detected at {event.url}, triggering auto-download...')
download_path = await self.trigger_pdf_download(target_id)
- t3 = asyncio.get_event_loop().time()
if not download_path:
self.logger.warning(f'[DownloadsWatchdog] ⚠️ PDF download failed for {event.url}')
- else:
- t3 = t2
-
- total_ms = (t3 - t0) * 1000
- self.logger.info(
- f'[DownloadsWatchdog] NavigationCompleteEvent completed ({total_ms:.0f}ms) '
- f'[check_pdf:{(t2 - t1) * 1000:.0f}ms, download:{(t3 - t2) * 1000:.0f}ms]'
- )
def _is_auto_download_enabled(self) -> bool:
"""Check if auto-download PDFs is enabled in browser profile."""
@@ -956,7 +944,6 @@ class DownloadsWatchdog(BaseWatchdog):
"""
self.logger.debug(f'[DownloadsWatchdog] Checking if target {target_id} is PDF viewer...')
- # Get URL from session (zero CDP calls!)
session = await self.browser_session._session_manager.get_session_for_target(target_id)
if not session:
self.logger.warning(f'[DownloadsWatchdog] No session found for {target_id}')
@@ -977,15 +964,6 @@ class DownloadsWatchdog(BaseWatchdog):
self.logger.debug(f'[DownloadsWatchdog] PDF detected via URL pattern: {page_url}')
self._pdf_viewer_cache[page_url] = True
return True
-
- # Method 2: Check network response headers via CDP (safer than JavaScript)
- header_is_pdf = await self._check_network_headers_for_pdf(target_id)
- if header_is_pdf:
- self.logger.debug(f'[DownloadsWatchdog] PDF detected via network headers: {page_url}')
- self._pdf_viewer_cache[page_url] = True
- return True
-
- # Method 3: Check Chrome's PDF viewer specific URLs
chrome_pdf_viewer = self._is_chrome_pdf_viewer_url(page_url)
if chrome_pdf_viewer:
self.logger.debug(f'[DownloadsWatchdog] Chrome PDF viewer detected: {page_url}')
diff --git a/browser_use/browser/watchdogs/security_watchdog.py b/browser_use/browser/watchdogs/security_watchdog.py
index e1ce08788..343ab947e 100644
--- a/browser_use/browser/watchdogs/security_watchdog.py
+++ b/browser_use/browser/watchdogs/security_watchdog.py
@@ -49,9 +49,6 @@ class SecurityWatchdog(BaseWatchdog):
async def on_NavigationCompleteEvent(self, event: NavigationCompleteEvent) -> None:
"""Check if navigated URL is allowed (catches redirects to blocked domains)."""
- import asyncio
- t0 = asyncio.get_event_loop().time()
-
# Check if the navigated URL is allowed (in case of redirects)
if not self._is_url_allowed(event.url):
self.logger.warning(f'⛔️ Navigation to non-allowed URL detected: {event.url}')
@@ -73,9 +70,6 @@ class SecurityWatchdog(BaseWatchdog):
except Exception as e:
pass
self.logger.error(f'⛔️ Failed to navigate to about:blank: {type(e).__name__} {e}')
-
- total_ms = (asyncio.get_event_loop().time() - t0) * 1000
- self.logger.info(f'[SecurityWatchdog] NavigationCompleteEvent completed ({total_ms:.0f}ms)')
async def on_TabCreatedEvent(self, event: TabCreatedEvent) -> None:
"""Check if new tab URL is allowed."""