Skip to content

Open-source Python library for AI browser agents, plus Browser Use Cloud: stealth browsers and a hosted agent API.

fix(dom): allow compact cross-origin controls safely

MagMuellerffe93c190ad8
diff --git a/browser_use/dom/service.py b/browser_use/dom/service.py
index f8858e669..e860e99b9 100644
--- a/browser_use/dom/service.py
+++ b/browser_use/dom/service.py
@@ -1,6 +1,7 @@
import asyncio
import logging
import time
+from dataclasses import dataclass, field
from typing import TYPE_CHECKING, Any
from cdp_use.cdp.accessibility.commands import GetFullAXTreeReturns
@@ -34,12 +35,14 @@ if TYPE_CHECKING:
_MAX_JS_CLICK_LISTENER_ELEMENTS = 100
_DESCRIBE_NODE_BATCH_SIZE = 20
_JS_CLICK_LISTENER_OVERFLOW = '__browser_use_too_many_click_listeners__'
-_MIN_CROSS_ORIGIN_IFRAME_AREA = 50 * 50
+_PREVIOUS_MIN_CROSS_ORIGIN_IFRAME_AREA = 50 * 50
+_MIN_CROSS_ORIGIN_IFRAME_AREA = 10 * 10
_MIN_CROSS_ORIGIN_IFRAME_EDGE = 10
+_MAX_COMPACT_CROSS_ORIGIN_IFRAMES = 10
def _is_cross_origin_iframe_size_eligible(width: float, height: float) -> bool:
- """Keep tiny tracking frames out while allowing input-shaped hosted fields."""
+ """Keep pixel-sized beacons out while allowing compact embedded controls."""
return (
width >= _MIN_CROSS_ORIGIN_IFRAME_EDGE
and height >= _MIN_CROSS_ORIGIN_IFRAME_EDGE
@@ -47,6 +50,29 @@ def _is_cross_origin_iframe_size_eligible(width: float, height: float) -> bool:
)
+@dataclass
+class _CrossOriginIframeTraversalContext:
+ """Bound recursive OOPIF traversal across the complete stitched DOM capture."""
+
+ max_targets: int
+ max_compact_targets: int
+ visited_target_ids: set[TargetID] = field(default_factory=set)
+ traversed_target_count: int = 0
+ traversed_compact_target_count: int = 0
+
+ def try_visit(self, target_id: TargetID, *, is_compact: bool) -> bool:
+ """Reserve one unique child target without exceeding the configured budget."""
+ if target_id in self.visited_target_ids or self.traversed_target_count >= self.max_targets:
+ return False
+ if is_compact and self.traversed_compact_target_count >= self.max_compact_targets:
+ return False
+ self.visited_target_ids.add(target_id)
+ self.traversed_target_count += 1
+ if is_compact:
+ self.traversed_compact_target_count += 1
+ return True
+
+
class DomService:
"""
Service for getting the DOM tree and other DOM-related information.
@@ -712,6 +738,7 @@ class DomService:
initial_html_frames: list[EnhancedDOMTreeNode] | None = None,
initial_total_frame_offset: DOMRect | None = None,
iframe_depth: int = 0,
+ cross_origin_traversal: _CrossOriginIframeTraversalContext | None = None,
) -> tuple[EnhancedDOMTreeNode, dict[str, float]]:
"""Get the DOM tree for a specific target.
@@ -721,10 +748,18 @@ class DomService:
initial_html_frames: List of HTML frame nodes encountered so far
initial_total_frame_offset: Accumulated coordinate offset
iframe_depth: Current depth of iframe nesting to prevent infinite recursion
+ cross_origin_traversal: Shared recursive OOPIF target budget and cycle guard
Returns:
Tuple of (enhanced_dom_tree_node, timing_info)
"""
+ if cross_origin_traversal is None:
+ cross_origin_traversal = _CrossOriginIframeTraversalContext(
+ max_targets=self.max_iframes,
+ max_compact_targets=min(self.max_iframes, _MAX_COMPACT_CROSS_ORIGIN_IFRAMES),
+ visited_target_ids={target_id},
+ )
+
timing_info: dict[str, float] = {}
timing_start_total = time.time()
@@ -973,6 +1008,7 @@ class DomService:
# Use area rather than requiring both edges to be >= 50px: hosted payment fields
# are commonly wide but only ~40px tall.
should_process_iframe = False
+ is_compact_cross_origin_iframe = False
# First check if the iframe element itself is visible
if dom_tree_node.is_visible:
@@ -984,6 +1020,7 @@ class DomService:
if _is_cross_origin_iframe_size_eligible(width, height):
should_process_iframe = True
+ is_compact_cross_origin_iframe = width * height < _PREVIOUS_MIN_CROSS_ORIGIN_IFRAME_AREA
self.logger.debug(f'Processing cross-origin iframe: visible=True, width={width}, height={height}')
else:
self.logger.debug(
@@ -1039,21 +1076,33 @@ class DomService:
# if target actually exists in one of the frames, just recursively build the dom tree for it
if iframe_document_target:
- self.logger.debug(
- f'Getting content document for iframe {node.get("frameId", None)} at depth {iframe_depth + 1}'
- )
- try:
- content_document, _ = await self.get_dom_tree(
- target_id=iframe_document_target['targetId'],
- all_frames=all_frames,
- # Current config: if the cross origin iframe is AT ALL visible, include everything inside it
- initial_total_frame_offset=total_frame_offset,
- iframe_depth=iframe_depth + 1,
+ if not cross_origin_traversal.try_visit(
+ iframe_document_target['targetId'],
+ is_compact=is_compact_cross_origin_iframe,
+ ):
+ self.logger.debug(
+ f'Skipping already visited or over-budget cross-origin iframe target '
+ f'{iframe_document_target["targetId"]} '
+ f'(max targets: {cross_origin_traversal.max_targets}, '
+ f'max compact targets: {cross_origin_traversal.max_compact_targets})'
+ )
+ else:
+ self.logger.debug(
+ f'Getting content document for iframe {node.get("frameId", None)} at depth {iframe_depth + 1}'
)
- dom_tree_node.content_document = content_document
- dom_tree_node.content_document.parent_node = dom_tree_node
- except Exception as e:
- self.logger.debug(f'Failed to get DOM tree for cross-origin iframe {frame_id}: {e}')
+ try:
+ content_document, _ = await self.get_dom_tree(
+ target_id=iframe_document_target['targetId'],
+ all_frames=all_frames,
+ # Current config: if the cross origin iframe is AT ALL visible, include everything inside it
+ initial_total_frame_offset=total_frame_offset,
+ iframe_depth=iframe_depth + 1,
+ cross_origin_traversal=cross_origin_traversal,
+ )
+ dom_tree_node.content_document = content_document
+ dom_tree_node.content_document.parent_node = dom_tree_node
+ except Exception as e:
+ self.logger.debug(f'Failed to get DOM tree for cross-origin iframe {frame_id}: {e}')
return dom_tree_node
diff --git a/tests/ci/test_dom_visibility.py b/tests/ci/test_dom_visibility.py
index c7e3d48b1..b26c0dd95 100644
--- a/tests/ci/test_dom_visibility.py
+++ b/tests/ci/test_dom_visibility.py
@@ -6,7 +6,11 @@ node must not be transformed by its own bounds when it appears in its own
frame chain (as built by _construct_enhanced_node).
"""
-from browser_use.dom.service import DomService, _is_cross_origin_iframe_size_eligible
+from browser_use.dom.service import (
+ DomService,
+ _CrossOriginIframeTraversalContext,
+ _is_cross_origin_iframe_size_eligible,
+)
from browser_use.dom.views import DOMRect, EnhancedDOMTreeNode, EnhancedSnapshotNode, NodeType
@@ -113,9 +117,41 @@ class TestCrossOriginIframeSizeEligibility:
assert _is_cross_origin_iframe_size_eligible(width=90, height=40) is True
def test_rejects_tiny_tracking_frame(self):
- """Area alone must not admit a one-pixel tracking iframe."""
+ """Pixel-sized web beacons and one-pixel strips must stay excluded."""
+ assert _is_cross_origin_iframe_size_eligible(width=1, height=1) is False
assert _is_cross_origin_iframe_size_eligible(width=1, height=2500) is False
- def test_preserves_previous_minimum_area(self):
- assert _is_cross_origin_iframe_size_eligible(width=50, height=50) is True
- assert _is_cross_origin_iframe_size_eligible(width=49, height=49) is False
+ def test_accepts_native_checkbox_sized_frame(self):
+ """Chromium renders an unstyled native checkbox at roughly 13x13 CSS pixels."""
+ assert _is_cross_origin_iframe_size_eligible(width=13, height=13) is True
+
+ def test_rejects_frames_below_the_minimum_edge(self):
+ assert _is_cross_origin_iframe_size_eligible(width=9, height=100) is False
+ assert _is_cross_origin_iframe_size_eligible(width=100, height=9) is False
+
+
+class TestCrossOriginIframeTraversalContext:
+ def test_caps_unique_recursive_targets_globally(self):
+ context = _CrossOriginIframeTraversalContext(max_targets=2, max_compact_targets=2, visited_target_ids={'root'})
+
+ assert context.try_visit('child-1', is_compact=False) is True
+ assert context.try_visit('child-2', is_compact=False) is True
+ assert context.try_visit('child-3', is_compact=False) is False
+ assert context.traversed_target_count == 2
+
+ def test_rejects_duplicate_targets_without_spending_budget(self):
+ context = _CrossOriginIframeTraversalContext(max_targets=2, max_compact_targets=2, visited_target_ids={'root'})
+
+ assert context.try_visit('child-1', is_compact=False) is True
+ assert context.try_visit('child-1', is_compact=False) is False
+ assert context.try_visit('child-2', is_compact=False) is True
+ assert context.traversed_target_count == 2
+
+ def test_compact_target_budget_does_not_block_larger_frames(self):
+ context = _CrossOriginIframeTraversalContext(max_targets=4, max_compact_targets=1, visited_target_ids={'root'})
+
+ assert context.try_visit('compact-1', is_compact=True) is True
+ assert context.try_visit('compact-2', is_compact=True) is False
+ assert context.try_visit('large-1', is_compact=False) is True
+ assert context.traversed_compact_target_count == 1
+ assert context.traversed_target_count == 2