Skip to content

Lightpanda: the headless browser designed for AI and automation

webapi: remove touch events

Karl Seguin09ffaa60957f
diff --git a/src/browser/tests/window/global_event_handlers.html b/src/browser/tests/window/global_event_handlers.html
index 806c632e1..b954104c1 100644
--- a/src/browser/tests/window/global_event_handlers.html
+++ b/src/browser/tests/window/global_event_handlers.html
@@ -7,11 +7,10 @@
{
// Window and Document include GlobalEventHandlers, like HTMLElement.
// Window leaves out the DocumentAndElementEventHandlers (copy, cut, paste),
- // the fullscreen handlers (Element and Document only) and the touch ones.
+ // and the fullscreen handlers (Element and Document only).
const notOnWindow = [
'oncopy', 'oncut', 'onpaste',
'onfullscreenchange', 'onfullscreenerror',
- 'ontouchcancel', 'ontouchend', 'ontouchmove', 'ontouchstart',
];
const names = Object.getOwnPropertyNames(HTMLElement.prototype)
.filter((n) => n.startsWith('on'));
@@ -32,6 +31,25 @@
testing.expectEqual(true, 'onsubmit' in document);
</script>
+<script id=noTouchHandlers>
+{
+ // As desktop Chrome without a touch screen: pages read
+ // 'ontouchstart' in document.documentElement to detect a touch device.
+ const names = ['ontouchcancel', 'ontouchend', 'ontouchmove', 'ontouchstart'];
+ for (const n of names) {
+ testing.expectEqual([false, false, false], [n in window, n in document, n in document.documentElement]);
+ }
+
+ // the content attribute isn't a handler either, but listeners still run
+ window.seenTouch = [];
+ const div = document.createElement('div');
+ div.setAttribute('ontouchstart', 'seenTouch.push("attr")');
+ div.addEventListener('touchstart', () => seenTouch.push('listener'));
+ div.dispatchEvent(new TouchEvent('touchstart'));
+ testing.expectEqual(['listener'], seenTouch);
+}
+</script>
+
<script id=handlersRunForBubblingEvents>
{
const seen = [];
diff --git a/src/browser/webapi/Document.zig b/src/browser/webapi/Document.zig
index 7026c16b8..a859f677c 100644
--- a/src/browser/webapi/Document.zig
+++ b/src/browser/webapi/Document.zig
@@ -1788,10 +1788,6 @@ pub const JsApi = struct {
pub const onsuspend = EventTarget.handlerAccessor(Document, "suspend");
pub const ontimeupdate = EventTarget.handlerAccessor(Document, "timeupdate");
pub const ontoggle = EventTarget.handlerAccessor(Document, "toggle");
- pub const ontouchcancel = EventTarget.handlerAccessor(Document, "touchcancel");
- pub const ontouchend = EventTarget.handlerAccessor(Document, "touchend");
- pub const ontouchmove = EventTarget.handlerAccessor(Document, "touchmove");
- pub const ontouchstart = EventTarget.handlerAccessor(Document, "touchstart");
pub const ontransitioncancel = EventTarget.handlerAccessor(Document, "transitioncancel");
pub const ontransitionend = EventTarget.handlerAccessor(Document, "transitionend");
pub const ontransitionrun = EventTarget.handlerAccessor(Document, "transitionrun");
diff --git a/src/browser/webapi/element/Html.zig b/src/browser/webapi/element/Html.zig
index 90efdc4f9..243ff45fe 100644
--- a/src/browser/webapi/element/Html.zig
+++ b/src/browser/webapi/element/Html.zig
@@ -1236,10 +1236,6 @@ pub const JsApi = struct {
pub const onsuspend = EventTarget.handlerAccessor(HtmlElement, "suspend");
pub const ontimeupdate = EventTarget.handlerAccessor(HtmlElement, "timeupdate");
pub const ontoggle = EventTarget.handlerAccessor(HtmlElement, "toggle");
- pub const ontouchcancel = EventTarget.handlerAccessor(HtmlElement, "touchcancel");
- pub const ontouchend = EventTarget.handlerAccessor(HtmlElement, "touchend");
- pub const ontouchmove = EventTarget.handlerAccessor(HtmlElement, "touchmove");
- pub const ontouchstart = EventTarget.handlerAccessor(HtmlElement, "touchstart");
pub const ontransitioncancel = EventTarget.handlerAccessor(HtmlElement, "transitioncancel");
pub const ontransitionend = EventTarget.handlerAccessor(HtmlElement, "transitionend");
pub const ontransitionrun = EventTarget.handlerAccessor(HtmlElement, "transitionrun");
diff --git a/src/browser/webapi/global_event_handlers.zig b/src/browser/webapi/global_event_handlers.zig
index d04f96d10..2bb184dbe 100644
--- a/src/browser/webapi/global_event_handlers.zig
+++ b/src/browser/webapi/global_event_handlers.zig
@@ -108,10 +108,6 @@ pub const Handler = enum {
onsuspend,
ontimeupdate,
ontoggle,
- ontouchcancel,
- ontouchend,
- ontouchmove,
- ontouchstart,
ontransitioncancel,
ontransitionend,
ontransitionrun,