Skip to content

Lightpanda: the headless browser designed for AI and automation

fix copyright date, improve js parameter mapping

Karl Seguin10c6f553c8dc
diff --git a/src/browser/tests/streams/readable_stream.html b/src/browser/tests/streams/readable_stream.html
index 47582dec8..8a98cd0fa 100644
--- a/src/browser/tests/streams/readable_stream.html
+++ b/src/browser/tests/streams/readable_stream.html
@@ -383,9 +383,17 @@
testing.expectEqual(1024, bytes.highWaterMark);
testing.expectEqual(4, bytes.size(new Uint8Array(4)));
testing.expectEqual(8, bytes.size(new ArrayBuffer(8)));
- testing.expectError('TypeError', () => bytes.size(7));
+ testing.expectEqual(undefined, bytes.size({}));
+ testing.expectEqual(undefined, bytes.size(7));
+ testing.expectError('TypeError', () => bytes.size(null));
+ testing.expectError('TypeError', () => bytes.size());
- const stream = new ReadableStream({}, count);
+ testing.expectError('TypeError', () => new CountQueuingStrategy());
+ testing.expectError('TypeError', () => new ByteLengthQueuingStrategy({}));
+
+ let desired;
+ const stream = new ReadableStream({ start(c) { desired = c.desiredSize; } }, count);
+ testing.expectEqual(3, desired);
testing.expectEqual('function', typeof stream.getReader);
}
</script>
diff --git a/src/browser/webapi/streams/ByteLengthQueuingStrategy.zig b/src/browser/webapi/streams/ByteLengthQueuingStrategy.zig
index d602b60a0..d013e329f 100644
--- a/src/browser/webapi/streams/ByteLengthQueuingStrategy.zig
+++ b/src/browser/webapi/streams/ByteLengthQueuingStrategy.zig
@@ -1,4 +1,4 @@
-// Copyright (C) 2023-2025 Lightpanda (Selecy SAS)
+// Copyright (C) 2023-2026 Lightpanda (Selecy SAS)
//
// Francis Bouvier <[email protected]>
// Pierre Tachoire <[email protected]>
@@ -36,12 +36,18 @@ pub fn getHighWaterMark(self: *const ByteLengthQueuingStrategy) f64 {
return self._high_water_mark;
}
-pub fn size(_: *const ByteLengthQueuingStrategy, chunk: js.Value) !f64 {
- if (!chunk.isObject()) {
- return error.TypeError;
- }
- const sized = try chunk.toObject().toZig(struct { byteLength: f64 });
- return sized.byteLength;
+// GetV(chunk, "byteLength"): objects report their byteLength (or undefined
+// without one), other primitives have no such property, null/undefined throw.
+const Chunk = union(enum) {
+ sized: struct { byteLength: ?f64 },
+ other: js.Value,
+};
+
+pub fn size(_: *const ByteLengthQueuingStrategy, chunk: Chunk) !?f64 {
+ return switch (chunk) {
+ .sized => |sized| sized.byteLength,
+ .other => |value| if (value.isNullOrUndefined()) error.TypeError else null,
+ };
}
pub const JsApi = struct {
@@ -55,5 +61,5 @@ pub const JsApi = struct {
pub const constructor = bridge.constructor(ByteLengthQueuingStrategy.init, .{});
pub const highWaterMark = bridge.accessor(ByteLengthQueuingStrategy.getHighWaterMark, null, .{});
- pub const size = bridge.function(ByteLengthQueuingStrategy.size, .{});
+ pub const size = bridge.function(ByteLengthQueuingStrategy.size, .{ .null_as_undefined = true });
};
diff --git a/src/browser/webapi/streams/CountQueuingStrategy.zig b/src/browser/webapi/streams/CountQueuingStrategy.zig
index 0fe4e8ad8..8cbbcc6db 100644
--- a/src/browser/webapi/streams/CountQueuingStrategy.zig
+++ b/src/browser/webapi/streams/CountQueuingStrategy.zig
@@ -1,4 +1,4 @@
-// Copyright (C) 2023-2025 Lightpanda (Selecy SAS)
+// Copyright (C) 2023-2026 Lightpanda (Selecy SAS)
//
// Francis Bouvier <[email protected]>
// Pierre Tachoire <[email protected]>