Lightpanda: the headless browser designed for AI and automation
webapi: floor MouseEvent coordinate getters to integers, Chrome-style
Navid EMAD110d0076a4ec
diff --git a/src/browser/tests/event/drag.html b/src/browser/tests/event/drag.htmlindex db3ddaa0c..200912971 100644--- a/src/browser/tests/event/drag.html+++ b/src/browser/tests/event/drag.html@@ -18,6 +18,11 @@{const event = new DragEvent('dragover', { clientX: 5, clientY: 9, button: 0 });testing.expectEqual(5, event.clientX);++ // DragEvent floors fractional coordinates like MouseEvent (Chrome parity).+ const fractional = new DragEvent('dragover', { clientX: 47.5, clientY: 312.5 });+ testing.expectEqual(47, fractional.clientX);+ testing.expectEqual(312, fractional.clientY);testing.expectEqual(9, event.clientY);}</script>diff --git a/src/browser/tests/event/mouse.html b/src/browser/tests/event/mouse.htmlindex 5314889b0..6c67b39ac 100644--- a/src/browser/tests/event/mouse.html+++ b/src/browser/tests/event/mouse.html@@ -69,6 +69,25 @@}</script>+<script id=fractionalCoordinatesFloored>+ {+ // Chrome floors MouseEvent coordinate getters to integers — fractional+ // precision is exposed on PointerEvent only, even though CSSOM-View types+ // these as double.+ let evt = new MouseEvent('click', {clientX: 47.5, clientY: 312.5, screenX: -47.5, screenY: 47.6});+ testing.expectEqual(47, evt.clientX);+ testing.expectEqual(312, evt.clientY);+ testing.expectEqual(-48, evt.screenX);+ testing.expectEqual(47, evt.screenY);+ testing.expectEqual(47, evt.pageX);+ testing.expectEqual(312, evt.pageY);+ testing.expectEqual(47, evt.x);+ testing.expectEqual(312, evt.y);+ testing.expectEqual(47, evt.layerX);+ testing.expectEqual(312, evt.layerY);+ }+</script>+<script id=getModifierState>{let evt = new MouseEvent('click', {altKey: true, ctrlKey: true, shiftKey: true, metaKey: true});diff --git a/src/browser/tests/event/pointer.html b/src/browser/tests/event/pointer.htmlindex 931c90f9e..911482ab6 100644--- a/src/browser/tests/event/pointer.html+++ b/src/browser/tests/event/pointer.html@@ -163,3 +163,16 @@testing.expectEqual(true, pe.cancelable);}</script>++<script id=fractionalCoordinatesPreserved>+{+ // Unlike MouseEvent (which floors), PointerEvent keeps fractional+ // coordinates — matching Chrome, where high-precision coordinates shipped+ // on PointerEvent only.+ let evt = new PointerEvent('pointerdown', {clientX: 47.5, clientY: 312.5, screenX: -47.5});+ testing.expectEqual(47.5, evt.clientX);+ testing.expectEqual(312.5, evt.clientY);+ testing.expectEqual(-47.5, evt.screenX);+ testing.expectEqual(47.5, evt.pageX);+}+</script>diff --git a/src/browser/webapi/event/MouseEvent.zig b/src/browser/webapi/event/MouseEvent.zigindex 4269de93c..78dde6579 100644--- a/src/browser/webapi/event/MouseEvent.zig+++ b/src/browser/webapi/event/MouseEvent.zig@@ -156,12 +156,23 @@ pub fn getButtons(self: *const MouseEvent) u16 {return self._buttons;}+// Chrome exposes fractional coordinates on PointerEvent only: MouseEvent and+// its other subclasses floor them to integers for web compatibility, even+// though CSSOM-View types the getters as double.+// https://drafts.csswg.org/cssom-view/#extensions-to-the-mouseevent-interface+fn compatCoordinate(self: *const MouseEvent, value: f64) f64 {+ return switch (self._type) {+ .pointer_event => value,+ else => @floor(value),+ };+}+pub fn getClientX(self: *const MouseEvent) f64 {- return self._client_x;+ return self.compatCoordinate(self._client_x);}pub fn getClientY(self: *const MouseEvent) f64 {- return self._client_y;+ return self.compatCoordinate(self._client_y);}pub fn getCtrlKey(self: *const MouseEvent) bool {@@ -174,12 +185,12 @@ pub fn getMetaKey(self: *const MouseEvent) bool {pub fn getPageX(self: *const MouseEvent) f64 {// this should be clientX + window.scrollX- return self._client_x;+ return self.compatCoordinate(self._client_x);}pub fn getPageY(self: *const MouseEvent) f64 {// this should be clientY + window.scrollY- return self._client_y;+ return self.compatCoordinate(self._client_y);}pub fn getRelatedTarget(self: *const MouseEvent) ?*EventTarget {@@ -187,11 +198,11 @@ pub fn getRelatedTarget(self: *const MouseEvent) ?*EventTarget {}pub fn getScreenX(self: *const MouseEvent) f64 {- return self._screen_x;+ return self.compatCoordinate(self._screen_x);}pub fn getScreenY(self: *const MouseEvent) f64 {- return self._screen_y;+ return self.compatCoordinate(self._screen_y);}pub fn getShiftKey(self: *const MouseEvent) bool {@@ -200,11 +211,11 @@ pub fn getShiftKey(self: *const MouseEvent) bool {// Deprecated: tracks the same value as offsetX/clientX in the absence of layout.pub fn getLayerX(self: *const MouseEvent) f64 {- return self._client_x;+ return self.compatCoordinate(self._client_x);}pub fn getLayerY(self: *const MouseEvent) f64 {- return self._client_y;+ return self.compatCoordinate(self._client_y);}pub fn getModifierState(self: *const MouseEvent, key: []const u8) bool {