Lightpanda: the headless browser designed for AI and automation
handle constructor that disconnect itself
Karl Seguin11630969469f
diff --git a/src/browser/tests/custom_elements/clone_upgrade.html b/src/browser/tests/custom_elements/clone_upgrade.htmlindex e1a789168..09418daa1 100644--- a/src/browser/tests/custom_elements/clone_upgrade.html+++ b/src/browser/tests/custom_elements/clone_upgrade.html@@ -162,3 +162,48 @@testing.expectEqual(1, reported);}</script>++<script id=upgrade_constructor_removes_itself>+ {+ const events = [];+ const el = document.body.appendChild(document.createElement('self-removing-upgrade'));+ customElements.define('self-removing-upgrade', class extends HTMLElement {+ constructor() {+ super();+ this.remove();+ }+ connectedCallback() { events.push('connected'); }+ disconnectedCallback() { events.push('disconnected'); }+ });+ testing.expectEqual(['connected'], events);+ document.body.appendChild(el);+ testing.expectEqual(['connected', 'connected'], events);+ el.remove();+ testing.expectEqual(['connected', 'connected', 'disconnected'], events);+ }+</script>++<script id=clone_constructor_connects_itself>+ {+ let cloning = false;+ const events = [];+ class SelfConnectingClone extends HTMLElement {+ constructor() {+ super();+ if (cloning) document.body.appendChild(this);+ }+ connectedCallback() { if (cloning) events.push('connected'); }+ disconnectedCallback() { if (cloning) events.push('disconnected'); }+ }+ customElements.define('self-connecting-clone', SelfConnectingClone);+ const original = new SelfConnectingClone();+ cloning = true;+ const copy = original.cloneNode();+ testing.expectEqual(true, copy.isConnected);+ testing.expectEqual([], events);+ copy.remove();+ testing.expectEqual(['disconnected'], events);+ document.body.appendChild(copy);+ testing.expectEqual(['disconnected', 'connected'], events);+ }+</script>diff --git a/src/browser/webapi/CustomElementRegistry.zig b/src/browser/webapi/CustomElementRegistry.zigindex 628afb42b..b2beae163 100644--- a/src/browser/webapi/CustomElementRegistry.zig+++ b/src/browser/webapi/CustomElementRegistry.zig@@ -266,6 +266,12 @@ pub fn upgradeCustomElement(custom: *Custom, definition: *CustomElementDefinitioframe.window.reportError(exc, frame) catch {};return error.CustomElementUpgradeFailed;}++ // Insertions and removals during construction queue nothing, so the+ // dedup flags must reflect where the constructor left the element.+ const connected = node.isConnected();+ custom._connected_callback_invoked = connected;+ custom._disconnected_callback_invoked = connected == false;}fn upgradeFailed(custom: *Custom) void {