Lightpanda: the headless browser designed for AI and automation
webapi: route observer and microtask errors to global.reportError
Karl Seguin165214cbab98
diff --git a/src/browser/js/Env.zig b/src/browser/js/Env.zigindex fd959d13e..b728bc389 100644--- a/src/browser/js/Env.zig+++ b/src/browser/js/Env.zig@@ -190,6 +190,7 @@ pub fn init(app: *App, opts: InitOpts) !Env {isolate.enter();errdefer isolate.exit();+ _ = v8.v8__Isolate__AddMessageListener(isolate_handle, messageCallback);v8.v8__Isolate__SetHostInitializeImportMetaObjectCallback(isolate_handle, Context.metaObjectCallback);// Allocate arrays dynamically to avoid comptime dependency on JsApis.len@@ -867,6 +868,27 @@ fn promiseRejectCallback(message_handle: v8.PromiseRejectMessage) callconv(.c) v}}+// V8 reports an exception that escapes to the top without a TryCatch. We+// *should* have a TryCatch at every Zig-initiated call, so this is almost+// certainly from a queueMicrotask callback. report it.+// If you remove this, V8 will print errors to stdout on its own.+fn messageCallback(_: ?*const v8.Message, data: ?*const v8.Value) callconv(.c) void {+ const v8_isolate = v8.v8__Isolate__GetCurrent().?;+ const isolate = js.Isolate{ .handle = v8_isolate };+ const ctx, const v8_context = Context.fromIsolate(isolate) orelse return;++ const local = js.Local{+ .ctx = ctx,+ .isolate = isolate,+ .handle = v8_context,+ .call_arena = ctx.call_arena,+ };++ ctx.global.reportError(.{ .local = &local, .handle = data orelse return }) catch |err| {+ log.debug(.js, "report uncaught exception", .{ .err = err });+ };+}+fn fatalCallback(c_location: [*c]const u8, c_message: [*c]const u8) callconv(.c) void {const location = std.mem.span(c_location);const message = std.mem.span(c_message);diff --git a/src/browser/js/Function.zig b/src/browser/js/Function.zigindex ccef13de5..c478a9bd5 100644--- a/src/browser/js/Function.zig+++ b/src/browser/js/Function.zig@@ -136,6 +136,22 @@ pub fn callWithThisRethrow(self: *const Function, comptime T: type, this: anytypreturn self._tryCallWithThis(T, this, args, &caught, .{ .rethrow = true });}+// An exception is reported on the global (e.g. window.reportError, which also+// dispatches the "error" event).+pub fn callWithThisReport(self: *const Function, this: anytype, args: anytype) !void {+ var try_catch: js.TryCatch = undefined;+ try_catch.init(self.local);+ defer try_catch.deinit();++ self.callWithThisRethrow(void, this, args) catch |err| {+ if (err != error.TryCatchRethrow) {+ return err;+ }+ const exc = try_catch.exceptionValue() orelse return;+ try self.local.ctx.global.reportError(exc);+ };+}+pub fn tryCall(self: *const Function, comptime T: type, args: anytype, caught: *js.TryCatch.Caught) !T {return self._tryCallWithThis(T, self.getThis(), args, caught, .{});}diff --git a/src/browser/tests/event/report_error.html b/src/browser/tests/event/report_error.htmlindex cd5f96c01..e53af067c 100644--- a/src/browser/tests/event/report_error.html+++ b/src/browser/tests/event/report_error.html@@ -40,8 +40,9 @@<!--An exception a callback doesn't catch is reported to the global — window's"error" event fires with the thrown value — whatever kind of callback threw:- timers, animation frames, inline on* handlers (attribute or property), and- property handlers dispatched directly (window.onmessage).+ timers, animation frames, inline on* handlers (attribute or property),+ property handlers dispatched directly (window.onmessage), microtasks and+ observers.https://html.spec.whatwg.org/multipage/webappapis.html#report-the-exception--><button id=inlineAttrThrower onclick="throw new Error('cb-inline-attribute')"></button>@@ -65,6 +66,18 @@requestAnimationFrame(() => { throw new Error('cb-requestAnimationFrame'); });document.getElementById('inlinePropThrower').onclick = () => { throw new Error('cb-inline-property'); };window.onmessage = () => { throw new Error('cb-onmessage'); };+ queueMicrotask(() => { throw new Error('cb-queueMicrotask'); });++ const observed = document.createElement('div');+ document.body.appendChild(observed);+ new MutationObserver(() => { throw new Error('cb-MutationObserver'); })+ .observe(observed, { attributes: true });+ observed.setAttribute('x', '1');+ new IntersectionObserver(() => { throw new Error('cb-IntersectionObserver'); }).observe(observed);+ new ResizeObserver(() => { throw new Error('cb-ResizeObserver'); }).observe(observed);+ new PerformanceObserver(() => { throw new Error('cb-PerformanceObserver'); })+ .observe({ entryTypes: ['mark'] });+ performance.mark('report-error');setTimeout(() => {document.getElementById('inlineAttrThrower').click();document.getElementById('inlinePropThrower').click();@@ -77,7 +90,7 @@window.removeEventListener('error', onError);window.onmessage = null;testing.expectEqual(- 'cb-inline-attribute,cb-inline-property,cb-onmessage,cb-requestAnimationFrame,cb-setInterval,cb-setTimeout',+ 'cb-IntersectionObserver,cb-MutationObserver,cb-PerformanceObserver,cb-ResizeObserver,cb-inline-attribute,cb-inline-property,cb-onmessage,cb-queueMicrotask,cb-requestAnimationFrame,cb-setInterval,cb-setTimeout',seen.slice().sort().join(','),);for (const msg of seen) testing.expectEqual(true, thrown[msg]);diff --git a/src/browser/tests/mutation_observer/callback_exception_moved_by_gc.html b/src/browser/tests/mutation_observer/callback_exception_moved_by_gc.htmlindex bdc698330..ca9873628 100644--- a/src/browser/tests/mutation_observer/callback_exception_moved_by_gc.html+++ b/src/browser/tests/mutation_observer/callback_exception_moved_by_gc.html@@ -1,28 +1,46 @@<!DOCTYPE html><script src="../testing.js"></script>+<script id=expectReportedErrors>+ // Both throws below are reported to window; that's expected here.+ window.addEventListener('error', (e) => e.preventDefault());++ // The thrown object's `message` getter allocates enough to force several+ // scavenges while it's read, relocating the exception mid-read.+ function gcMovingException() {+ return {+ get message() {+ const keep = [];+ for (let round = 0; round < 8; round++) {+ const junk = [];+ for (let i = 0; i < 300000; i++) junk.push({ i, s: 'x' + i });+ keep.push(junk);+ }+ return 'moved' + keep.length;+ },+ stack: 'stack',+ };+ }+ testing.expectEqual('function', typeof gcMovingException);+</script>+<script id=observerThrowsObjectMovedByGc>{const target = document.createElement('div');new MutationObserver(() => {- throw {- get message() {- const keep = [];- for (let round = 0; round < 8; round++) {- const junk = [];- for (let i = 0; i < 300000; i++) junk.push({ i, s: 'x' + i });- keep.push(junk);- }- return 'moved' + keep.length;- },- stack: 'stack',- };+ throw gcMovingException();}).observe(target, { attributes: true });target.setAttribute('x', '1');testing.expectEqual('1', target.getAttribute('x'));}</script>+<!-- A throwing script's TryCatch is read (TryCatch.caught) before the exception is reported. -->+<script id=scriptThrowsObjectMovedByGc>+ testing.expectEqual(true, true);+ throw gcMovingException();+</script>+<script id=stillAlive>testing.expectEqual(3, 1 + 2);</script>diff --git a/src/browser/tests/worker/report-error-worker.js b/src/browser/tests/worker/report-error-worker.jsindex 8a1a0d355..f207b3bcb 100644--- a/src/browser/tests/worker/report-error-worker.js+++ b/src/browser/tests/worker/report-error-worker.js@@ -29,6 +29,7 @@ target.addEventListener('ping', () => { throw new Error('listener'); });target.dispatchEvent(new Event('ping'));setTimeout(() => { throw new Error('setTimeout'); }, 0);+queueMicrotask(() => { throw new Error('queueMicrotask'); });setTimeout(() => { throw new Error('reentrant'); }, 5);setTimeout(() => postMessage({ seen: seen.slice().sort(), reentrant }), 20);diff --git a/src/browser/tests/worker/worker.html b/src/browser/tests/worker/worker.htmlindex b541eda7f..f5d2385a4 100644--- a/src/browser/tests/worker/worker.html+++ b/src/browser/tests/worker/worker.html@@ -584,7 +584,7 @@worker.postMessage('throw');await state.done((data) => {- testing.expectEqual('listener,onmessage,reentrant,setTimeout', data.seen.join(','));+ testing.expectEqual('listener,onmessage,queueMicrotask,reentrant,setTimeout', data.seen.join(','));testing.expectEqual(1, data.reentrant);worker.terminate();});diff --git a/src/browser/webapi/IntersectionObserver.zig b/src/browser/webapi/IntersectionObserver.zigindex 4907702bb..4754de48b 100644--- a/src/browser/webapi/IntersectionObserver.zig+++ b/src/browser/webapi/IntersectionObserver.zig@@ -319,14 +319,12 @@ pub fn deliverEntries(self: *IntersectionObserver, frame: *Frame) !void {// whether we safely deliver these to v8 or not, we're done with thesedefer releaseAll(entries, frame.page);- var caught: js.TryCatch.Caught = .{};-var ls: js.Local.Scope = undefined;frame.js.localScope(&ls);defer ls.deinit();- ls.toLocal(self._callback).tryCall(void, .{ entries, self }, &caught) catch |err| {- log.debug(.frame, "IntsctObserver.deliverEntries", .{ .err = err, .caught = caught });+ ls.toLocal(self._callback).callWithThisReport(self, .{ entries, self }) catch |err| {+ log.debug(.frame, "IntsctObserver.deliverEntries", .{ .err = err });return err;};}diff --git a/src/browser/webapi/MutationObserver.zig b/src/browser/webapi/MutationObserver.zigindex 41b3e3167..9cabc64f9 100644--- a/src/browser/webapi/MutationObserver.zig+++ b/src/browser/webapi/MutationObserver.zig@@ -362,9 +362,8 @@ pub fn deliverRecords(self: *MutationObserver, frame: *Frame) !void {frame.js.localScope(&ls);defer ls.deinit();- var caught: js.TryCatch.Caught = .{};- ls.toLocal(self._callback).tryCallWithThis(void, self, .{ records, self }, &caught) catch |err| {- log.debug(.frame, "MutObserver.deliverRecords", .{ .err = err, .caught = caught });+ ls.toLocal(self._callback).callWithThisReport(self, .{ records, self }) catch |err| {+ log.debug(.frame, "MutObserver.deliverRecords", .{ .err = err });return err;};}diff --git a/src/browser/webapi/PerformanceObserver.zig b/src/browser/webapi/PerformanceObserver.zigindex 5aacb45b3..67f931845 100644--- a/src/browser/webapi/PerformanceObserver.zig+++ b/src/browser/webapi/PerformanceObserver.zig@@ -198,9 +198,8 @@ pub fn dispatch(self: *PerformanceObserver) !void {self._js.localScope(&ls);defer ls.deinit();- var caught: js.TryCatch.Caught = .{};- ls.toLocal(self._callback).tryCall(void, .{ EntryList{ ._entries = records }, self }, &caught) catch |err| {- log.debug(.frame, "PerfObserver.dispatch", .{ .err = err, .caught = caught });+ ls.toLocal(self._callback).callWithThisReport(self, .{ EntryList{ ._entries = records }, self }) catch |err| {+ log.debug(.frame, "PerfObserver.dispatch", .{ .err = err });return err;};}diff --git a/src/browser/webapi/ResizeObserver.zig b/src/browser/webapi/ResizeObserver.zigindex 34a6ff912..f53b28d51 100644--- a/src/browser/webapi/ResizeObserver.zig+++ b/src/browser/webapi/ResizeObserver.zig@@ -182,14 +182,12 @@ pub fn deliverEntries(self: *ResizeObserver, frame: *Frame) !void {return;}- var caught: js.TryCatch.Caught = .{};-var ls: js.Local.Scope = undefined;frame.js.localScope(&ls);defer ls.deinit();- ls.toLocal(self._callback).tryCall(void, .{ entries.items, self }, &caught) catch |err| {- log.debug(.frame, "ResizeObserver.deliverEntries", .{ .err = err, .caught = caught });+ ls.toLocal(self._callback).callWithThisReport(self, .{ entries.items, self }) catch |err| {+ log.debug(.frame, "ResizeObserver.deliverEntries", .{ .err = err });return err;};}