Lightpanda: the headless browser designed for AI and automation
NodeRegistry: pin that reset never reuses an id
Adrià Arrufat182ad25157aa
diff --git a/src/NodeRegistry.zig b/src/NodeRegistry.zigindex c48213d80..40f5a81fd 100644--- a/src/NodeRegistry.zig+++ b/src/NodeRegistry.zig@@ -190,3 +190,21 @@ test "NodeRegistry: resetFrame" {try testing.expectEqual(rb, registry.lookup_by_id.get(rb.id).?);try testing.expectEqual(b_node, registry.lookup_by_node.get(b_node).?.dom);}++test "NodeRegistry: reset never reuses an id" {+ var registry = NodeRegistry.init(testing.allocator);+ defer registry.deinit();++ var page = try testing.pageTest("cdp/registry1.html", .{});+ defer page.close();++ const frame = page.frame().?;+ const dom_node = (try frame.window._document.querySelector(.wrap("#a1"), frame)).?.asNode();+ // The pool recycles the `Node` itself, so keep the id, not the pointer.+ const first_id = (try registry.register(dom_node)).id;++ registry.reset();+ try testing.expectEqual(null, registry.lookup_by_id.get(first_id));+ // A stale id stays a miss rather than resolving to whatever registers next.+ try testing.expect((try registry.register(dom_node)).id != first_id);+}