Skip to content

Lightpanda: the headless browser designed for AI and automation

fix(accessibility): match Chrome ARIA coercion and checked roles

Robert McConnell22292e40c9b5
diff --git a/src/SemanticTree.zig b/src/SemanticTree.zig
index 8db40d11b..c47c9a653 100644
--- a/src/SemanticTree.zig
+++ b/src/SemanticTree.zig
@@ -1200,7 +1200,13 @@ test "SemanticTree: JSON exposes custom ARIA states without changing native chec
const switch_mixed = find(parsed.value, "Switch mixed") orelse return error.NodeNotFound;
try testing.expectString("false", switch_mixed.object.get("ariaChecked").?.string);
const invalid = find(parsed.value, "Invalid details") orelse return error.NodeNotFound;
- try testing.expect(invalid.object.get("ariaExpanded") == null);
+ try testing.expect(invalid.object.get("ariaExpanded").?.bool);
+ const empty_expanded = find(parsed.value, "Empty expanded") orelse return error.NodeNotFound;
+ try testing.expect(empty_expanded.object.get("ariaExpanded") == null);
+ const spaced_checked = find(parsed.value, "Spaced checked") orelse return error.NodeNotFound;
+ try testing.expectString("true", spaced_checked.object.get("ariaChecked").?.string);
+ const option_mixed = find(parsed.value, "Option mixed") orelse return error.NodeNotFound;
+ try testing.expectString("mixed", option_mixed.object.get("ariaChecked").?.string);
const native = find(parsed.value, "Native terms") orelse return error.NodeNotFound;
try testing.expect(native.object.get("checked").?.bool);
try testing.expect(native.object.get("ariaChecked") == null);
diff --git a/src/browser/tests/cdp/ax_aria_states.html b/src/browser/tests/cdp/ax_aria_states.html
index 7029da67a..29a1ec155 100644
--- a/src/browser/tests/cdp/ax_aria_states.html
+++ b/src/browser/tests/cdp/ax_aria_states.html
@@ -7,7 +7,7 @@
<div role="checkbox" aria-checked="true" tabindex="-1">Checked terms</div>
<div role="checkbox" aria-checked="false">Unfocusable terms</div>
<div role="checkbox" aria-checked="garbage" tabindex="xyz">Invalid state</div>
-<input type="checkbox" role="checkbox" checked aria-checked="true" aria-label="Native terms">
+<input type="checkbox" role="checkbox" checked aria-checked="false" aria-label="Native terms">
<div role="checkbox" aria-checked="mixed" tabindex="0" inert>Inert terms</div>
<div role="checkbox" aria-checked="mixed" tabindex="0" hidden>Hidden terms</div>
<button aria-label="Uppercase expanded" aria-expanded="TRUE">Uppercase</button>
@@ -25,5 +25,12 @@
<div role="switch" aria-label="Switch mixed" aria-checked="mixed" tabindex="0">Switch mixed</div>
<div role="menuitemcheckbox" aria-label="Menu checkbox mixed" aria-checked="mixed" tabindex="0">Menu checkbox mixed</div>
<div role="switch" aria-label="Expanded switch" aria-expanded="true" tabindex="0">Expanded switch</div>
+<button aria-label="Spaced expanded" aria-expanded=" true ">Spaced expanded</button>
+<button aria-label="Empty expanded" aria-expanded="">Empty expanded</button>
+<ul><li aria-label="Listitem expanded" aria-expanded="true">Listitem expanded</li></ul>
+<div role="checkbox" aria-label="Empty checked" aria-checked="" tabindex="0">Empty checked</div>
+<div role="checkbox" aria-label="Spaced checked" aria-checked=" true " tabindex="0">Spaced checked</div>
+<div role="listbox"><div role="option" aria-label="Option checked" aria-checked="true">Option checked</div><div role="option" aria-label="Option mixed" aria-checked="mixed">Option mixed</div></div>
+<div role="tree"><div role="treeitem" aria-label="Treeitem checked" aria-checked="true" aria-expanded="false">Treeitem checked</div></div>
<a href="/target" aria-label="Plain link">Plain link</a>
</body></html>
diff --git a/src/browser/tools.zig b/src/browser/tools.zig
index 5858e08af..ee028ba7e 100644
--- a/src/browser/tools.zig
+++ b/src/browser/tools.zig
@@ -3067,6 +3067,15 @@ test "tools: tree exposes Chrome-matched custom ARIA states" {
"button 'Expanded details' [expanded]",
"button 'Collapsed details' [collapsed]",
"button 'Uppercase expanded' [expanded]",
+ "button 'Invalid details' [expanded]",
+ "button 'Spaced expanded' [expanded]",
+ "listitem 'Listitem expanded' [expanded]",
+ "checkbox 'Invalid state' [checked]",
+ "checkbox 'Empty checked' [unchecked]",
+ "checkbox 'Spaced checked' [checked]",
+ "option 'Option checked' [checked]",
+ "option 'Option mixed' [mixed]",
+ "treeitem 'Treeitem checked' [collapsed] [checked]",
"checkbox 'Uppercase mixed' [mixed]",
"checkbox 'Absent checked' [unchecked]",
"switch 'Switch mixed' [unchecked]",
@@ -3081,8 +3090,8 @@ test "tools: tree exposes Chrome-matched custom ARIA states" {
}
}
- // Unsupported roles and invalid tokens must not manufacture state.
- const ignored = [_][]const u8{ "'Generic expanded'", "'Invalid details'", "'Invalid state'" };
+ // Unsupported roles and empty expanded values must not manufacture state.
+ const ignored = [_][]const u8{ "'Generic expanded'", "'Empty expanded'" };
for (ignored) |name| {
var lines = std.mem.splitScalar(u8, result.text, '\n');
var found = false;
diff --git a/src/server/cdp/AXNode.zig b/src/server/cdp/AXNode.zig
index 4a10af5e3..5d8849fdb 100644
--- a/src/server/cdp/AXNode.zig
+++ b/src/server/cdp/AXNode.zig
@@ -321,11 +321,13 @@ pub const Writer = struct {
pub const AriaState = enum { true, false, mixed };
- fn parseAriaState(value: []const u8) ?AriaState {
- inline for (comptime std.meta.tags(AriaState)) |state| {
- if (std.ascii.eqlIgnoreCase(value, @tagName(state))) return state;
- }
- return null;
+ // Match Chrome AX token coercion: after trimming, only "false" is false,
+ // "mixed" is tri-state, and any other nonempty token reads as true.
+ fn parseAriaState(value: []const u8) AriaState {
+ const token = std.mem.trim(u8, value, " \t\r\n\x0b\x0c");
+ if (token.len == 0 or std.ascii.eqlIgnoreCase(token, "false")) return .false;
+ if (std.ascii.eqlIgnoreCase(token, "mixed")) return .mixed;
+ return .true;
}
const RoleStates = struct {
@@ -347,15 +349,17 @@ pub const Writer = struct {
.{ "gridcell", RoleStates{ .expanded = true } },
.{ "link", RoleStates{ .expanded = true } },
.{ "listbox", RoleStates{ .expanded = true } },
+ .{ "listitem", RoleStates{ .expanded = true } },
.{ "menuitem", RoleStates{ .expanded = true } },
.{ "menuitemcheckbox", RoleStates{ .expanded = true, .checked = .tri_state } },
.{ "menuitemradio", RoleStates{ .expanded = true, .checked = .binary } },
+ .{ "option", RoleStates{ .checked = .tri_state } },
.{ "radio", RoleStates{ .checked = .binary } },
.{ "row", RoleStates{ .expanded = true } },
.{ "rowheader", RoleStates{ .expanded = true } },
.{ "switch", RoleStates{ .expanded = true, .checked = .binary } },
.{ "tab", RoleStates{ .expanded = true } },
- .{ "treeitem", RoleStates{ .expanded = true } },
+ .{ "treeitem", RoleStates{ .expanded = true, .checked = .tri_state } },
});
return roles.get(std.ascii.lowerString(&buf, role)) orelse .{};
}
@@ -370,18 +374,15 @@ pub const Writer = struct {
const states = roleStates(role);
var props: AriaProperties = .{};
if (states.expanded and el.getTag() != .select) {
- if (parseAriaState(el.getAttributeInterned("aria-expanded") orelse "")) |state| {
- switch (state) {
- .true => props.expanded = true,
- .false => props.expanded = false,
- .mixed => {},
+ if (el.getAttributeInterned("aria-expanded")) |raw| {
+ if (std.mem.trim(u8, raw, " \t\r\n\x0b\x0c").len != 0) {
+ props.expanded = parseAriaState(raw) != .false;
}
}
}
if (states.checked != null and el.getTag() != .input) {
- if (parseAriaState(el.getAttributeSafe(.wrap("aria-checked")) orelse "false")) |state| {
- props.checked = if (state == .mixed and states.checked == .binary) .false else state;
- }
+ const state = parseAriaState(el.getAttributeSafe(.wrap("aria-checked")) orelse "false");
+ props.checked = if (state == .mixed and states.checked == .binary) .false else state;
}
return props;
}
@@ -2391,7 +2392,10 @@ test "AXNode: custom ARIA states and tabindex focusability" {
const cases = [_]Case{
.{ .role = "button", .name = "Expanded details", .property = "expanded", .value = .{ .bool = true } },
.{ .role = "button", .name = "Collapsed details", .property = "expanded", .value = .{ .bool = false } },
- .{ .role = "button", .name = "Invalid details", .property = "expanded", .value = null },
+ .{ .role = "button", .name = "Invalid details", .property = "expanded", .value = .{ .bool = true } },
+ .{ .role = "button", .name = "Spaced expanded", .property = "expanded", .value = .{ .bool = true } },
+ .{ .role = "button", .name = "Empty expanded", .property = "expanded", .value = null },
+ .{ .role = "listitem", .name = "Listitem expanded", .property = "expanded", .value = .{ .bool = true } },
.{ .role = "button", .name = "Uppercase expanded", .property = "expanded", .value = .{ .bool = true } },
.{ .role = "button", .name = "Uppercase collapsed", .property = "expanded", .value = .{ .bool = false } },
.{ .role = null, .name = "Generic expanded", .property = "expanded", .value = null },
@@ -2402,9 +2406,16 @@ test "AXNode: custom ARIA states and tabindex focusability" {
.{ .role = "checkbox", .name = "Mixed terms", .property = "checked", .value = .{ .string = "mixed" } },
.{ .role = "checkbox", .name = "Checked terms", .property = "checked", .value = .{ .string = "true" } },
.{ .role = "checkbox", .name = "Unfocusable terms", .property = "checked", .value = .{ .string = "false" } },
- .{ .role = "checkbox", .name = "Invalid state", .property = "checked", .value = null },
+ .{ .role = "checkbox", .name = "Invalid state", .property = "checked", .value = .{ .string = "true" } },
+ .{ .role = "checkbox", .name = "Empty checked", .property = "checked", .value = .{ .string = "false" } },
+ .{ .role = "checkbox", .name = "Spaced checked", .property = "checked", .value = .{ .string = "true" } },
+ .{ .role = "option", .name = "Option checked", .property = "checked", .value = .{ .string = "true" } },
+ .{ .role = "option", .name = "Option mixed", .property = "checked", .value = .{ .string = "mixed" } },
+ .{ .role = "treeitem", .name = "Treeitem checked", .property = "checked", .value = .{ .string = "true" } },
+ .{ .role = "treeitem", .name = "Treeitem checked", .property = "expanded", .value = .{ .bool = false } },
.{ .role = "checkbox", .name = "Uppercase mixed", .property = "checked", .value = .{ .string = "mixed" } },
.{ .role = "checkbox", .name = "Absent checked", .property = "checked", .value = .{ .string = "false" } },
+ .{ .role = "checkbox", .name = "Native terms", .property = "checked", .value = .{ .string = "true" } },
.{ .role = "switch", .name = "Switch checked", .property = "checked", .value = .{ .string = "true" } },
.{ .role = "switch", .name = "Switch mixed", .property = "checked", .value = .{ .string = "false" } },
.{ .role = "menuitemcheckbox", .name = "Menu checkbox checked", .property = "checked", .value = .{ .string = "true" } },