Lightpanda: the headless browser designed for AI and automation
cli: add strip-mode invisible
Karl Seguin23f5b8414e32
diff --git a/src/browser/StyleManager.zig b/src/browser/StyleManager.zigindex 93a9a5f25..79936e1d3 100644--- a/src/browser/StyleManager.zig+++ b/src/browser/StyleManager.zig@@ -326,6 +326,15 @@ pub fn hasDisplayNone(self: *StyleManager, el: *Element) bool {return self.isElementHidden(el, .{});}+/// Computed display:none coming only from inline style or an author stylesheet+/// rule — the UA stylesheet's hidden elements (<head>, <script>, [hidden], …)+/// are NOT counted, so document scaffolding is preserved. Used by the HTML+/// dump's "invisible" strip mode.+pub fn hasAuthorDisplayNone(self: *StyleManager, el: *Element) bool {+ self.rebuildIfDirty() catch return false;+ return self.isElementHidden(el, .{ .ua_display_none = false });+}+/// Centralizes UA-stylesheet display:none truth so `getComputedStyle().display`/// (via `hasDisplayNone`) and `el.checkVisibility()` (via `isHidden`) agree./// Spec: HTML Rendering §15.3.1 "Hidden elements".@@ -523,8 +532,10 @@ fn isElementHidden(self: *StyleManager, el: *Element, options: CheckVisibilityOp// element — per CSS Cascade §6.1 any normal-origin author rule beats UA// origin regardless of specificity, so `.x { display: flex }` on a// `<div class="x" hidden>` must report visible.- if (options.check_display and display_priority == 0) {- if (matchesUaDisplayNoneRule(el)) display_none = true;+ if (options.check_display and options.ua_display_none and display_priority == 0) {+ if (matchesUaDisplayNoneRule(el)) {+ display_none = true;+ }}return (display_none orelse false) or (visibility_hidden orelse false) or (opacity_zero orelse false);@@ -846,6 +857,7 @@ const CheckVisibilityOptions = struct {check_display: bool = true,check_visibility: bool = false,check_opacity: bool = false,+ ua_display_none: bool = true,};// Inline styles always win over stylesheets - use max u64 as sentineldiff --git a/src/browser/dump.zig b/src/browser/dump.zigindex 3a8e1bf79..375952ca7 100644--- a/src/browser/dump.zig+++ b/src/browser/dump.zig@@ -30,10 +30,11 @@ pub const Opts = struct {strip: Opts.Strip = .{},shadow: Opts.Shadow = .rendered,- pub const Strip = packed struct(u3) {+ pub const Strip = packed struct(u4) {js: bool = false,ui: bool = false,css: bool = false,+ invisible: bool = false,};pub const Shadow = enum {@@ -99,7 +100,7 @@ fn _deep(node: *Node, opts: Opts, comptime force_slot: bool, writer: *std.Io.Wri}},.element => |el| {- if (shouldStripElement(el, opts)) {+ if (shouldStripElement(el, opts, frame)) {return;}@@ -265,7 +266,12 @@ fn isVoidElement(el: *const Node.Element) bool {};}-fn shouldStripElement(el: *const Node.Element, opts: Opts) bool {+fn shouldStripElement(el: *Node.Element, opts: Opts, frame: *Frame) bool {+ // Fast path: with no strip flags set (every innerHTML/outerHTML call)+ if (@as(u4, @bitCast(opts.strip)) == 0) {+ return false;+ }+const tag_name = el.getTagNameDump();if (opts.strip.js) {@@ -306,6 +312,10 @@ fn shouldStripElement(el: *const Node.Element, opts: Opts) bool {if (std.mem.eql(u8, tag_name, "iframe")) return true;}+ if (opts.strip.invisible and frame._style_manager.hasAuthorDisplayNone(el)) {+ return true;+ }+return false;}diff --git a/src/help.zon b/src/help.zonindex 0072a7cad..8338ebe0b 100644--- a/src/help.zon+++ b/src/help.zon@@ -63,10 +63,11 @@\\ Comma-separated list of tag groups to remove from dump.\\ Defaults to no-strip.\\ Allowed values:- \\ js script and link[as=script, rel=preload].- \\ ui Includes img, picture, video, CSS and SVG.- \\ css Includes style and link[rel=stylesheet].- \\ full Strip everything.+ \\ js Script and link[as=script, rel=preload].+ \\ ui Includes img, picture, video, CSS and SVG.+ \\ css Includes style and link[rel=stylesheet].+ \\ invisible Invisible (via CSS) elements.+ \\ full Strip everything.\\ --json\\ Capture and print the status of the fetch in a JSON string and output\\ it. When used with --dump <MODE> this will wrap the dumped content