Lightpanda: the headless browser designed for AI and automation
ops: add new page_error log scope which logs at WARN
Karl Seguin27e195bb4403
diff --git a/src/browser/Frame.zig b/src/browser/Frame.zigindex fc0c00aa6..3d33b3f7b 100644--- a/src/browser/Frame.zig+++ b/src/browser/Frame.zig@@ -4402,6 +4402,7 @@ test "Frame: a failed navigation commits an error document over the superseded o}test "Frame: readystatechange during an aborted load may renavigate or throw" {+ testing.expectLog(&.{.page_error});const page = try testing.pageTest("hi.html", .{});defer page.close();const frame = page.frame().?;diff --git a/src/browser/Page.zig b/src/browser/Page.zigindex 7a51b0c06..f23794cd3 100644--- a/src/browser/Page.zig+++ b/src/browser/Page.zig@@ -577,6 +577,7 @@ fn appendFrameExecutions(frame: *Frame, origin: []const u8, arena: Allocator, liconst testing = @import("../testing.zig");test "Page: js_error_count" {+ testing.expectLog(&.{ .page_error, .page_error });// One uncaught top-level script exception, one uncaught timer-callback// exception.diff --git a/src/browser/ScriptManagerBase.zig b/src/browser/ScriptManagerBase.zigindex 072ffbdea..cd172fd5f 100644--- a/src/browser/ScriptManagerBase.zig+++ b/src/browser/ScriptManagerBase.zig@@ -1011,19 +1011,23 @@ pub const Script = struct {return;}- const caught = try_catch.caughtOrError(frame.local_arena, error.Unknown);lp.metrics.script_errors.incr();- log.debug(.js, "eval script", .{- .url = url,- .caught = caught,- });+ // Report before caughtOrError: reading the exception's stack drops+ // the frames reportError needs for the error's location.if (try_catch.exceptionValue()) |exc| {frame.window.reportError(exc, frame) catch |err| {log.debug(.js, "eval script report error", .{ .url = url, .err = err });};}+ if (log.enabled(.js, .debug)) {+ log.debug(.js, "eval script", .{+ .url = url,+ .caught = try_catch.caughtOrError(frame.local_arena, error.Unknown),+ });+ }+// a classic script that throws is still "loaded". For a module, we can't// currently tell the difference between loaded, but errors, and failed// to load, so we stick with just error.diff --git a/src/browser/js/Env.zig b/src/browser/js/Env.zigindex 5a7dd1ce6..72a37ffa6 100644--- a/src/browser/js/Env.zig+++ b/src/browser/js/Env.zig@@ -837,6 +837,11 @@ fn promiseRejectCallback(message_handle: v8.PromiseRejectMessage) callconv(.c) vdefer ctx.call_depth -= 1;const no_handler = promise_event == v8.kPromiseRejectWithNoHandler;+ if (no_handler and log.enabled(.page_error, .debug)) {+ // debug because it can still get a handler later, so it might get handled+ logUnhandledRejection(&local, v8.v8__PromiseRejectMessage__GetValue(&message_handle));+ }+switch (ctx.global) {.frame => |frame| {frame.window.unhandledPromiseRejection(no_handler, .{@@ -857,6 +862,21 @@ fn promiseRejectCallback(message_handle: v8.PromiseRejectMessage) callconv(.c) v}}+fn logUnhandledRejection(local: *const js.Local, reason_handle: ?*const v8.Value) void {+ const handle = reason_handle orelse {+ log.debug(.page_error, "unhandled rejection", .{ .reason = "undefined" });+ return;+ };+ const reason = js.Value{ .local = local, .handle = handle };+ const location = reason.errorLocation(local.call_arena) catch js.Value.ErrorLocation{};+ log.debug(.page_error, "unhandled rejection", .{+ .reason = reason.toStringSlice() catch "Unknown reason",+ .url = location.url,+ .line = location.line,+ .column = location.column,+ });+}+// V8 reports an exception that escapes to the top without a TryCatch. We// *should* have a TryCatch at every Zig-initiated call, so this is almost// certainly from a queueMicrotask callback. report it.diff --git a/src/browser/webapi/ServiceWorkerContainer.zig b/src/browser/webapi/ServiceWorkerContainer.zigindex 65dba5af6..74e0ced7b 100644--- a/src/browser/webapi/ServiceWorkerContainer.zig+++ b/src/browser/webapi/ServiceWorkerContainer.zig@@ -308,8 +308,7 @@ pub const JsApi = struct {const testing = @import("../../testing.zig");test "WebApi: ServiceWorker" {- // The throwing-worker and cross-origin cases log at error level on purpose.- testing.silenceLog(&.{ .http, .browser });+ testing.expectLog(&.{.page_error});try testing.htmlRunner("service_worker/service_worker.html", .{.timeout_ms = 8000,.experimental_features = .{ .serviceworker = true },diff --git a/src/browser/webapi/ServiceWorkerGlobalScope.zig b/src/browser/webapi/ServiceWorkerGlobalScope.zigindex 0566f0ac3..39619a1c3 100644--- a/src/browser/webapi/ServiceWorkerGlobalScope.zig+++ b/src/browser/webapi/ServiceWorkerGlobalScope.zig@@ -301,7 +301,7 @@ fn loadInitialScript(self: *ServiceWorkerGlobalScope, script: []const u8) !void}js_context.page.recordJsError(err);const caught = try_catch.caughtOrError(self._script_load.?.arena.allocator(), err);- log.debug(.browser, "SWGS module error", .{ .url = url, .caught = caught });+ log.warn(.page_error, "uncaught exception", .{ .url = url, .caught = caught });evaluated = false;};} else {@@ -311,7 +311,7 @@ fn loadInitialScript(self: *ServiceWorkerGlobalScope, script: []const u8) !void}js_context.page.recordJsError(err);const caught = try_catch.caughtOrError(self._script_load.?.arena.allocator(), err);- log.debug(.browser, "SWGS script error", .{ .url = url, .caught = caught });+ log.warn(.page_error, "uncaught exception", .{ .url = url, .caught = caught });evaluated = false;};}diff --git a/src/browser/webapi/SharedWorkerGlobalScope.zig b/src/browser/webapi/SharedWorkerGlobalScope.zigindex 65731deb3..189bc2594 100644--- a/src/browser/webapi/SharedWorkerGlobalScope.zig+++ b/src/browser/webapi/SharedWorkerGlobalScope.zig@@ -280,7 +280,7 @@ fn loadInitialScript(self: *SharedWorkerGlobalScope, script: []const u8) !void {js_context.page.recordJsError(err);const caught = try_catch.caughtOrError(self._script_arena.?.allocator(), err);- log.debug(.browser, "shared worker script error", .{ .url = self._url, .caught = caught });+ log.warn(.page_error, "uncaught exception", .{ .url = self._url, .caught = caught });return;},.module => js_context.module(false, &ls.local, script, self._url, true) catch |err| {@@ -290,7 +290,7 @@ fn loadInitialScript(self: *SharedWorkerGlobalScope, script: []const u8) !void {js_context.page.recordJsError(err);const caught = try_catch.caughtOrError(self._script_arena.?.allocator(), err);- log.debug(.browser, "shared worker module error", .{ .url = self._url, .caught = caught });+ log.warn(.page_error, "uncaught exception", .{ .url = self._url, .caught = caught });return;},}diff --git a/src/browser/webapi/Window.zig b/src/browser/webapi/Window.zigindex ad1a7f26a..901c2725d 100644--- a/src/browser/webapi/Window.zig+++ b/src/browser/webapi/Window.zig@@ -507,11 +507,12 @@ pub fn reportError(self: *Window, err: js.Value, frame: *Frame) !void {const target = self.asEventTarget();if (!frame._event_manager.hasDirectListeners(target, "error")) {- if (comptime lp.IS_TEST == false) {- log.debug(.js, "window.reportError", .{- .message = err.toStringSlice() catch "Unknown error",- });- }+ log.warn(.page_error, "uncaught exception", .{+ .message = err.toStringSlice() catch "Unknown error",+ .url = location.url,+ .line = location.line,+ .column = location.column,+ });notifyExceptionThrown(err, location, frame);return;}@@ -539,17 +540,13 @@ pub fn reportError(self: *Window, err: js.Value, frame: *Frame) !void {.run_microtasks = false,});- if (comptime lp.IS_TEST == false) {- if (!event._prevent_default) {- log.debug(.js, "window.reportError", .{- .message = error_event._message,- .filename = error_event._filename,- .line_number = error_event._line_number,- .column_number = error_event._column_number,- });- }- }if (!event._prevent_default) {+ log.warn(.page_error, "uncaught exception", .{+ .message = error_event._message,+ .url = error_event._filename,+ .line = error_event._line_number,+ .column = error_event._column_number,+ });notifyExceptionThrown(err, location, frame);}}@@ -907,14 +904,6 @@ fn getWebDriver(_: *const Window) @import("WebDriver.zig") {}pub fn unhandledPromiseRejection(self: *Window, no_handler: bool, rejection: js.PromiseRejection, frame: *Frame) !void {- if (comptime lp.IS_DEBUG) {- log.debug(.js, "unhandled rejection", .{- .target = "window",- .value = rejection.reason(),- .stack = rejection.local.stackTrace() catch |err| @errorName(err) orelse "???",- });- }-const event_name = if (no_handler) "unhandledrejection" else "rejectionhandled";if (no_handler) {diff --git a/src/browser/webapi/Worker.zig b/src/browser/webapi/Worker.zigindex 17a6802d4..2a8f0be32 100644--- a/src/browser/webapi/Worker.zig+++ b/src/browser/webapi/Worker.zig@@ -233,7 +233,7 @@ fn loadInitialScript(self: *Worker, script: []const u8) !void {js_context.page.recordJsError(err);const caught = try_catch.caughtOrError(self._script_arena.?.allocator(), err);- log.debug(.browser, "worker script error", .{ .url = self._url, .caught = caught });+ log.warn(.page_error, "uncaught exception", .{ .url = self._url, .caught = caught });self.fireErrorEvent(caught.exception orelse @errorName(err), null);return;},@@ -244,7 +244,7 @@ fn loadInitialScript(self: *Worker, script: []const u8) !void {js_context.page.recordJsError(err);const caught = try_catch.caughtOrError(self._script_arena.?.allocator(), err);- log.debug(.browser, "worker module error", .{ .url = self._url, .caught = caught });+ log.warn(.page_error, "uncaught exception", .{ .url = self._url, .caught = caught });self.fireErrorEvent(caught.exception orelse @errorName(err), null);return;},@@ -443,6 +443,8 @@ pub const JsApi = struct {const testing = @import("../../testing.zig");test "WebApi: Worker" {testing.silenceLog(&.{ .http, .browser, .browser });+ // report-error-worker.js throws five uncaught exceptions on purpose.+ testing.expectLog(&.{ .page_error, .page_error, .page_error, .page_error, .page_error });// Worker tests chain a worker-script fetch with a dynamic-import fetch// and a cross-context postMessage. The default 2 s assertion budget candiff --git a/src/browser/webapi/WorkerGlobalScope.zig b/src/browser/webapi/WorkerGlobalScope.zigindex 17cf28a9d..35ebbe5c6 100644--- a/src/browser/webapi/WorkerGlobalScope.zig+++ b/src/browser/webapi/WorkerGlobalScope.zig@@ -336,14 +336,6 @@ pub fn structuredClone(_: *const WorkerGlobalScope, value: JS.Value) !JS.Value {}pub fn unhandledPromiseRejection(self: *WorkerGlobalScope, no_handler: bool, rejection: JS.PromiseRejection) !void {- if (comptime lp.IS_DEBUG) {- log.debug(.js, "unhandled rejection", .{- .target = "worker",- .value = rejection.reason(),- .stack = rejection.local.stackTrace() catch |err| @errorName(err) orelse "???",- });- }-const event_name = if (no_handler) "unhandledrejection" else "rejectionhandled";if (no_handler) {@@ -424,7 +416,7 @@ fn importScript(self: *WorkerGlobalScope, arena: Allocator, url: [:0]const u8) !_ = ls.local.eval(response.body.items, url) catch |err| {self.page.recordJsError(err);const caught = try_catch.caughtOrError(arena, err);- log.debug(.browser, "importScript", .{ .url = resolved_url, .caught = caught });+ log.warn(.page_error, "uncaught exception", .{ .url = resolved_url, .caught = caught });return;};@@ -447,9 +439,14 @@ pub fn reportError(self: *WorkerGlobalScope, err: JS.Value) !void {self._reporting_error = true;defer self._reporting_error = false;+ const location = err.errorLocation(err.local.call_arena) catch JS.Value.ErrorLocation{};+const error_event = try ErrorEvent.initTrusted(comptime .wrap("error"), .{.@"error" = try err.persist(),.message = err.toStringSlice() catch "Unknown error",+ .filename = location.url,+ .lineno = location.line,+ .colno = location.column,.bubbles = false,.cancelable = true,}, self.page);@@ -462,15 +459,13 @@ pub fn reportError(self: *WorkerGlobalScope, err: JS.Value) !void {// onerror is called with the event's fields (see Listener.run).try self.dispatch(self.asEventTarget(), event, .{});- if (comptime lp.IS_TEST == false) {- if (!event._prevent_default) {- log.debug(.js, "worker.reportError", .{- .message = error_event._message,- .filename = error_event._filename,- .line_number = error_event._line_number,- .column_number = error_event._column_number,- });- }+ if (!event._prevent_default) {+ log.warn(.page_error, "uncaught exception", .{+ .message = error_event._message,+ .url = error_event._filename,+ .line = error_event._line_number,+ .column = error_event._column_number,+ });}}diff --git a/src/log.zig b/src/log.zigindex 9ed5eed30..72662e6a1 100644--- a/src/log.zig+++ b/src/log.zig@@ -38,6 +38,7 @@ pub const Scope = enum {mcp,note,not_implemented,+ page_error,scheduler,serve,storage,diff --git a/src/server/cdp/domains/runtime.zig b/src/server/cdp/domains/runtime.zigindex eb2421ebf..6ce4090ef 100644--- a/src/server/cdp/domains/runtime.zig+++ b/src/server/cdp/domains/runtime.zig@@ -308,7 +308,7 @@ test "cdp.runtime: inspector events go to the session that enabled them" {}test "cdp.runtime: an uncaught exception emits Runtime.exceptionThrown" {- testing.silenceLog(&.{.js});+ testing.expectLog(&.{.page_error});var ctx = try testing.context();defer ctx.deinit();@@ -336,7 +336,7 @@ test "cdp.runtime: an uncaught exception emits Runtime.exceptionThrown" {}test "cdp.runtime: Runtime.exceptionThrown locates an Error where it was created" {- testing.silenceLog(&.{.js});+ testing.expectLog(&.{.page_error});var ctx = try testing.context();defer ctx.deinit();@@ -360,7 +360,7 @@ test "cdp.runtime: Runtime.exceptionThrown locates an Error where it was created}test "cdp.runtime: an exception whose error event is cancelled is not reported" {- testing.silenceLog(&.{.js});+ testing.expectLog(&.{.page_error});var ctx = try testing.context();defer ctx.deinit();