Skip to content

Lightpanda: the headless browser designed for AI and automation

avoid double handler compilation, use main_js where possible

Karl Seguin2afced776ad5
diff --git a/src/browser/EventManagerBase.zig b/src/browser/EventManagerBase.zig
index 7f205b2bb..49679e47b 100644
--- a/src/browser/EventManagerBase.zig
+++ b/src/browser/EventManagerBase.zig
@@ -543,10 +543,9 @@ pub const Listener = struct {
else => log.debug(.event, context, .{ .err = err }),
};
},
- .handler, .handler_source => {
- const handler = self.compileHandler(local.ctx, event._current_target.?) orelse return;
- try runHandler(local.toLocal(handler), local, event, context);
- },
+ .handler => |h| try runHandler(local.toLocal(h orelse return), local, event, context),
+ // compiled by run() before this is called
+ .handler_source => unreachable,
.object => |obj_global| {
const obj = local.toLocal(obj_global);
diff --git a/src/server/cdp/domains/dom.zig b/src/server/cdp/domains/dom.zig
index 670a99467..8680dd298 100644
--- a/src/server/cdp/domains/dom.zig
+++ b/src/server/cdp/domains/dom.zig
@@ -359,7 +359,7 @@ fn resolveNode(cmd: *CDP.Command) !void {
findContext(bc, root, context_id) orelse return error.ContextNotFound
else
// orelse root is safe here since there's no frame-specific state being used
- (node.dom.ownerFrame(root) orelse root).js;
+ (node.dom.ownerFrame(root) orelse root).main_js;
var ls: js.Local.Scope = undefined;
js_context.localScope(&ls);
@@ -404,8 +404,8 @@ fn findContext(bc: *CDP.BrowserContext, root: *Frame, context_id: u32) ?*js.Cont
}
fn findMainWorldContext(frame: *Frame, context_id: u32) ?*js.Context {
- if (contextIdOf(frame.js) == context_id) {
- return frame.js;
+ if (contextIdOf(frame.main_js) == context_id) {
+ return frame.main_js;
}
for (frame.child_frames.items) |child| {
if (findMainWorldContext(child, context_id)) |js_context| {