Skip to content

Lightpanda: the headless browser designed for AI and automation

notification: drop the unused frame_id from FrameRemove

Pierre Tachoire2b3c3f7497fd
diff --git a/src/Notification.zig b/src/Notification.zig
index fc01055e7..634fb2863 100644
--- a/src/Notification.zig
+++ b/src/Notification.zig
@@ -139,10 +139,7 @@ const Events = union(enum) {
};
pub const EventType = std.meta.FieldEnum(Events);
-pub const FrameRemove = struct {
- // Root frame id of the Page being removed.
- frame_id: u32,
-};
+pub const FrameRemove = struct {};
pub const FrameNavigate = struct {
req_id: u32,
diff --git a/src/browser/Session.zig b/src/browser/Session.zig
index 40cfa615e..a43fb2bb2 100644
--- a/src/browser/Session.zig
+++ b/src/browser/Session.zig
@@ -353,7 +353,7 @@ fn removePageFromList(self: *Session, page: *Page) void {
// which interleaves the OLD-page teardown with the pending-page promotion
// in a specific order.
fn tearDownPage(self: *Session, page: *Page) void {
- self.notification.dispatch(.frame_remove, .{ .frame_id = page.frame._frame_id });
+ self.notification.dispatch(.frame_remove, .{});
self.retire(page);
}
@@ -1026,7 +1026,7 @@ pub fn commitPendingPage(self: *Session, replacement: *Page) !void {
// Step 1: clear the OLD page's CDP / V8 inspector state while it is still
// walkable (node_registry, inspector context group, isolated worlds). OLD
// is still the live page (index 0); its memory stays alive until step 4.
- self.notification.dispatch(.frame_remove, .{ .frame_id = old.frame._frame_id });
+ self.notification.dispatch(.frame_remove, .{});
// Step 2: register the new page with CDP. `replacement.replaces` is still
// set, so the session still reports an in-flight nav and CDP's frameCreated