Skip to content

Lightpanda: the headless browser designed for AI and automation

:read-write check if host is editable (from its parents)

Karl Seguin2c2368729911
diff --git a/src/browser/tests/element/pseudo_classes.html b/src/browser/tests/element/pseudo_classes.html
index 6dd179d63..11bac08a2 100644
--- a/src/browser/tests/element/pseudo_classes.html
+++ b/src/browser/tests/element/pseudo_classes.html
@@ -138,13 +138,16 @@
<input id="rw_number" type="number">
<textarea id="rw_textarea"></textarea>
<textarea id="rw_textarea_ro" readonly></textarea>
- <div id="rw_editable" contenteditable></div>
+ <div id="rw_editable" contenteditable>
+ <p id="rw_editable_child"><b id="rw_editable_grandchild"></b></p>
+ <p id="rw_not_editable" contenteditable="false"><b id="rw_not_editable_child"></b></p>
+ </div>
<p id="rw_p"></p>
</div>
<script id="read_write">
{
const ids = (sel) => Array.from(document.querySelectorAll('#rw ' + sel)).map((e) => e.id).join();
- testing.expectEqual('rw_text,rw_number,rw_textarea,rw_editable', ids(':read-write'));
- testing.expectEqual('rw_readonly,rw_disabled,rw_checkbox,rw_textarea_ro,rw_p', ids(':read-only'));
+ testing.expectEqual('rw_text,rw_number,rw_textarea,rw_editable,rw_editable_child,rw_editable_grandchild', ids(':read-write'));
+ testing.expectEqual('rw_readonly,rw_disabled,rw_checkbox,rw_textarea_ro,rw_not_editable,rw_not_editable_child,rw_p', ids(':read-only'));
}
</script>
diff --git a/src/browser/webapi/Element.zig b/src/browser/webapi/Element.zig
index 50bfd8377..1c0b3b750 100644
--- a/src/browser/webapi/Element.zig
+++ b/src/browser/webapi/Element.zig
@@ -1213,6 +1213,18 @@ pub fn isEditingHost(self: *Element) bool {
return std.ascii.eqlIgnoreCase(value, "false") == false;
}
+// An editing host or a descendant of one: the nearest contenteditable
+// attribute decides.
+pub fn isEditable(self: *Element) bool {
+ var current: ?*Element = self;
+ while (current) |el| : (current = el.parentElement()) {
+ if (el.getAttributeSafe(.wrap("contenteditable")) != null) {
+ return el.isEditingHost();
+ }
+ }
+ return false;
+}
+
/// Focusable without a tabindex attribute.
fn isNativelyFocusable(self: *Element) bool {
if (self.is(Html) == null) {
diff --git a/src/browser/webapi/element/Html.zig b/src/browser/webapi/element/Html.zig
index 83c4d7b52..9f551e23b 100644
--- a/src/browser/webapi/element/Html.zig
+++ b/src/browser/webapi/element/Html.zig
@@ -643,13 +643,8 @@ pub fn setContentEditable(self: *HtmlElement, value: []const u8, frame: *Frame)
}
pub fn getIsContentEditable(self: *HtmlElement) bool {
- var current: ?*Element = self.asElement();
- while (current) |el| : (current = el.parentElement()) {
- const raw = el.getAttributeSafe(.wrap("contenteditable")) orelse continue;
- if (!std.ascii.eqlIgnoreCase(raw, "false")) {
- log.info(.not_implemented, "IsContentEditable", .{});
- }
- break;
+ if (self.asElement().isEditable()) {
+ log.info(.not_implemented, "IsContentEditable", .{});
}
return false;
}
diff --git a/src/browser/webapi/selector/List.zig b/src/browser/webapi/selector/List.zig
index 16345242f..c805deb46 100644
--- a/src/browser/webapi/selector/List.zig
+++ b/src/browser/webapi/selector/List.zig
@@ -518,7 +518,7 @@ fn isReadWrite(el: *Node.Element) bool {
if (el.is(Node.Element.Html.TextArea) != null) {
return !el.hasAttributeInterned("readonly") and !el.isDisabled();
}
- return el.isEditingHost();
+ return el.isEditable();
}
fn matchesPseudoClass(el: *Node.Element, pseudo: Selector.PseudoClass, scope: *Node, nth: ?*NthCache, frame: *Frame) bool {