Lightpanda: the headless browser designed for AI and automation
fix: report dataset named property presence via query interceptor
Scott Taylor37850aa84ed6
diff --git a/src/browser/tests/element/dataset.html b/src/browser/tests/element/dataset.htmlindex 72bc3fe4d..3df34585b 100644--- a/src/browser/tests/element/dataset.html+++ b/src/browser/tests/element/dataset.html@@ -107,6 +107,20 @@}</script>+<script id=propertyPresence>+{+ const el = document.getElementById('test');++ testing.expectEqual(true, 'foo' in el.dataset);+ testing.expectEqual(true, Object.hasOwn(el.dataset, 'foo'));+ testing.expectEqual(true, 'helloWorld' in el.dataset);++ testing.expectEqual(false, 'nonExistent' in el.dataset);+ testing.expectEqual(false, Object.hasOwn(el.dataset, 'nonExistent'));+ testing.expectEqual(false, Object.hasOwn(el.dataset, 'fooBar'));+}+</script>+<script id=identityCheck>{const el = document.getElementById('test');diff --git a/src/browser/webapi/element/DOMStringMap.zig b/src/browser/webapi/element/DOMStringMap.zigindex 9bb125449..dab5aaf41 100644--- a/src/browser/webapi/element/DOMStringMap.zig+++ b/src/browser/webapi/element/DOMStringMap.zig@@ -41,6 +41,11 @@ fn setProperty(self: *DOMStringMap, name: String, value: String, frame: *Frame)return self._element.setAttributeSafe(attr_name, value, frame);}+fn hasProperty(self: *DOMStringMap, name: String, frame: *Frame) !bool {+ const attr_name = try camelToKebab(frame.local_arena, name);+ return self._element.hasAttribute(attr_name, frame);+}+fn deleteProperty(self: *DOMStringMap, name: String, frame: *Frame) !void {const attr_name = try camelToKebab(frame.local_arena, name);try self._element.removeAttribute(attr_name, frame);@@ -135,7 +140,7 @@ pub const JsApi = struct {pub var class_id: bridge.ClassId = undefined;};- pub const @"[]" = bridge.namedIndexed(getProperty, setProperty, deleteProperty, getNames, null, .{ .null_as_undefined = true, .ce_reactions = true });+ pub const @"[]" = bridge.namedIndexed(getProperty, setProperty, deleteProperty, getNames, hasProperty, .{ .null_as_undefined = true, .ce_reactions = true });// The supported property names are the camel-cased names of the// element's data-* attributes, in attribute order.