Skip to content

Lightpanda: the headless browser designed for AI and automation

event: keep keydown and worker error events alive past dispatch

Pierre Tachoire37a120cc77b8
diff --git a/src/browser/actions.zig b/src/browser/actions.zig
index f4ef1b2fe..92d9ae8ed 100644
--- a/src/browser/actions.zig
+++ b/src/browser/actions.zig
@@ -94,6 +94,10 @@ pub fn press(node: ?*DOMNode, key: []const u8, frame: *Frame) !void {
.key = canonical,
}, frame);
+ // Keep the event alive past dispatch so we can read defaultPrevented.
+ keydown_event.asEvent().acquireRef();
+ defer _ = keydown_event.asEvent().releaseRef(frame._page);
+
frame._event_manager.dispatch(target, keydown_event.asEvent()) catch |err| {
lp.log.err(.app, "press keydown failed", .{ .err = err });
return error.ActionFailed;
diff --git a/src/browser/webapi/WorkerGlobalScope.zig b/src/browser/webapi/WorkerGlobalScope.zig
index dde06509d..b821cd6c2 100644
--- a/src/browser/webapi/WorkerGlobalScope.zig
+++ b/src/browser/webapi/WorkerGlobalScope.zig
@@ -502,6 +502,10 @@ pub fn reportError(self: *WorkerGlobalScope, err: JS.Value) !void {
}
const event = error_event.asEvent();
+ // Keep the event alive past dispatch so we can read _prevent_default.
+ event.acquireRef();
+ defer _ = event.releaseRef(self._page);
+
event._prevent_default = prevent_default;
// Pass null as handler: onerror was already called above with 5 args.
// We still dispatch so that addEventListener('error', ...) listeners fire.