Lightpanda: the headless browser designed for AI and automation
Agent: record navigating read tools as goto commands
Adrià Arrufat39924dcd8e62
diff --git a/src/agent/Agent.zig b/src/agent/Agent.zigindex 3a4762722..cb95d77ca 100644--- a/src/agent/Agent.zig+++ b/src/agent/Agent.zig@@ -698,7 +698,7 @@ fn runRepl(self: *Agent) void {self.terminal.endTool();self.printCommandResult(cmd, result);if (!result.is_error) {- self.recordSaveCommand(cmd);+ self.recordSaveCommand(navigationGoto(aa, tc.tool, tc.args) orelse cmd);}self.recordSlashToolCall(trimmed, tc.name(), tc.args, result) catch |err| {self.terminal.printWarning("LLM conversation out of sync (/{s}: {s}); next prompt may not see this action", .{ tc.name(), @errorName(err) });@@ -1197,6 +1197,20 @@ fn recordSaveCommand(self: *Agent, cmd: Command) void {self.save_buffer.record(cmd) catch |err| self.logSaveBufferError(err);}+/// Synthesize the `goto` a navigating read tool performed (`markdown {url}`, …)+/// so `/save` can replay it; null when it didn't navigate. The result borrows+/// `args`/`arena` — record it before either is freed.+fn navigationGoto(arena: std.mem.Allocator, tool: BrowserTool, args: ?std.json.Value) ?Command {+ if (!tool.navigatesToUrl()) return null;+ const a = args orelse return null;+ if (a != .object) return null;+ const url = a.object.get("url") orelse return null;+ if (url != .string or url.string.len == 0) return null;+ var obj: std.json.ObjectMap = .init(arena);+ obj.put("url", url) catch return null;+ return Command.fromToolCall(.goto, .{ .object = obj });+}+fn recordSaveComment(self: *Agent, comment: []const u8) void {self.save_buffer.recordComment(comment) catch |err| self.logSaveBufferError(err);}@@ -1528,13 +1542,18 @@ fn processUserMessage(self: *Agent, input: TurnInput) !?[]const u8 {if (tool == .extract and idx != i) continue;}const args = browser_tools.normalizeArgKeys(self.conversation.arena.allocator(), tool, tc.arguments) catch tc.arguments;+ // Fall back to the navigation a read tool performed, so a+ // markdown/tree-driven turn isn't lost from `/save`.const cmd = Command.fromToolCall(tool, args);- if (!cmd.isRecorded()) continue;+ const to_record = if (cmd.isRecorded())+ cmd+ else+ navigationGoto(self.conversation.arena.allocator(), tool, args) orelse continue;if (!recorded_any) {if (input.record_comment) |c| self.recordSaveComment(c);recorded_any = true;}- self.recordSaveCommand(cmd);+ self.recordSaveCommand(to_record);}}diff --git a/src/browser/tools.zig b/src/browser/tools.zigindex 6f0b6dd89..2c227ba1d 100644--- a/src/browser/tools.zig+++ b/src/browser/tools.zig@@ -264,6 +264,17 @@ pub const Tool = enum {};}+ /// A read tool that navigates when handed a `url`. The read isn't recorded,+ /// but the navigation is, so the recorder captures it as a `goto`. Excludes+ /// `evaluate` (carries its own `url`), `search` (derived engine URL), and+ /// `getCookies` (`url` filters, not navigates).+ pub fn navigatesToUrl(self: Tool) bool {+ return switch (self) {+ .markdown, .html, .links, .tree, .interactiveElements, .structuredData, .detectForms => true,+ .goto, .search, .evaluate, .extract, .nodeDetails, .click, .fill, .scroll, .waitForSelector, .waitForScript, .waitForState, .hover, .press, .selectOption, .setChecked, .findElement, .consoleLogs, .getUrl, .getCookies, .getEnv => false,+ };+ }+/// Tool requires a target element (selector or backendNodeId) at/// runtime even though the JSON schema marks both as optional. Used by/// the recorder to skip lines that can't be replayed.