Skip to content

Lightpanda: the headless browser designed for AI and automation

tree: list iframes with their URL

Adrià Arrufat3d2eb94b58ea
diff --git a/src/SemanticTree.zig b/src/SemanticTree.zig
index a78c42d24..6becd162f 100644
--- a/src/SemanticTree.zig
+++ b/src/SemanticTree.zig
@@ -232,6 +232,9 @@ fn visitNode(
} else if (el.is(Element.Html.Select)) |select| {
value = select.getValue(self.frame);
options = try extractSelectOptions(el.asNode(), self.frame, self.arena);
+ } else if (el.is(Element.Html.IFrame)) |iframe| {
+ // The tree doesn't enter frames; the URL lets the agent open one.
+ value = try iframe.getSrc(self.frame);
}
if (el.is(Element.Html)) |html_el| {
diff --git a/src/browser/tools.zig b/src/browser/tools.zig
index ead130539..8650c1f99 100644
--- a/src/browser/tools.zig
+++ b/src/browser/tools.zig
@@ -2779,6 +2779,23 @@ test "tree and nodeDetails read the node's own frame" {
try std.testing.expect(std.mem.find(u8, details.text, "child-label") != null);
}
+test "tree lists iframes with their URL" {
+ var registry: NodeRegistry = .init(std.testing.allocator);
+ defer registry.deinit();
+
+ var page = try testing.pageTest("cdp/semantic_tree_iframe.html", .{});
+ defer page.close();
+
+ const aa = testing.arena_allocator;
+ _ = try call(aa, page.session, &registry, "evaluate", try std.json.parseFromSliceLeaky(std.json.Value, aa,
+ \\{"script":"const f = document.createElement('iframe'); f.setAttribute('src', 'semantic_tree_iframe_child.html?scripted'); document.body.appendChild(f)"}
+ , .{}), .{});
+
+ const tree = try call(aa, page.session, &registry, "tree", null, .{});
+ try std.testing.expect(std.mem.find(u8, tree.text, "Iframe value='http://127.0.0.1:9582/src/browser/tests/cdp/semantic_tree_iframe_child.html'") != null);
+ try std.testing.expect(std.mem.find(u8, tree.text, "Iframe value='http://127.0.0.1:9582/src/browser/tests/cdp/semantic_tree_iframe_child.html?scripted'") != null);
+}
+
test "goto: a navigation stuck waiting for a connection is an error" {
var registry: NodeRegistry = .init(std.testing.allocator);
defer registry.deinit();
diff --git a/src/server/cdp/AXNode.zig b/src/server/cdp/AXNode.zig
index 430f906d1..a3c0a3098 100644
--- a/src/server/cdp/AXNode.zig
+++ b/src/server/cdp/AXNode.zig
@@ -711,7 +711,7 @@ const AXRole = enum(u8) {
paragraph, presentation, progressbar, radio, region, row, rowgroup,
rowheader, searchbox, separator, slider, spinbutton, status, strong,
subscript, superscript, @"switch", table, term, textbox, time, RootWebArea, LineBreak,
- StaticText,
+ StaticText, Iframe,
// zig fmt: on
fn fromNode(node: *DOMNode) !AXRole {
@@ -812,6 +812,7 @@ const AXRole = enum(u8) {
// Media
.img => .image,
+ .iframe => .Iframe,
.figure => .figure,
// Tables