Skip to content

Lightpanda: the headless browser designed for AI and automation

webapi: more (and better) replaceable proeprties.

Karl Seguin3d92b2d01a51
diff --git a/src/browser/js/Context.zig b/src/browser/js/Context.zig
index 296eaa2d1..6fe727835 100644
--- a/src/browser/js/Context.zig
+++ b/src/browser/js/Context.zig
@@ -316,6 +316,18 @@ pub fn toLocal(self: *Context, global: anytype) js.Local.ToLocalReturnType(@Type
return l.toLocal(global);
}
+// This context's global (proxy) object, bound to an already-active local.
+// Lets a caller running in a different context — e.g. a [Replaceable] setter
+// invoked on another same-origin window — target this context's global rather
+// than its own.
+pub fn globalObject(self: *Context, local: *const js.Local) js.Object {
+ const local_v8_context: *const v8.Context = @ptrCast(v8.v8__Global__Get(&self.handle, self.isolate.handle));
+ return .{
+ .local = local,
+ .handle = v8.v8__Context__Global(local_v8_context).?,
+ };
+}
+
pub fn getIncumbent(self: *Context) *Frame {
const ctx = fromC(v8.v8__Isolate__GetIncumbentContext(self.env.isolate.handle).?).?;
return switch (ctx.global) {
diff --git a/src/browser/webapi/Window.zig b/src/browser/webapi/Window.zig
index 2563dace1..eaf6c4358 100644
--- a/src/browser/webapi/Window.zig
+++ b/src/browser/webapi/Window.zig
@@ -125,6 +125,10 @@ pub fn getEvent(self: *const Window) ?*Event {
return self._current_event;
}
+pub fn setEvent(self: *Window, value: js.Value) void {
+ self.replaceGlobalProperty(value, "event");
+}
+
pub fn getSelf(self: *Window) *Window {
return self;
}
@@ -139,6 +143,17 @@ pub fn getOpener(self: *Window, frame: *Frame) ?Access {
return Access.init(frame.window, opener);
}
+// Per the HTML spec's opener setter: null disowns the opener (the accessor
+// stays in place and the getter now returns null); any other value redefines
+// the property as an own data property, like [Replaceable].
+pub fn setOpener(self: *Window, value: js.Value) void {
+ if (value.isNull()) {
+ self._opener = null;
+ return;
+ }
+ self.replaceGlobalProperty(value, "opener");
+}
+
pub fn getClosed(self: *const Window) bool {
return self._closed;
}
@@ -175,48 +190,48 @@ pub fn getConsole(self: *Window) *Console {
return &self._console;
}
-pub fn setConsole(_: *Window, value: js.Value) void {
- replaceGlobalProperty(value, "console");
+pub fn setConsole(self: *Window, value: js.Value) void {
+ self.replaceGlobalProperty(value, "console");
}
-pub fn setSelf(_: *Window, value: js.Value) void {
- replaceGlobalProperty(value, "self");
+pub fn setSelf(self: *Window, value: js.Value) void {
+ self.replaceGlobalProperty(value, "self");
}
-pub fn setFrames(_: *Window, value: js.Value) void {
- replaceGlobalProperty(value, "frames");
+pub fn setFrames(self: *Window, value: js.Value) void {
+ self.replaceGlobalProperty(value, "frames");
}
-pub fn setParent(_: *Window, value: js.Value) void {
- replaceGlobalProperty(value, "parent");
+pub fn setParent(self: *Window, value: js.Value) void {
+ self.replaceGlobalProperty(value, "parent");
}
-pub fn setLength(_: *Window, value: js.Value) void {
- replaceGlobalProperty(value, "length");
+pub fn setLength(self: *Window, value: js.Value) void {
+ self.replaceGlobalProperty(value, "length");
}
-pub fn setInnerWidth(_: *Window, value: js.Value) void {
- replaceGlobalProperty(value, "innerWidth");
+pub fn setInnerWidth(self: *Window, value: js.Value) void {
+ self.replaceGlobalProperty(value, "innerWidth");
}
-pub fn setInnerHeight(_: *Window, value: js.Value) void {
- replaceGlobalProperty(value, "innerHeight");
+pub fn setInnerHeight(self: *Window, value: js.Value) void {
+ self.replaceGlobalProperty(value, "innerHeight");
}
-pub fn setScrollX(_: *Window, value: js.Value) void {
- replaceGlobalProperty(value, "scrollX");
+pub fn setScrollX(self: *Window, value: js.Value) void {
+ self.replaceGlobalProperty(value, "scrollX");
}
-pub fn setScrollY(_: *Window, value: js.Value) void {
- replaceGlobalProperty(value, "scrollY");
+pub fn setScrollY(self: *Window, value: js.Value) void {
+ self.replaceGlobalProperty(value, "scrollY");
}
-pub fn setPageXOffset(_: *Window, value: js.Value) void {
- replaceGlobalProperty(value, "pageXOffset");
+pub fn setPageXOffset(self: *Window, value: js.Value) void {
+ self.replaceGlobalProperty(value, "pageXOffset");
}
-pub fn setPageYOffset(_: *Window, value: js.Value) void {
- replaceGlobalProperty(value, "pageYOffset");
+pub fn setPageYOffset(self: *Window, value: js.Value) void {
+ self.replaceGlobalProperty(value, "pageYOffset");
}
pub fn getNavigator(self: *Window) *Navigator {
@@ -231,10 +246,18 @@ pub fn getScreen(self: *Window) *Screen {
return self._screen;
}
+pub fn setScreen(self: *Window, value: js.Value) void {
+ self.replaceGlobalProperty(value, "screen");
+}
+
pub fn getVisualViewport(self: *const Window) *VisualViewport {
return self._visual_viewport;
}
+pub fn setVisualViewport(self: *Window, value: js.Value) void {
+ self.replaceGlobalProperty(value, "visualViewport");
+}
+
pub fn getCrypto(self: *Window) *Crypto {
return &self._crypto;
}
@@ -247,6 +270,10 @@ pub fn getPerformance(self: *Window) *Performance {
return &self._performance;
}
+pub fn setPerformance(self: *Window, value: js.Value) void {
+ self.replaceGlobalProperty(value, "performance");
+}
+
fn bucketForOrigin(self: *Window) *storage.Bucket {
return self._frame._session.storage_shed.getOrPut(
self._frame._session.browser.app.allocator,
@@ -274,6 +301,10 @@ pub fn getOrigin(self: *const Window) []const u8 {
return self._frame.origin orelse "null";
}
+pub fn setOrigin(self: *Window, value: js.Value) void {
+ self.replaceGlobalProperty(value, "origin");
+}
+
pub fn getSelection(self: *const Window) *Selection {
return &self._document._selection;
}
@@ -298,6 +329,10 @@ pub fn getNavigation(_: *Window, frame: *Frame) *Navigation {
return &frame._session.navigation;
}
+pub fn setNavigation(self: *Window, value: js.Value) void {
+ self.replaceGlobalProperty(value, "navigation");
+}
+
pub fn getCustomElements(self: *Window) *CustomElementRegistry {
return &self._custom_elements;
}
@@ -886,11 +921,11 @@ pub fn unhandledPromiseRejection(self: *Window, no_handler: bool, rejection: js.
}
}
-// `console` and a handful of other Window attributes are [Replaceable]: assigning
-// to them redefines the attribute as an own data property on the global instead
-// of throwing (which a getter-only accessor does in strict mode / modules).
-fn replaceGlobalProperty(value: js.Value, comptime name: []const u8) void {
- const global = value.local.getGlobal();
+// Some properties are readonly but [Replaceable]. They get assigned as own
+// data properties on the underlying v8::object that represents the global (the
+// Window)
+fn replaceGlobalProperty(self: *Window, value: js.Value, comptime name: []const u8) void {
+ const global = self._frame.js.globalObject(value.local);
_ = global.defineOwnProperty(name, value, 0);
}
@@ -1010,16 +1045,16 @@ pub const JsApi = struct {
pub const window = bridge.accessor(Window.getWindow, null, .{});
pub const parent = bridge.accessor(Window.getParent, Window.setParent, .{});
pub const navigator = bridge.accessor(Window.getNavigator, null, .{});
- pub const screen = bridge.accessor(Window.getScreen, null, .{});
- pub const visualViewport = bridge.accessor(Window.getVisualViewport, null, .{});
- pub const performance = bridge.accessor(Window.getPerformance, null, .{});
+ pub const screen = bridge.accessor(Window.getScreen, Window.setScreen, .{});
+ pub const visualViewport = bridge.accessor(Window.getVisualViewport, Window.setVisualViewport, .{});
+ pub const performance = bridge.accessor(Window.getPerformance, Window.setPerformance, .{});
pub const localStorage = bridge.accessor(Window.getLocalStorage, null, .{});
pub const sessionStorage = bridge.accessor(Window.getSessionStorage, null, .{});
pub const cookieStore = bridge.accessor(Window.getCookieStore, null, .{});
- pub const origin = bridge.accessor(Window.getOrigin, null, .{});
+ pub const origin = bridge.accessor(Window.getOrigin, Window.setOrigin, .{});
pub const location = bridge.accessor(Window.getLocation, Window.setLocation, .{ .deletable = false });
pub const history = bridge.accessor(Window.getHistory, null, .{});
- pub const navigation = bridge.accessor(Window.getNavigation, null, .{});
+ pub const navigation = bridge.accessor(Window.getNavigation, Window.setNavigation, .{});
pub const crypto = bridge.accessor(Window.getCrypto, null, .{});
pub const CSS = bridge.accessor(Window.getCSS, null, .{});
pub const customElements = bridge.accessor(Window.getCustomElements, null, .{});
@@ -1031,7 +1066,7 @@ pub const JsApi = struct {
pub const onmessage = bridge.accessor(Window.getOnMessage, Window.setOnMessage, .{});
pub const onrejectionhandled = bridge.accessor(Window.getOnRejectionHandled, Window.setOnRejectionHandled, .{});
pub const onunhandledrejection = bridge.accessor(Window.getOnUnhandledRejection, Window.setOnUnhandledRejection, .{});
- pub const event = bridge.accessor(Window.getEvent, null, .{ .null_as_undefined = true });
+ pub const event = bridge.accessor(Window.getEvent, Window.setEvent, .{ .null_as_undefined = true });
pub const fetch = bridge.function(Window.fetch, .{});
pub const queueMicrotask = bridge.function(Window.queueMicrotask, .{});
pub const setTimeout = bridge.function(Window.setTimeout, .{});
@@ -1078,7 +1113,7 @@ pub const JsApi = struct {
pub const innerHeight = bridge.accessor(Window.getInnerHeight, Window.setInnerHeight, .{});
pub const devicePixelRatio = bridge.property(1, .{ .template = false, .readonly = false });
- pub const opener = bridge.accessor(Window.getOpener, null, .{});
+ pub const opener = bridge.accessor(Window.getOpener, Window.setOpener, .{});
pub const closed = bridge.accessor(Window.getClosed, null, .{});
pub const name = bridge.accessor(Window.getName, Window.setName, .{});
pub const open = bridge.function(Window.open, .{ .dom_exception = true });
diff --git a/src/browser/webapi/WorkerGlobalScope.zig b/src/browser/webapi/WorkerGlobalScope.zig
index ab965648e..0b928500d 100644
--- a/src/browser/webapi/WorkerGlobalScope.zig
+++ b/src/browser/webapi/WorkerGlobalScope.zig
@@ -254,16 +254,16 @@ pub fn getSelf(self: *WorkerGlobalScope) *WorkerGlobalScope {
return self;
}
-pub fn setSelf(_: *WorkerGlobalScope, value: JS.Value) void {
- replaceGlobalProperty(value, "self");
+pub fn setSelf(self: *WorkerGlobalScope, value: JS.Value) void {
+ self.replaceGlobalProperty(value, "self");
}
pub fn getConsole(self: *WorkerGlobalScope) *Console {
return &self._console;
}
-pub fn setConsole(_: *WorkerGlobalScope, value: JS.Value) void {
- replaceGlobalProperty(value, "console");
+pub fn setConsole(self: *WorkerGlobalScope, value: JS.Value) void {
+ self.replaceGlobalProperty(value, "console");
}
pub fn getCrypto(self: *WorkerGlobalScope) *Crypto {
@@ -503,11 +503,11 @@ pub fn clearInterval(self: *WorkerGlobalScope, id: u32) void {
self._timers.clear(id);
}
-// `console` and `self` are [Replaceable]: assignment redefines them as own data
-// properties on the global rather than throwing through the getter-only accessor
-// in strict mode. Used here (console) and by DedicatedWorkerGlobalScope (self).
-pub fn replaceGlobalProperty(value: JS.Value, comptime name: []const u8) void {
- const global = value.local.getGlobal();
+// Some properties are readonly but [Replaceable]. They get assigned as own
+// data properties on the underlying v8::object that represents the global (the
+// WorkerGlobalScope)
+fn replaceGlobalProperty(self: *WorkerGlobalScope, value: JS.Value, comptime name: []const u8) void {
+ const global = self.js.globalObject(value.local);
_ = global.defineOwnProperty(name, value, 0);
}