Lightpanda: the headless browser designed for AI and automation
fix(actions): click dispatches full pointer/mouse sequence, not a bare click event
Ramiro_quai3e8ff142effb
diff --git a/src/browser/actions.zig b/src/browser/actions.zigindex f4ef1b2fe..ab9572780 100644--- a/src/browser/actions.zig+++ b/src/browser/actions.zig@@ -22,6 +22,7 @@ const DOMNode = @import("webapi/Node.zig");const Element = @import("webapi/Element.zig");const Event = @import("webapi/Event.zig");const MouseEvent = @import("webapi/event/MouseEvent.zig");+const PointerEvent = @import("webapi/event/PointerEvent.zig");const KeyboardEvent = @import("webapi/event/KeyboardEvent.zig");const Frame = @import("Frame.zig");const Session = @import("Session.zig");@@ -38,23 +39,56 @@ fn dispatchInputAndChangeEvents(el: *Element, frame: *Frame) !void {};}-pub fn click(node: *DOMNode, frame: *Frame) !void {- const el = node.is(Element) orelse return error.InvalidNodeType;+fn dispatchPointer(el: *Element, comptime typ: []const u8, button: i32, buttons: u16, frame: *Frame) !void {+ const event: *PointerEvent = try .initTrusted(typ, .{+ .bubbles = true,+ .cancelable = true,+ .composed = true,+ .button = button,+ .buttons = buttons,+ .pointerId = 1,+ .pointerType = "mouse",+ .isPrimary = true,+ }, frame);+ frame._event_manager.dispatch(el.asEventTarget(), event.asEvent()) catch |err| {+ lp.log.err(.app, "click failed", .{ .err = err, .type = typ });+ return error.ActionFailed;+ };+}- const mouse_event: *MouseEvent = try .initTrusted(comptime .wrap("click"), .{+fn dispatchMouse(el: *Element, comptime typ: []const u8, button: i32, buttons: u16, frame: *Frame) !void {+ const event: *MouseEvent = try .initTrusted(comptime .wrap(typ), .{.bubbles = true,.cancelable = true,.composed = true,+ .button = button,+ .buttons = buttons,+ .detail = 1,.clientX = 0,.clientY = 0,}, frame);-- frame._event_manager.dispatch(el.asEventTarget(), mouse_event.asEvent()) catch |err| {- lp.log.err(.app, "click failed", .{ .err = err });+ frame._event_manager.dispatch(el.asEventTarget(), event.asEvent()) catch |err| {+ lp.log.err(.app, "click failed", .{ .err = err, .type = typ });return error.ActionFailed;};}+// A full trusted primary-button click sequence on the element, as a real user+// click would produce: pointerdown, mousedown, pointerup, mouseup, click.+// Unlike a single bare "click" event, many widgets (autocomplete/combobox+// components in particular) key their open/interaction behavior off+// mousedown or pointerdown, not click alone -- see WebDriver.zig's `click`,+// which already implements this same sequence for testdriver's `click`.+pub fn click(node: *DOMNode, frame: *Frame) !void {+ const el = node.is(Element) orelse return error.InvalidNodeType;++ try dispatchPointer(el, "pointerdown", 0, 1, frame);+ try dispatchMouse(el, "mousedown", 0, 1, frame);+ try dispatchPointer(el, "pointerup", 0, 0, frame);+ try dispatchMouse(el, "mouseup", 0, 0, frame);+ try dispatchMouse(el, "click", 0, 0, frame);+}+pub fn hover(node: *DOMNode, frame: *Frame) !void {const el = node.is(Element) orelse return error.InvalidNodeType;diff --git a/src/browser/tests/mcp_actions.html b/src/browser/tests/mcp_actions.htmlindex f27c63ef4..9667f645a 100644--- a/src/browser/tests/mcp_actions.html+++ b/src/browser/tests/mcp_actions.html@@ -1,7 +1,7 @@<!DOCTYPE html><html><body>- <button id="btn" onclick="window.clicked = true;">Click Me</button>+ <button id="btn" onmousedown="window.mousedowned = true;" onclick="window.clicked = true;">Click Me</button><input id="inp" oninput="window.inputVal = this.value" onchange="window.changed = true;"><select id="sel" onchange="window.selChanged = this.value"><option value="opt1">Option 1</option>diff --git a/src/mcp/tools.zig b/src/mcp/tools.zigindex 3e928e124..483ee3515 100644--- a/src/mcp/tools.zig+++ b/src/mcp/tools.zig@@ -1161,7 +1161,7 @@ test "MCP - Actions: click, fill, scroll, hover, press, selectOption, setCheckeddefer try_catch.deinit();const result = try ls.local.exec(- \\ window.clicked === true && window.inputVal === 'hello' &&+ \\ window.mousedowned === true && window.clicked === true && window.inputVal === 'hello' &&\\ window.changed === true && window.selChanged === 'opt2' &&\\ window.scrolled === true &&\\ window.hovered === true &&