Lightpanda: the headless browser designed for AI and automation
perf: Remove Seletor cache from Runner's waitForSelector
Karl Seguin3f16812797d2
diff --git a/src/browser/Runner.zig b/src/browser/Runner.zigindex 1f08018d6..6665430d5 100644--- a/src/browser/Runner.zig+++ b/src/browser/Runner.zig@@ -303,8 +303,11 @@ fn _tick(self: *Runner, comptime is_cdp: bool, timeout_ms: u32, conditions: []Wapub fn waitForSelector(self: *Runner, frame_id: u32, input: [:0]const u8, timeout_ms: u32) !*Node.Element {const session = self.session;+ const arena = try session.getArena(.small, "Runner.waitForSelector");+ defer session.releaseArena(arena);+var timer = try std.time.Timer.start();- const selector = try Selector.cachedParse(session.browser, input);+ const selector = try Selector.parseLeaky(arena, input);while (true) {if (session.isCancelled()) {diff --git a/src/browser/webapi/selector/Selector.zig b/src/browser/webapi/selector/Selector.zigindex ecdc82251..9bb3a9c4c 100644--- a/src/browser/webapi/selector/Selector.zig+++ b/src/browser/webapi/selector/Selector.zig@@ -45,6 +45,13 @@ pub fn mapErrorToDOM(err: anyerror) anyerror {};}+pub fn parseLeaky(arena: Allocator, input: []const u8) ![]const Selector {+ if (input.len == 0) {+ return error.SyntaxError;+ }+ return Parser.parseList(arena, input);+}+/// One-off synthesized selectors use the `*Uncached` variants instead.pub fn cachedParse(browser: *Browser, input: []const u8) ![]const Selector {return browser.selector_cache.parse(input);