Skip to content

Lightpanda: the headless browser designed for AI and automation

fix notification use-after-free

Muki Kiboigo3f6b0d2d4a2e
diff --git a/src/server/cdp/CDP.zig b/src/server/cdp/CDP.zig
index 4785f787a..152d08f2c 100644
--- a/src/server/cdp/CDP.zig
+++ b/src/server/cdp/CDP.zig
@@ -615,6 +615,18 @@ pub const BrowserContext = struct {
self.node_registry.deinit();
self.node_search_list.deinit();
self.set_child_nodes_sent.deinit(self.cdp.allocator);
+
+ // CorsGate/RobotsGate fetches are ownerless, so closeSession's owner-based teardown never reaches them.
+ //
+ // They still carry this notification (copied for CDP correlation) and can outlive it, so clear
+ // the pointer here or Transfer.kill's later notify() dispatches through a freed Notification when
+ // the http_client itself is torn down.
+ var transfer_it = http_client.transfers.valueIterator();
+ while (transfer_it.next()) |t| {
+ if (t.*.req.notification == self.notification) {
+ t.*.req.notification = null;
+ }
+ }
self.notification.deinit();
if (self.http_proxy_changed) {