Skip to content

Lightpanda: the headless browser designed for AI and automation

move stripFragment to URL.zig

Karl Seguin42f089780c68
diff --git a/src/browser/URL.zig b/src/browser/URL.zig
index fc78e5a3e..c4b74b7be 100644
--- a/src/browser/URL.zig
+++ b/src/browser/URL.zig
@@ -625,6 +625,10 @@ pub fn unescape(arena: Allocator, input: []const u8) ![]const u8 {
return result.items;
}
+pub fn stripFragment(url: []const u8) []const u8 {
+ return url[0 .. std.mem.indexOfScalar(u8, url, '#') orelse url.len];
+}
+
const AuthorityInfo = struct {
host_start: usize,
host_end: usize,
@@ -1692,3 +1696,13 @@ test "URL: resolveNavigation defaults a schemeless host to http (curl-like)" {
try testing.expectString(case.expected, result);
}
}
+
+test "URL: stripFragment" {
+ try testing.expectEqual("https://www.example.com/", stripFragment("https://www.example.com/"));
+ try testing.expectEqual("https://www.example.com/about", stripFragment("https://www.example.com/about"));
+ try testing.expectEqual("https://www.example.com/?id=3", stripFragment("https://www.example.com/?id=3"));
+
+ try testing.expectEqual("https://www.example.com/", stripFragment("https://www.example.com/#pandapower"));
+ try testing.expectEqual("https://www.example.com/about", stripFragment("https://www.example.com/about#pandapower"));
+ try testing.expectEqual("https://www.example.com/?id=3", stripFragment("https://www.example.com/?id=3#pandapower"));
+}
diff --git a/src/browser/webapi/storage/CookieStore.zig b/src/browser/webapi/storage/CookieStore.zig
index c89755c86..86683c5ad 100644
--- a/src/browser/webapi/storage/CookieStore.zig
+++ b/src/browser/webapi/storage/CookieStore.zig
@@ -344,7 +344,7 @@ fn resolveQueryUrl(exec: *const Execution, _override: ?[]const u8) ![:0]const u8
switch (exec.js.global) {
.frame => {
// URL that differs from document only by #hash is the same document URL
- if (!std.mem.eql(u8, stripFragment(resolved), stripFragment(current))) {
+ if (!std.mem.eql(u8, URL.stripFragment(resolved), URL.stripFragment(current))) {
return error.InvalidUrl;
}
},
@@ -353,10 +353,6 @@ fn resolveQueryUrl(exec: *const Execution, _override: ?[]const u8) ![:0]const u8
return resolved;
}
-fn stripFragment(url: []const u8) []const u8 {
- return url[0 .. std.mem.indexOfScalar(u8, url, '#') orelse url.len];
-}
-
fn matchCookies(
exec: *const Execution,
name: ?[]const u8,