Lightpanda: the headless browser designed for AI and automation
input: leave an empty password value empty in redacted dumps
Jay Hemnani448000cc97fa
diff --git a/src/browser/forms.zig b/src/browser/forms.zigindex e4b39d11e..730b0e8bf 100644--- a/src/browser/forms.zig+++ b/src/browser/forms.zig@@ -302,6 +302,20 @@ test "browser.forms: login form" {try testing.expectEqual("password", forms[0].fields[1].name.?);}+test "browser.forms: password value is redacted only when set" {+ const forms = try testForms(+ \\<form>+ \\ <input type="password" name="empty">+ \\ <input type="password" name="filled" value="secret">+ \\</form>+ );+ defer testing.test_session.closeAllPages();++ try testing.expectEqual(2, forms[0].fields.len);+ try testing.expectEqual("", forms[0].fields[0].value.?);+ try testing.expectEqual("*****", forms[0].fields[1].value.?);+}+test "browser.forms: form with select" {const forms = try testForms(\\<form>diff --git a/src/browser/webapi/element/html/Input.zig b/src/browser/webapi/element/html/Input.zigindex c0a413354..10c925307 100644--- a/src/browser/webapi/element/html/Input.zig+++ b/src/browser/webapi/element/html/Input.zig@@ -157,9 +157,11 @@ pub fn getValue(self: *const Input) []const u8 {// Spec-compliant `getValue` exposes the raw password to JS, FormData, CSS// `:invalid` checks, etc. — but LLM-facing dumps (semantic tree, form// detection, accessibility tree) must not echo what the agent just typed.+// An empty password stays empty, so a client can tell it still needs input.pub fn getRedactedValue(self: *const Input) []const u8 {- if (self._input_type == .password) return "*****";- return self.getValue();+ const value = self.getValue();+ if (self._input_type == .password and value.len > 0) return "*****";+ return value;}pub fn setValue(self: *Input, value: []const u8, frame: *Frame) !void {