Skip to content

Lightpanda: the headless browser designed for AI and automation

axnode: set settable depending readonly

Pierre Tachoire47334026795a
diff --git a/src/server/cdp/AXNode.zig b/src/server/cdp/AXNode.zig
index 05ce41345..cb0bb9fd9 100644
--- a/src/server/cdp/AXNode.zig
+++ b/src/server/cdp/AXNode.zig
@@ -361,6 +361,7 @@ pub const Writer = struct {
.input => {
const input = el.as(DOMNode.Element.Html.Input);
const is_disabled = el.isDisabled();
+ const is_readonly = el.hasAttributeInterned("readonly");
if (is_disabled) {
try self.writeAXProperty(.{ .name = .disabled, .value = .{ .boolean = true } }, w);
@@ -371,24 +372,43 @@ pub const Writer = struct {
}
switch (input._input_type) {
- .text, .email, .tel, .url, .search, .password, .number => {
+ .text, .email, .tel, .url, .password => {
try self.writeAXProperty(.{ .name = .editable, .value = .{ .token = "plaintext" } }, w);
- if (!is_disabled) {
+ if (!is_disabled and !is_readonly) {
try self.writeAXProperty(.{ .name = .settable, .value = .{ .booleanOrUndefined = true } }, w);
}
try self.writeAXProperty(.{ .name = .multiline, .value = .{ .boolean = false } }, w);
try self.writeAXProperty(.{ .name = .readonly, .value = .{ .boolean = el.hasAttributeInterned("readonly") } }, w);
try self.writeAXProperty(.{ .name = .required, .value = .{ .boolean = el.hasAttributeInterned("required") } }, w);
},
+ .search => {
+ try self.writeAXProperty(.{ .name = .editable, .value = .{ .token = "plaintext" } }, w);
+ if (!is_disabled and !is_readonly) {
+ try self.writeAXProperty(.{ .name = .settable, .value = .{ .booleanOrUndefined = true } }, w);
+ }
+ },
+ .number => {
+ try self.writeAXProperty(.{ .name = .editable, .value = .{ .token = "plaintext" } }, w);
+ if (!is_disabled and !is_readonly) {
+ try self.writeAXProperty(.{ .name = .settable, .value = .{ .booleanOrUndefined = true } }, w);
+ }
+ try self.writeAXProperty(.{ .name = .required, .value = .{ .boolean = el.hasAttributeInterned("required") } }, w);
+ },
.checkbox, .radio => {
const is_checked = el.hasAttributeInterned("checked");
try self.writeAXProperty(.{ .name = .checked, .value = .{ .token = if (is_checked) "true" else "false" } }, w);
},
+ .range, .color, .date, .time, .@"datetime-local", .month, .week => {
+ if (!is_disabled) {
+ try self.writeAXProperty(.{ .name = .settable, .value = .{ .booleanOrUndefined = true } }, w);
+ }
+ },
else => {},
}
},
.textarea => {
const is_disabled = el.isDisabled();
+ const is_readonly = el.hasAttributeInterned("readonly");
if (is_disabled) {
try self.writeAXProperty(.{ .name = .disabled, .value = .{ .boolean = true } }, w);
@@ -398,7 +418,7 @@ pub const Writer = struct {
try self.writeAXProperty(.{ .name = .focusable, .value = .{ .booleanOrUndefined = true } }, w);
}
try self.writeAXProperty(.{ .name = .editable, .value = .{ .token = "plaintext" } }, w);
- if (!is_disabled) {
+ if (!is_disabled and !is_readonly) {
try self.writeAXProperty(.{ .name = .settable, .value = .{ .booleanOrUndefined = true } }, w);
}
try self.writeAXProperty(.{ .name = .multiline, .value = .{ .boolean = true } }, w);