Skip to content

Lightpanda: the headless browser designed for AI and automation

webapi: correct rellist.support <a>, <area>, and <form>

Karl Seguin4cfb7382ec1f
diff --git a/src/browser/tests/element/rel_list.html b/src/browser/tests/element/rel_list.html
index 50c7c5449..f77a748fc 100644
--- a/src/browser/tests/element/rel_list.html
+++ b/src/browser/tests/element/rel_list.html
@@ -1,4 +1,5 @@
<!DOCTYPE html>
+<meta name=lp-mode content=test>
<script src="../testing.js"></script>
<link id=l1 rel="stylesheet" href="data:text/css,">
@@ -11,7 +12,9 @@
testing.expectEqual(true, rl.supports('MODULEPRELOAD'));
testing.expectEqual(true, rl.supports('preload'));
testing.expectEqual(true, rl.supports('stylesheet'));
- testing.expectEqual(false, rl.supports('prefetch'));
+ testing.diverges("Chrome implements <link rel=prefetch>", () => {
+ testing.expectEqual(false, rl.supports('prefetch'));
+ });
}
</script>
@@ -38,6 +41,34 @@
<output id=o1 for="x"></output>
<iframe id=if1></iframe>
<svg><a id=sa1 rel="noopener"></a></svg>
+<form id=f1 rel="noopener"></form>
+
+<script id=hyperlink_supports>
+{
+ // Everything but <link> supports only the opener-related keywords.
+ for (const el of [$('#a1'), $('#ar1'), $('#sa1'), $('#f1')]) {
+ const rl = el.relList;
+ testing.expectEqual(true, rl.supports('noopener'));
+ testing.expectEqual(true, rl.supports('NOREFERRER'));
+ testing.expectEqual(true, rl.supports('opener'));
+ testing.expectEqual(false, rl.supports('stylesheet'));
+ testing.expectEqual(false, rl.supports('nofollow'));
+ }
+ testing.expectEqual(false, $('#l1').relList.supports('noopener'));
+}
+</script>
+
+<script id=form_rel>
+{
+ const form = $('#f1');
+ testing.expectEqual('noopener', form.rel);
+ testing.expectEqual(1, form.relList.length);
+ form.relList.add('noreferrer');
+ testing.expectEqual('noopener noreferrer', form.getAttribute('rel'));
+ form.rel = 'opener';
+ testing.expectEqual('opener', form.relList.value);
+}
+</script>
<script id=put_forwards_value>
{
@@ -50,6 +81,7 @@
[$('#o1'), 'htmlFor', 'for'],
[$('#if1'), 'sandbox', 'sandbox'],
[$('#sa1'), 'relList', 'rel'],
+ [$('#f1'), 'relList', 'rel'],
];
for (const [el, prop, attr] of cases) {
const list = el[prop];
diff --git a/src/browser/webapi/collections/DOMTokenList.zig b/src/browser/webapi/collections/DOMTokenList.zig
index f2b821df6..3767b624a 100644
--- a/src/browser/webapi/collections/DOMTokenList.zig
+++ b/src/browser/webapi/collections/DOMTokenList.zig
@@ -96,7 +96,10 @@ pub fn supports(self: *const DOMTokenList, token: []const u8, frame: *Frame) !bo
"allow-same-origin", "allow-scripts", "allow-storage-access-by-user-activation", "allow-top-navigation",
"allow-top-navigation-by-user-activation", "allow-top-navigation-to-custom-protocols",
},
- .rel => &.{ "stylesheet", "preload", "modulepreload" },
+ .rel => switch (self._element.getTag()) {
+ .link => &.{ "stylesheet", "preload", "modulepreload" },
+ else => &.{ "noopener", "noreferrer", "opener" },
+ },
// no supported tokens defined
.class, .part, .sizes, .@"for" => return error.TypeError,
};
diff --git a/src/browser/webapi/element/html/Form.zig b/src/browser/webapi/element/html/Form.zig
index 463942038..d257509f2 100644
--- a/src/browser/webapi/element/html/Form.zig
+++ b/src/browser/webapi/element/html/Form.zig
@@ -137,6 +137,15 @@ fn setAction(self: *Form, value: []const u8, frame: *Frame) !void {
try self.asElement().setAttributeSafe(comptime .wrap("action"), .wrap(value), frame);
}
+fn getRelList(self: *Form, frame: *Frame) !*collections.DOMTokenList {
+ return self.asElement().getRelList(frame);
+}
+
+fn setRelList(self: *Form, value: lp.String, frame: *Frame) !void {
+ const list = try self.getRelList(frame);
+ try list.setValue(value, frame);
+}
+
fn getAcceptCharset(self: *Form) []const u8 {
return self.asElement().getAttributeSafe(.wrap("accept-charset")) orelse "";
}
@@ -373,6 +382,8 @@ pub const JsApi = struct {
pub const method = bridge.accessor(Form.getMethod, Form.setMethod, .{ .ce_reactions = true });
pub const action = bridge.accessor(Form.getAction, Form.setAction, .{ .ce_reactions = true });
pub const target = reflect.string("target");
+ pub const rel = reflect.string("rel");
+ pub const relList = bridge.accessor(Form.getRelList, Form.setRelList, .{ .ce_reactions = true });
pub const acceptCharset = bridge.accessor(Form.getAcceptCharset, Form.setAcceptCharset, .{ .ce_reactions = true });
pub const enctype = bridge.accessor(Form.getEnctype, Form.setEnctype, .{ .ce_reactions = true });
pub const noValidate = reflect.boolean("novalidate");