Skip to content

Lightpanda: the headless browser designed for AI and automation

document cleanup after bad parse start

Karl Seguin4d16a0c4b6b1
diff --git a/src/browser/webapi/Document.zig b/src/browser/webapi/Document.zig
index ee95c6d91..0e13ee81e 100644
--- a/src/browser/webapi/Document.zig
+++ b/src/browser/webapi/Document.zig
@@ -1163,6 +1163,9 @@ pub fn open(self: *Document, call_frame: *Frame) !*Document {
try frame._script_created_parser_docs.append(frame.arena, self);
}
self._script_created_parser = Parser.Streaming.init(frame.arena, doc_node, frame, .{ .allow_declarative_shadow = true });
+ // on start() failure the internal `handle` isn't yet create. So we can't
+ // call done() and we don't want any subsequent cleanup to call done().
+ errdefer self._script_created_parser = null;
try self._script_created_parser.?.start();
frame._parse_mode = .document;